refactor(client_defaulter)

e2e/paths/02-client/21_defaulter.spec.js

@@ -28,12 +28,12 @@ describe('Client defaulter path', () => {
         const salesPersonName =
             await page.waitToGetProperty(selectors.clientDefaulter.firstSalesPersonName, 'innerText');
 
-        expect(clientName).toEqual('Ororo Munroe');
+        expect(clientName).toEqual('Bruce Banner');
-        expect(salesPersonName).toEqual('salesPersonNick');
+        expect(salesPersonName).toEqual('developer');
     });
 
     it('should first observation not changed', async() => {
-        const expectedObservation = 'Madness, as you know, is like gravity, all it takes is a little push';
+        const expectedObservation = 'Meeting with Black Widow 21st 9am';
         const result = await page.waitToGetProperty(selectors.clientDefaulter.firstObservation, 'value');
 
         expect(result).toContain(expectedObservation);

modules/client/back/methods/defaulter/filter.js

@@ -58,12 +58,12 @@ module.exports = Self => {
                         DISTINCT c.id clientFk,
                         c.name clientName,
                         c.salesPersonFk,
-                        u.nickname salesPersonName,
+                        u.name salesPersonName,
                         d.amount,
                         co.created,
                         co.text observation,
                         uw.id workerFk,
-                        uw.nickname workerName, 
+                        uw.name workerName, 
                         c.creditInsurance,
                         d.defaulterSinced
                     FROM vn.defaulter d

modules/client/back/models/defaulter.json

@@ -9,19 +9,19 @@
   },
   "properties": {
     "id": {
-      "type": "Number"
+      "type": "number"
     },
     "created": {
-      "type": "Date"
+      "type": "date"
     },
     "amount": {
-      "type": "Number"
+      "type": "number"
     },
     "defaulterSinced": {
-      "type": "Number"
+      "type": "number"
     },
     "hasChanged": {
-      "type": "Number"
+      "type": "number"
     }
   },
   "relations": {

modules/client/front/defaulter/index.html

@@ -3,6 +3,7 @@
     url="Defaulters/filter"
     filter="::$ctrl.filter"
     limit="20"
+    order="amount DESC"
     data="defaulters"
     auto-load="true">
 </vn-crud-model>
@@ -26,7 +27,7 @@
                     <h6 translate>Total</h6>
                     <vn-label-value 
                         label="Balance due" 
-                        value="{{$ctrl.balanceDueTotal | currency: 'EUR': 2}}">
+                        value="{{::$ctrl.balanceDueTotal | currency: 'EUR': 2}}">
                     </vn-label-value>
                 </div>
             </div>
@@ -70,13 +71,13 @@
                         </th>
                         <th 
                             vn-tooltip="Last observation date"
-                            field="created" 
+                            field="created">
-                            shrink-datetime>
+                            <span translate>L. O. Date</span>
-                            <span translate>Last observation D.</span>
                         </th>
                         <th 
                             vn-tooltip="Credit insurance"
-                            field="creditInsurance" >
+                            field="creditInsurance"
+                            shrink>
                             <span translate>Credit I.</span>
                         </th>
                         <th field="defaulterSinced">
@@ -124,13 +125,13 @@
                                 ng-model="defaulter.observation">
                             </vn-textarea>
                         </td>
-                        <td shrink-datetime>
+                        <td shrink-date>
                             <span class="chip {{::$ctrl.chipColor(defaulter.created)}}">
                                 {{::defaulter.created | date: 'dd/MM/yyyy'}}
                             </span>
                         </td>
-                        <td>{{::defaulter.creditInsurance | currency: 'EUR': 2}}</td>
+                        <td shrink>{{::defaulter.creditInsurance | currency: 'EUR': 2}}</td>
-                        <td>{{::defaulter.defaulterSinced | date: 'dd/MM/yyyy'}}</td>
+                        <td shrink-date>{{::defaulter.defaulterSinced | date: 'dd/MM/yyyy'}}</td>
                     </tr>
                 </tbody>
             </table>

modules/client/front/defaulter/index.js

@@ -53,16 +53,16 @@ export default class Controller extends Section {
                 }
             ]
         };
-    }
 
-    get balanceDueTotal() {
+        this.$http.get('Defaulters/filter')
-        let balanceDueTotal = 0;
+            .then(res => {
-        const defaulters = this.$.model.data || [];
+                if (!res.data) return 0;
 
-        for (let defaulter of defaulters)
+                this.balanceDueTotal = res.data.reduce(
-            balanceDueTotal += defaulter.amount;
+                    (accumulator, currentValue) => {
-
+                        return accumulator + (currentValue['amount'] || 0);
-        return balanceDueTotal;
+                    }, 0);
+            });
     }
 
     get checked() {

modules/client/front/defaulter/index.spec.js

@@ -36,17 +36,6 @@ describe('client defaulter', () => {
             });
         });
 
-        describe('balanceDueTotal() getter', () => {
-            it('should return balance due total', () => {
-                const data = controller.$.model.data;
-                const expectedAmount = data[0].amount + data[1].amount + data[2].amount;
-
-                const result = controller.balanceDueTotal;
-
-                expect(result).toEqual(expectedAmount);
-            });
-        });
-
         describe('chipColor()', () => {
             it('should return undefined when the date is the present', () => {
                 let today = new Date();
@@ -93,6 +82,7 @@ describe('client defaulter', () => {
                 const params = [{text: controller.defaulter.observation, clientFk: data[1].clientFk}];
 
                 jest.spyOn(controller.vnApp, 'showMessage');
+                $httpBackend.expect('GET', `Defaulters/filter`).respond(200);
                 $httpBackend.expect('POST', `ClientObservations`, params).respond(200, params);
 
                 controller.onResponse();

modules/client/front/defaulter/locale/es.yml

@@ -3,7 +3,7 @@ Add observation to all selected clients: Añadir observación a {{total}} client
 Balance D.: Saldo V.
 Credit I.: Crédito A.
 Last observation: Última observación
-Last observation D.: Fecha última O.
+L. O. Date: Fecha Ú. O.
 Last observation date: Fecha última observación
 Search client: Buscar clientes
 Worker who made the last observation: Trabajador que ha realizado la última observación