From f30b1ecff1f3e2e2811ffa5a318c919f7db48dd3 Mon Sep 17 00:00:00 2001
From: alexandre <alexandre@verdnatura.es>
Date: Fri, 20 Jan 2023 10:03:00 +0100
Subject: [PATCH] refs #4927 changed hook for validateAsync

---
 modules/supplier/back/models/supplier.js | 41 ++++++++++++++++--------
 1 file changed, 27 insertions(+), 14 deletions(-)

diff --git a/modules/supplier/back/models/supplier.js b/modules/supplier/back/models/supplier.js
index cba220af8..4e509aafc 100644
--- a/modules/supplier/back/models/supplier.js
+++ b/modules/supplier/back/models/supplier.js
@@ -113,24 +113,37 @@ module.exports = Self => {
             throw new UserError('You can not modify is pay method checked');
     });
 
+    Self.validateAsync('name', 'countryFk', hasSupplierSameName, {
+        message: 'A supplier with the same name already exists. Change the country.'
+    });
+
+    async function hasSupplierSameName(err, done) {
+        if (!this.name || !this.countryFk) done();
+        const supplier = await Self.app.models.Supplier.findOne(
+            {
+                where: {
+                    name: this.name,
+                    countryFk: this.countryFk
+                },
+                fields: ['id']
+            });
+
+        if (supplier && supplier.id != this.id)
+            err();
+
+        done();
+    }
+
     Self.observe('before save', async function(ctx) {
         const changes = ctx.data || ctx.instance;
         const orgData = ctx.currentInstance;
+
+        const socialName = changes.name || orgData.name;
         const hasChanges = orgData && changes;
+        const socialNameChanged = hasChanges
+         && orgData.socialName != socialName;
 
-        if (hasChanges) {
-            const name = changes.name || orgData.name;
-            const nameChanged = hasChanges && orgData.name != name;
-            const countryFk = changes.countryFk || orgData.countryFk;
-            const countryChanged = hasChanges && orgData.countryFk != countryFk;
-
-            if (nameChanged || countryChanged) {
-                if (!isAlpha(name)) throw new UserError('The social name has an invalid format');
-
-                const supplier = await Self.app.models.Supplier.findOne({where: {name, countryFk}, fields: ['id']});
-                if (supplier)
-                    throw new UserError('A supplier with the same name already exists. Change the country.');
-            }
-        }
+        if ((socialNameChanged) && !isAlpha(socialName))
+            throw new UserError('The social name has an invalid format');
     });
 };