refactor(ticket_sale): split e2e, change name backTest

e2e/paths/05-ticket/01-sale/02_edit_sale.spec.js

@@ -206,11 +206,13 @@ describe('Ticket Edit sale path', () => {
         expect(message.text).toContain('Data saved!');
     });
 
-    it('should select the third sale and create a pay back', async() => {
+    it('should log in as salesAssistant and navigate to ticket sales', async() => {
         await page.loginAndModule('salesAssistant', 'ticket');
         await page.accessToSearchResult('16');
         await page.accessToSection('ticket.card.sale');
+    });
 
+    it('should select the third sale and create a pay back', async() => {
         await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
         await page.waitToClick(selectors.ticketSales.moreMenu);
         await page.waitToClick(selectors.ticketSales.moreMenuPayBack);

modules/ticket/back/methods/sale/payBack.js

@@ -45,9 +45,9 @@ module.exports = Self => {
 
             const isClaimManager = await Self.app.models.Account.hasRole(userId, 'claimManager');
             const isSalesAssistant = await Self.app.models.Account.hasRole(userId, 'salesAssistant');
-            const checkRoles = isClaimManager || isSalesAssistant;
+            const hasValidRole = isClaimManager || isSalesAssistant;
 
-            if (!checkRoles)
+            if (!hasValidRole)
                 throw new UserError(`You don't have privileges to create pay back`);
 
             sales.forEach(sale => {

modules/ticket/back/methods/sale/specs/payBack.spec.js

@@ -26,7 +26,7 @@ describe('sale payBack()', () => {
         }
     });
 
-    it('should throw error for not have privileges', async() => {
+    it(`should throw an error if the user doesn't have privileges to create a pay back`, async() => {
         const tx = await models.Sale.beginTransaction({});
         const ctx = {req: {accessToken: {userId: 1}}};