From cdaf8a7a6771db503a724fb747e6df29ea13d751 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Mon, 2 Sep 2024 08:43:53 +0200
Subject: [PATCH 1/2] fix: refs #6900 fine tunning

---
 modules/invoiceIn/back/methods/invoice-in/filter.js    | 5 ++---
 modules/invoiceIn/back/methods/invoice-in/getTotals.js | 4 +++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/modules/invoiceIn/back/methods/invoice-in/filter.js b/modules/invoiceIn/back/methods/invoice-in/filter.js
index 8a884e211..936f7bb6c 100644
--- a/modules/invoiceIn/back/methods/invoice-in/filter.js
+++ b/modules/invoiceIn/back/methods/invoice-in/filter.js
@@ -138,9 +138,9 @@ module.exports = Self => {
                     ? {'ii.id': value}
                     : {'s.name': {like: `%${value}%`}};
             case 'from':
-                return {'ii.created': {gte: value}};
+                return {'ii.issued': {gte: value}};
             case 'to':
-                return {'ii.created': {lte: value}};
+                return {'ii.issued': {lte: value}};
             case 'fi':
                 return {'s.nif': value};
             case 'account':
@@ -173,7 +173,6 @@ module.exports = Self => {
         const stmt = new ParameterizedSQL(
             `SELECT
                 ii.id,
-                ii.serialNumber,
                 ii.serial,
                 ii.issued,
                 ii.isBooked,
diff --git a/modules/invoiceIn/back/methods/invoice-in/getTotals.js b/modules/invoiceIn/back/methods/invoice-in/getTotals.js
index 7bef9f7e9..c4e73abc2 100644
--- a/modules/invoiceIn/back/methods/invoice-in/getTotals.js
+++ b/modules/invoiceIn/back/methods/invoice-in/getTotals.js
@@ -27,10 +27,12 @@ module.exports = Self => {
 
         const [result] = await Self.rawSql(`
             SELECT iit.*,
-                    SUM(iidd.amount) totalDueDay
+                    SUM(iidd.amount) totalDueDay,
+                    SUM(iidd.foreignValue) totalDueDayForeignValue
                 FROM vn.invoiceIn ii
                     LEFT JOIN (
                         SELECT SUM(iit.taxableBase) totalTaxableBase,
+                                SUM(iit.foreignValue) totalTaxableBaseForeignValue, 
                                 CAST(
                                     SUM(IFNULL(iit.taxableBase * (1 + (ti.PorcentajeIva / 100)), iit.taxableBase)) 
                                         AS DECIMAL(10, 2)

From 4ea1177d385811cf2d8c42a9623fa3ad4c5323a6 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Mon, 2 Sep 2024 13:55:44 +0200
Subject: [PATCH 2/2] chore: refs #6900 fix test

---
 .../methods/invoice-in/specs/filter.spec.js   | 25 +------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js b/modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js
index ff2164783..48310b32a 100644
--- a/modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js
+++ b/modules/invoiceIn/back/methods/invoice-in/specs/filter.spec.js
@@ -47,29 +47,6 @@ describe('InvoiceIn filter()', () => {
         }
     });
 
-    it('should return the invoice in matching the serial number', async() => {
-        const tx = await models.InvoiceIn.beginTransaction({});
-        const options = {transaction: tx};
-
-        try {
-            const ctx = {
-                args: {
-                    serialNumber: '1002',
-                }
-            };
-
-            const result = await models.InvoiceIn.filter(ctx, {}, options);
-
-            expect(result.length).toEqual(1);
-            expect(result[0].serialNumber).toEqual(1002);
-
-            await tx.rollback();
-        } catch (e) {
-            await tx.rollback();
-            throw e;
-        }
-    });
-
     it('should return the invoice in matching the account', async() => {
         const tx = await models.InvoiceIn.beginTransaction({});
         const options = {transaction: tx};
@@ -158,7 +135,7 @@ describe('InvoiceIn filter()', () => {
 
             const result = await models.InvoiceIn.filter(ctx, {}, options);
 
-            expect(result.length).toEqual(5);
+            expect(result.length).toEqual(6);
 
             await tx.rollback();
         } catch (e) {