Merge branch 'master' into 7268-hotFix_getChanges_datestring

db/routines/util/procedures/connection_kill.sql

@@ -0,0 +1,13 @@
+DELIMITER $$
+CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`connection_kill`(
+	vConnectionId BIGINT
+)
+BEGIN
+/**
+ * Kill a connection
+ *
+ * @param vConnectionId
+ */
+	KILL vConnectionId;
+END$$
+DELIMITER ;

db/routines/vn/procedures/collection_assign.sql

@@ -30,10 +30,9 @@ BEGIN
 	-- Si hay colecciones sin terminar, sale del proceso
 	CALL collection_get(vUserFk);
 
-	SELECT (pc.maxNotReadyCollections - COUNT(*)) <= 0
+	SELECT (pc.maxNotReadyCollections - COUNT(*)) <= 0 INTO vHasTooMuchCollections
-		INTO vHasTooMuchCollections
+		FROM productionConfig pc
-		FROM tCollection
+			LEFT JOIN tCollection ON TRUE;
-			JOIN productionConfig pc;
 
 	DROP TEMPORARY TABLE tCollection;
 

db/routines/vn/procedures/sale_replaceItem.sql

@@ -81,6 +81,10 @@ BEGIN
 		ORDER BY (vQuantity % `grouping`) ASC
 		LIMIT 1;
 
+	IF vNewPrice IS NULL THEN
+		CALL util.throw('price retrieval failed');
+	END IF;
+
 	IF vNewPrice > vOldPrice THEN
 		SET vFinalPrice = vOldPrice;
 		SET vOption = 'substitution';
@@ -103,7 +107,8 @@ BEGIN
 			price)
 		SELECT vTicketFk,
 				vNewItemFk,
-				CEIL(vQuantity / vRoundQuantity) * vRoundQuantity, CONCAT('+ ', i.name),
+				CEIL(vQuantity / vRoundQuantity) * vRoundQuantity,
+				CONCAT('+ ', i.name),
 				vFinalPrice
 			FROM vn.item i
 			WHERE id = vNewItemFk;

db/routines/vn/procedures/ticket_close.sql

@@ -63,7 +63,7 @@ BEGIN
 		INSERT INTO ticketPackaging (ticketFk, packagingFk, quantity)
 			(SELECT vCurTicketFk, p.id, COUNT(*)
 				FROM expedition e 
-					JOIN packaging p ON p.itemFk = e.freightItemFk
+					JOIN packaging p ON p.id = e.packagingFk
 				WHERE e.ticketFk = vCurTicketFk AND p.isPackageReturnable
 					AND vWithPackage
 				GROUP BY p.itemFk);

db/routines/vn/triggers/ticketPackaging_beforeInsert.sql

@@ -4,7 +4,5 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`ticketPackaging_befor
 	FOR EACH ROW
 BEGIN
 	SET NEW.editorFk = account.myUser_getId();
-	SET NEW.workerFk = account.myUser_getId();
-
 END$$
 DELIMITER ;

db/versions/11016-pinkAralia/00-firstScript.sql

@@ -0,0 +1,5 @@
+-- Place your SQL code here
+ALTER TABLE vn.productionConfig ADD collectionNewLockname varchar(100) 
+    DEFAULT 'collection_new' NOT NULL COMMENT 'Lockname value for proc vn.collection_new';
+ALTER TABLE vn.productionConfig ADD collectionAssignLockname varchar(100) 
+    DEFAULT 'collection_assign' NULL COMMENT 'Lockname value for proc vn.collection_new';

db/versions/11021-bronzeErica/00-firstScript.sql

@@ -0,0 +1,13 @@
+
+	ALTER TABLE vn.productionConfig
+		DROP COLUMN IF EXISTS collectionNewLockname,
+		DROP COLUMN IF EXISTS collectionAssignLockname;
+
+	DELIMITER $$
+	CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`connection_kill`()
+	BEGIN
+
+	END$$
+	DELIMITER ;
+
+	GRANT EXECUTE ON PROCEDURE util.connection_kill TO 'developer';		

modules/item/back/methods/item/getBalance.js

@@ -27,8 +27,11 @@ module.exports = Self => {
 
         const where = filter.where;
         const query = 'CALL vn.item_getBalance(?, ?, ?)';
+        if (where?.date) {
+            where.date = new Date(where.date);
+            where.date.setHours(0, 0, 0, 0);
+        }
         const [diary] = await Self.rawSql(query, [where.itemFk, where.warehouseFk, where.date], myOptions);
-
         for (const entry of diary)
             if (entry.clientType === 'loses') entry.highlighted = true;
 

modules/route/back/methods/route/getExpeditionSummary.js

@@ -49,8 +49,7 @@ module.exports = Self => {
                             JOIN vn.agencyMode am ON am.id = r.agencyModeFk
                             JOIN vn.agency ag ON ag.id = am.agencyFk
                             LEFT JOIN vn.userConfig uc ON uc.userFk = account.myUser_getId()
-                        WHERE (r.created = util.VN_CURDATE() OR r.created = util.yesterday())
+                        WHERE t.routeFk = ?
-                            AND t.routeFk = ?
                         GROUP BY t.addressFk, e.itemPackingTypeFk
                     ) sub
                 GROUP BY addressFk

modules/ticket/back/methods/ticket/addSaleByCode.js

@@ -30,7 +30,7 @@ module.exports = Self => {
     });
 
     Self.addSaleByCode = async(ctx, barcode, quantity, ticketFk, warehouseFk, options) => {
-        const myOptions = {};
+        const myOptions = {userId: ctx.req.accessToken.userId};
         let tx;
 
         if (typeof options == 'object')