refs #6264 fix: rename variable

back/methods/vn-user/is-token-valid.js

@@ -1,5 +1,8 @@
+const tokenConfig = require('./token-config');
+
+module.exports = async token => {
+    const accessTokenConfig = await tokenConfig();
 
-module.exports = async(token, accessTokenConfig) => {
     const now = new Date();
     const differenceMilliseconds = now - token.created;
     const differenceSeconds = Math.floor(differenceMilliseconds / 1000);

back/methods/vn-user/renew-token.js

@@ -1,5 +1,7 @@
 const UserError = require('vn-loopback/util/user-error');
-const handlePromiseLogout = (Self, {id}, courtesyTime = 60) => {
+const tokenConfig = require('./token-config');
+const DEFAULT_COURTESY_TIME = 60;
+const handlePromiseLogout = (Self, {id}, courtesyTime = DEFAULT_COURTESY_TIME) => {
     new Promise(res => {
         setTimeout(() => {
             res(Self.logout(id));
@@ -23,14 +25,13 @@ module.exports = Self => {
     });
 
     Self.renewToken = async function(ctx) {
-        const models = Self.app.models;
+        const {accessToken: token} = ctx.req;
-        const token = ctx.req.accessToken;
 
         // Check if current token is valid
         const isValid = await Self.validateToken(token);
         if (!isValid) throw new UserError(`The renew period has not been exceeded`, 'periodNotExceeded');
-        const fields = ['courtesyTime'];
+
-        const {courtesyTime} = await models.AccessTokenConfig.findOne({fields});
+        const {courtesyTime} = await tokenConfig();
 
         // Schedule to remove current token
         handlePromiseLogout(Self, token, courtesyTime);

back/methods/vn-user/token-config.js

@@ -0,0 +1,9 @@
+const DEFAULT_FIELDS = ['renewPeriod', 'courtesyTime'];
+const {models} = require('vn-loopback/server/server');
+let currentAccessTokenConfig = null;
+module.exports = async(fields = DEFAULT_FIELDS) => {
+    if (currentAccessTokenConfig) return currentAccessTokenConfig;
+    const accessTokenConfig = await models.AccessTokenConfig.findOne({fields});
+    if (!accessTokenConfig) currentAccessTokenConfig = accessTokenConfig;
+    return accessTokenConfig;
+};

back/methods/vn-user/validate-token.js

@@ -14,9 +14,7 @@ module.exports = Self => {
     });
 
     Self.validateToken = async function(token) {
-        const fields = ['renewPeriod', 'courtesyTime'];
+        const isValid = await isTokenValid(token);
-        const accessTokenConfig = await Self.app.models.AccessTokenConfig.findOne({fields});
-        const isValid = await isTokenValid(token, accessTokenConfig);
         return isValid;
     };
 };

db/changes/234601/00-updateCourtesyTime.sql

@@ -0,0 +1,4 @@
+--  Auto-generated SQL script #202311061003
+UPDATE salix.accessTokenConfig
+	SET courtesyTime=60
+	WHERE id=1;

db/dump/fixtures.sql

@@ -2758,7 +2758,7 @@ INSERT INTO `vn`.`sectorCollectionSaleGroup` (`sectorCollectionFk`, `saleGroupFk
     VALUES
         (1, 1);
 
-INSERT INTO `vn`.`workerTimeControlConfig` (`id`, `dayBreak`, `dayBreakDriver`, `shortWeekBreak`, `longWeekBreak`, `weekScope`, `mailPass`, `mailHost`, `mailSuccessFolder`, `mailErrorFolder`, `mailUser`, `minHoursToBreak`, `breakHours`, `hoursCompleteWeek`, `startNightlyHours`, `endNightlyHours`, `maxTimePerDay`, `breakTime`, `timeToBreakTime`, `dayMaxTime`, `shortWeekDays`, `longWeekDays`, `teleworkingStart`, `teleworkingStartBreakTime`, `maxTimeToBreak`, `maxWorkShortCycle`, `maxWorkLongCycle`) 
+INSERT INTO `vn`.`workerTimeControlConfig` (`id`, `dayBreak`, `dayBreakDriver`, `shortWeekBreak`, `longWeekBreak`, `weekScope`, `mailPass`, `mailHost`, `mailSuccessFolder`, `mailErrorFolder`, `mailUser`, `minHoursToBreak`, `breakHours`, `hoursCompleteWeek`, `startNightlyHours`, `endNightlyHours`, `maxTimePerDay`, `breakTime`, `timeToBreakTime`, `dayMaxTime`, `shortWeekDays`, `longWeekDays`, `teleworkingStart`, `teleworkingStartBreakTime`, `maxTimeToBreak`, `maxWorkShortCycle`, `maxWorkLongCycle`)
     VALUES
         (1, 43200, 32400, 129600, 259200, 1080000, '', 'imap.verdnatura.es', 'Leidos.exito', 'Leidos.error', 'timeControl', 5.00, 0.33, 40, '22:00:00', '06:00:00', 72000, 1200, 18000, 72000, 6, 13, 28800, 32400, 3600, 561600, 950400);
 
@@ -2945,9 +2945,9 @@ INSERT INTO `vn`.`wagonTypeTray` (`id`, `typeFk`, `height`, `colorFk`)
         (2, 1, 50, 2),
         (3, 1, 0, 3);
 
-INSERT INTO `salix`.`accessTokenConfig` (`id`, `renewPeriod`, `renewInterval`)
+INSERT INTO `salix`.`accessTokenConfig` (`id`, `renewPeriod`, `courtesyTime`, `renewInterval`)
     VALUES
-        (1, 21600, 300);
+        (1, 21600, 60, 300);
 
 INSERT INTO `vn`.`travelConfig` (`id`, `warehouseInFk`, `warehouseOutFk`, `agencyFk`, `companyFk`)
     VALUES
@@ -2986,4 +2986,4 @@ INSERT INTO `vn`.`invoiceCorrectionType` (`id`, `description`)
     VALUES
         (1, 'Error in VAT calculation'),
         (2, 'Error in sales details'),
-        (3, 'Error in customer data');
+        (3, 'Error in customer data');

front/core/services/token.js

@@ -82,7 +82,7 @@ export default class Token {
             if (!data) return;
             this.renewPeriod = data.renewPeriod;
             this.stopRenewer();
-            this.inservalId = setInterval(() => this.checkValidity(), data.renewInterval * 1000);
+            this.intervalId = setInterval(() => this.checkValidity(), data.renewInterval * 1000);
         });
     }
 
@@ -113,7 +113,7 @@ export default class Token {
     }
 
     stopRenewer() {
-        clearInterval(this.inservalId);
+        clearInterval(this.intervalId);
     }
 }
 Token.$inject = ['vnInterceptor', '$http', '$rootScope'];