verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4270-route.create #1023

Merged
joan merged 13 commits from 4270-route.create into dev 2022-08-03 07:09:11 +00:00
Conversation 0 Commits 13 Files Changed 8 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 28deb34047 - Show all commits

10
modules/route/back/methods/route/specs/updateWorkCenter.spec.js
View File

@ -4,7 +4,7 @@ describe('route updateWorkCenter()', () => {
const routeId = 1; const routeId = 1;
it('should set the commission work center if the worker has workCenter', async() => { it('should set the commission work center if the worker has workCenter', async() => {
const tx = await models.Defaulter.beginTransaction({}); const tx = await models.Route.beginTransaction({});
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:28:16 +00:00
Outdated
Review
Copy Link

Es confuso iniciar la transacción en un modelo que no es el que vas a invocar en tu funcionalidad.

models.Defaulter vs models.Route

Es confuso iniciar la transacción en un modelo que no es el que vas a invocar en tu funcionalidad. models.Defaulter vs models.Route
try { try {
const developerId = 9; const developerId = 9;
const ctx = { const ctx = {
@ -26,13 +26,13 @@ describe('route updateWorkCenter()', () => {
} }
}); });
it(`should set the commission work center equals default work center if the worker hasn't workCenter`, async() => { it(`shoul set the default commision work center if that worker didn't have one yet`, async() => {
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:30:36 +00:00
Outdated
Review
Copy Link

Shoul set the default commision work center if that worker didn't have one yet

Shoul set the default commision work center if that worker didn't have one yet
const tx = await models.Defaulter.beginTransaction({}); const tx = await models.Route.beginTransaction({});
try { try {
const noExistentId = 2; const userWithoutWorkCenter = 2;
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:36:17 +00:00
Outdated
Review
Copy Link

¿Te refieres a el user "Customer" no tiene workCenter asignado? esta variable es confusa, dale un nombre que describa realmente lo que hace.

¿Te refieres a el user "Customer" no tiene workCenter asignado? esta variable es confusa, dale un nombre que describa realmente lo que hace.
const ctx = { const ctx = {
req: { req: {
accessToken: {userId: noExistentId} accessToken: {userId: userWithoutWorkCenter}
} }
}; };
const options = {transaction: tx}; const options = {transaction: tx};