verdnatura/salix
verdnatura
/
salix
3
5
Fork 2
Code Issues Pull Requests 67 Releases Wiki Activity

4077-login_recover-password & account_verifyEmail #1063

Merged
alexm merged 52 commits from 4077-login_recover-password into dev 2022-11-28 11:34:03 +00:00
Conversation 0 Commits 52 Files Changed 47 +18 -10
4 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 517422be8c - Show all commits

7
back/methods/account/recover-password.js
View File

@ -20,8 +20,11 @@ module.exports = Self => {
try {
await models.user.resetPassword({email});
alexm marked this conversation as resolved Outdated
alexm commented 2022-11-09 14:01:37 +00:00
Outdated
Review
Copy Link

He dejado esta ruta(recoverPassword) porque si se llama directamente resetPassword y el correo que se le pasa no pertenece a un usuario, devuelve un error al frontend.

Usando una ruta con try catch, hacemos que no devuelva nunca error y asi no pueden saber si ese correo es de un usuario nuestro o no.

He dejado esta ruta(recoverPassword) porque si se llama directamente resetPassword y el correo que se le pasa no pertenece a un usuario, devuelve un error al frontend. Usando una ruta con try catch, hacemos que no devuelva nunca error y asi no pueden saber si ese correo es de un usuario nuestro o no.
juan commented 2022-11-09 15:30:07 +00:00
Outdated
Review
Copy Link

Nomes deuria de ignorar el error de tipo "usuario no existe", tots els demes deuria de rellançarlos

catch(err) {
	if (err.code === 'EMAIL_NOT_FOUND')
    	console.error(err);
    else
    	throw err;
}
Nomes deuria de ignorar el error de tipo "usuario no existe", tots els demes deuria de rellançarlos ``` catch(err) { if (err.code === 'EMAIL_NOT_FOUND') console.error(err); else throw err; } ```
} catch (e) {
return;
} catch (err) {
if (err.code === 'EMAIL_NOT_FOUND')
return;
else
throw err;
}
};
};

2
db/changes/10502-november/00-aclUserPassword.sql Normal file
View File

@ -0,0 +1,2 @@
DELETE FROM `salix`.`ACL`
WHERE model = 'UserPassword';

9
front/salix/components/login/reset-password.js
View File

@ -1,6 +1,5 @@
import ngModule from '../../module';
import './style.scss';
const axios = require('axios');
alexm marked this conversation as resolved
juan commented 2022-11-09 15:41:02 +00:00
Review
Copy Link

Perque gastes axios y no el servei $http?

Perque gastes axios y no el servei $http?
export default class Controller {
constructor($scope, $element, $http, vnApp, $translate, $state, $location) {
@ -16,11 +15,7 @@ export default class Controller {
}
$onInit() {
const headers = {
Authorization: this.$location.$$search.access_token
};
axios.post('api/UserPasswords/findOne', null, {headers})
this.$http.get('UserPasswords/findOne')
.then(res => {
this.passRequirements = res.data;
});
@ -38,7 +33,7 @@ export default class Controller {
const newPassword = this.newPassword;
axios.post('api/users/reset-password', {newPassword}, {headers})
this.$http.post('users/reset-password', {newPassword}, {headers})
.then(() => {
this.vnApp.showSuccess(this.$translate.instant('Password changed!'));
this.$state.go('login');

10
modules/account/back/models/user-password.json
View File

@ -30,5 +30,13 @@
"type": "number",
"required": true
}
}
},
"acls": [
{
"accessType": "READ",
"principalType": "ROLE",
"principalId": "$everyone",
"permission": "ALLOW"
}
]
}