4791-refactor-sendsms #1160

Merged
pau merged 18 commits from 4791-refactor-sendsms into dev 2022-12-21 06:55:30 +00:00
Contributor
No description provided.
pau added the
CR / Tests passed
label 2022-11-21 08:31:54 +00:00
pau added 3 commits 2022-11-21 08:31:54 +00:00
pau requested review from jgallego 2022-11-21 08:32:08 +00:00
jgallego requested review from juan 2022-11-21 08:47:24 +00:00
jgallego refused to review 2022-11-21 08:47:27 +00:00
juan requested changes 2022-11-21 09:01:06 +00:00
@ -0,0 +2,4 @@
import './style.scss';
export default class sendSmsDialog {
constructor($element, $scope, $http, $translate, vnApp) {
Owner

Porqué no extiende a dialog?

Porqué no extiende a dialog?
pau marked this conversation as resolved
@ -0,0 +10,4 @@
this.vnApp = vnApp;
}
open(route) {
Owner

En vez de pasar la ruta, emitir un evento send al cual te conectas desde donde se use el componente y envias el sms.

En vez de pasar la ruta, emitir un evento `send` al cual te conectas desde donde se use el componente y envias el sms.
pau marked this conversation as resolved
@ -0,0 +34,4 @@
this.vnApp.showMessage(this.$t.instant('SMS sent!'));
});
} catch (e) {
this.vnApp.showError(this.$t.instant(e.message));
Owner

Solo se debería traducir los UserError

Solo se debería traducir los `UserError`
pau marked this conversation as resolved
@ -0,0 +41,4 @@
}
}
sendSmsDialog.$inject = ['$element', '$scope', '$http', '$translate', 'vnApp'];
Owner

Los servicios '$http', '$translate', 'vnApp' no es necesario inyectarlos, si se extiende la clase Dialog, que hereda de Component, ya vienen "de serie".

Los servicios `'$http', '$translate', 'vnApp'` no es necesario inyectarlos, si se extiende la clase `Dialog`, que hereda de `Component`, ya vienen "de serie".
pau marked this conversation as resolved
@ -118,2 +116,2 @@
sms="$ctrl.newSMS">
</vn-client-sms>
<vn-sms-dialog
vn-id="sms"
Owner

Falta tabulación.

Falta tabulación.
pau marked this conversation as resolved
pau added 1 commit 2022-11-22 06:59:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
4bd643143b
requested changes refs #4791 @1h
pau added 1 commit 2022-11-22 07:01:44 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
3b66da20ca
Merge branch 'dev' into 4791-refactor-sendsms
pau requested review from juan 2022-11-22 07:01:53 +00:00
pau added 2 commits 2022-11-23 07:20:21 +00:00
juan requested changes 2022-11-23 18:04:28 +00:00
@ -0,0 +32,4 @@
if (this.charactersRemaining() < 0)
throw new Error(`The message it's too long`);
this.$http.post(this.route, this.sms).then(res => {
Owner

En lugar de llamar a una ruta, emitir un evento send, si tienes dudas me dices y lo hablamos.

En lugar de llamar a una ruta, emitir un evento `send`, si tienes dudas me dices y lo hablamos.
pau marked this conversation as resolved
@ -0,0 +43,4 @@
}
}
ngModule.vnComponent('vnSmsDialog', {
Owner

Definir este componente en salix en lugar de el core.

Definir este componente en salix en lugar de el core.
pau marked this conversation as resolved
pau added 1 commit 2022-11-24 13:15:57 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
7c71e40cc5
Merge branch 'dev' into 4791-refactor-sendsms
pau added 2 commits 2022-11-25 07:24:32 +00:00
pau added 1 commit 2022-11-25 08:59:12 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8f98082910
refs #4791 @2h
pau added 1 commit 2022-11-25 09:21:23 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
526bd5851b
Merge branch 'dev' into 4791-refactor-sendsms
pau added 2 commits 2022-11-30 06:12:35 +00:00
pau requested review from juan 2022-11-30 06:13:15 +00:00
pau added 1 commit 2022-11-30 12:13:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
9ed9c1a82c
Delete sendsms from core/components
juan approved these changes 2022-12-09 07:24:15 +00:00
@ -0,0 +11,4 @@
this: this
}
});
document.addEventListener('openSmsDialog', e => {
Owner

Açò haviem quedat que ja no feia falta, no?

Açò haviem quedat que ja no feia falta, no?
pau added 1 commit 2022-12-19 12:26:07 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
5a01e49f27
Merge branch 'dev' into 4791-refactor-sendsms
pau added 1 commit 2022-12-20 07:12:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
d8cae400a8
Merge branch 'dev' into 4791-refactor-sendsms
pau added 1 commit 2022-12-20 11:01:49 +00:00
gitea/salix/pipeline/head This commit looks good Details
1305513b07
Merge branch 'dev' into 4791-refactor-sendsms
juan approved these changes 2022-12-20 16:56:55 +00:00
pau added 1 commit 2022-12-21 06:38:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
c9b4e1ab9a
Merge branch 'dev' into 4791-refactor-sendsms
pau merged commit 04055f2294 into dev 2022-12-21 06:55:30 +00:00
pau deleted branch 4791-refactor-sendsms 2022-12-21 06:55:31 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1160
No description provided.