verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

closes 4732 etiquetas con QR para previa y item #1163

Merged
pau merged 35 commits from 4732-previa-label into dev 2023-01-18 08:26:11 +00:00
Conversation 2 Commits 35 Files Changed 15 +3 -6
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f7a25c64b5 - Show all commits

9
print/templates/reports/previa-label/sql/sector.sql
View File

@ -1,7 +1,4 @@
SELECT
`s`.`description`
FROM
`vn`.`saleGroup` sg
SELECT `s`.`description`
FROM `vn`.`saleGroup` sg
pau marked this conversation as resolved Outdated
guillermo commented 2023-01-12 12:40:18 +00:00
Outdated
Review
Copy Link

Aquí formatearía bien el SQL, ya que no cumple con los estándares acordados, aquí tienes la página de la wiki: https://wiki.verdnatura.es/index.php/Convenciones_SQL

Aquí formatearía bien el SQL, ya que no cumple con los estándares acordados, aquí tienes la página de la wiki: https://wiki.verdnatura.es/index.php/Convenciones_SQL
JOIN `vn`.`sector` s ON `sg`.`sectorFk` = `s`.`id`
pau marked this conversation as resolved Outdated
guillermo commented 2023-01-12 14:18:14 +00:00
Outdated
Review
Copy Link

Aun sigue estando mal, sería de la siguiente forma:

SELECT s.description
	FROM vn.saleGroup sg
		JOIN vn.sector s ON s.id = sg.sectorFk
	WHERE sg.id = ?
Aun sigue estando mal, sería de la siguiente forma: ``` SELECT s.description FROM vn.saleGroup sg JOIN vn.sector s ON s.id = sg.sectorFk WHERE sg.id = ? ```
WHERE
`sg`.`id` = ?
WHERE `sg`.`id` = ?