verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 55 Releases Wiki Activity

4794-mdb_block #1170

Merged
vicent merged 17 commits from 4794-mdb_block into dev 2022-12-22 09:19:16 +00:00
Conversation 0 Commits 17 Files Changed 13 +6 -16
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1a616fa1d4 - Show all commits

22
modules/mdb/back/methods/mdbApp/unlock.js
View File

@ -26,25 +26,15 @@ module.exports = Self => {
const models = Self.app.models;
const myOptions = {};
let tx;
if (typeof options == 'object')
vicent marked this conversation as resolved
joan commented 2022-12-15 07:23:59 +00:00
Review
Copy Link

Llevar tot lo referent a tx i try-catch

Llevar tot lo referent a tx i try-catch
Object.assign(myOptions, options);
try {
const mdbApp = await models.MdbApp.findById(appName, null, myOptions);
const updatedMdbApp = await mdbApp.updateAttributes({
userFk: null,
locked: null
}, myOptions);
const mdbApp = await models.MdbApp.findById(appName, null, myOptions);
const updatedMdbApp = await mdbApp.updateAttributes({
userFk: null,
vicent marked this conversation as resolved Outdated
joan commented 2022-12-13 07:31:49 +00:00
Outdated
Review
Copy Link

En este caso no es necesario transaccionar si no se te pasa una transacción

En este caso no es necesario transaccionar si no se te pasa una transacción
locked: null
}, myOptions);
if (tx) await tx.commit();
return updatedMdbApp;
} catch (e) {
if (tx) await tx.rollback();
throw e;
}
return updatedMdbApp;
};
};