verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 54 Releases Wiki Activity

4797-lilium-worker-notifications #1229

Merged
pau merged 37 commits from 4797-lilium-worker-notifications into dev 2023-02-02 08:53:29 +00:00
Conversation 0 Commits 37 Files Changed 8 +8 -15
3 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3184dcd39d - Show all commits

6
db/changes/230401/00-acl_notifications.sql
View File

@ -1,4 +1,4 @@
INSERT INTO `salix`.`ACL` (model,property,accessType,principalId)
VALUES ('NotificationSubscription','*','*','employee');
INSERT INTO `salix`.`ACL` (model,property,accessType,principalId)
VALUES ('NotificationAcl','*','*','employee');
VALUES
('NotificationSubscription','*','*','employee'),
pau marked this conversation as resolved Outdated
alexm commented 2023-01-25 06:37:16 +00:00
Outdated
Review
Copy Link

INSERT INTO salix.ACL (model,property,accessType,principalId)
VALUES ('NotificationAcl','*','READ','employee');

INSERT INTO `salix`.`ACL` (model,property,accessType,principalId) VALUES ('NotificationAcl','*','READ','employee');
('NotificationAcl','*','READ','employee');

14
db/changes/230401/00-alter_notSubs.sql
View File

@ -1,10 +1,4 @@
CREATE OR REPLACE TABLE `util`.`notificationSubscription` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`notificationFk` int(11) NOT NULL,
`userFk` int(10) unsigned NOT NULL,
PRIMARY KEY (`id`),
KEY `notificationSubscription_ibfk_1` (`notificationFk`),
KEY `notificationSubscription_ibfk_2` (`userFk`),
CONSTRAINT `notificationSubscription_ibfk_1` FOREIGN KEY (`notificationFk`) REFERENCES `notification` (`id`) ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT `notificationSubscription_ibfk_2` FOREIGN KEY (`userFk`) REFERENCES `account`.`user` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
ALTER TABLE util.notificationSubscription
pau marked this conversation as resolved Outdated
alexm commented 2023-01-25 06:37:44 +00:00
Outdated
Review
Copy Link

Has contemplat que se borren tots els registres de la taula?

Has contemplat que se borren tots els registres de la taula?
ADD Id int(11) auto_increment NULL,
pau marked this conversation as resolved Outdated
alexm commented 2023-02-01 07:01:16 +00:00
Outdated
Review
Copy Link

id

**id**
DROP PRIMARY KEY,
ADD CONSTRAINT PRIMARY KEY (Id);
pau marked this conversation as resolved Outdated
alexm commented 2023-02-01 07:01:23 +00:00
Outdated
Review
Copy Link

id

**id**

3
db/dump/structure.sql
View File

@ -19726,10 +19726,9 @@ DROP TABLE IF EXISTS `notificationSubscription`;
/*!40101 SET @saved_cs_client = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `notificationSubscription` (
`id` int(11) NOT NULL AUTO_INCREMENT,
`notificationFk` int(11) NOT NULL,
pau marked this conversation as resolved Outdated
alexm commented 2023-01-09 08:31:44 +00:00
Outdated
Review
Copy Link

Minúscula

Minúscula
alexm commented 2023-01-23 06:46:36 +00:00
Outdated
Review
Copy Link

Esto no debería estar en el changes también???

Esto no debería estar en el changes también???
`userFk` int(10) unsigned NOT NULL,
PRIMARY KEY (`id`),
PRIMARY KEY (`notificationFk`,`userFk`),
KEY `notificationSubscription_ibfk_1` (`notificationFk`),
pau marked this conversation as resolved Outdated
alexm commented 2023-01-09 08:31:46 +00:00
Outdated
Review
Copy Link

Minúscula

Minúscula
KEY `notificationSubscription_ibfk_2` (`userFk`),
pau marked this conversation as resolved Outdated
alexm commented 2023-01-09 08:33:25 +00:00
Outdated
Review
Copy Link

Hace falta añadir KEY notificationSubscription_ibfk_1 (notificationFk) ?

Hace falta añadir `KEY `notificationSubscription_ibfk_1` (`notificationFk`)` ?
CONSTRAINT `notificationSubscription_ibfk_1` FOREIGN KEY (`notificationFk`) REFERENCES `notification` (`id`) ON DELETE CASCADE ON UPDATE CASCADE,