verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 49 Releases Wiki Activity

4873-zone.delivery-day #1248

Merged
vicent merged 8 commits from 4873-zone.delivery-day into dev 2023-02-03 12:28:36 +00:00
Conversation 0 Commits 8 Files Changed 2 +9 -6
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 484b8d42e1 - Show all commits

15
modules/zone/back/methods/zone/getZoneClosing.js
View File

@ -30,8 +30,11 @@ module.exports = Self => {
if (typeof options == 'object')
Object.assign(myOptions, options);
const dated = new Date(date);
vicent marked this conversation as resolved Outdated
juan commented 2023-01-19 20:10:00 +00:00
Outdated
Review
Copy Link

Esto es necesario? Si se define el argumento como tipo Date debería llegar una fecha

Esto es necesario? Si se define el argumento como tipo Date debería llegar una fecha
const dayName = dated.toString().split(' ')[0];
vicent marked this conversation as resolved Outdated
juan commented 2023-01-19 20:31:31 +00:00
Outdated
Review
Copy Link

No nesario si se pasa directamente date a la función

No nesario si se pasa directamente date a la función
query = `
SELECT *
SELECT *
FROM (
SELECT
DISTINCT z.id,
@ -42,16 +45,16 @@ module.exports = Self => {
FROM vn.zone z
JOIN agencyMode am ON am.id = z.agencyModeFk
LEFT JOIN zoneEvent ze ON ze.zoneFk = z.id
WHERE
WHERE
(
vicent marked this conversation as resolved Outdated
juan commented 2023-01-26 16:41:00 +00:00
Outdated
Review
Copy Link

S'ha de tindre en compte tambe la columna type de zoneEvent, mira el WHERE del procediment vn.zone_getOptionsForLanding

S'ha de tindre en compte tambe la columna `type` de `zoneEvent`, mira el WHERE del procediment `vn.zone_getOptionsForLanding`
vicent commented 2023-01-27 07:30:37 +00:00
Outdated
Review
Copy Link

Pero aixo ja ho fa:

 WHERE
                        (
                            ze.dated = ?
                            OR ? BETWEEN ze.started AND ze.ended
                            OR ze.weekDays & (1 << WEEKDAY(?))
                        )

pq depen del camps q tinga rellenats es un type o altre.

Pero aixo ja ho fa: ``` WHERE ( ze.dated = ? OR ? BETWEEN ze.started AND ze.ended OR ze.weekDays & (1 << WEEKDAY(?)) ) ``` pq depen del camps q tinga rellenats es un type o altre.
vicent commented 2023-01-27 07:58:14 +00:00
Outdated
Review
Copy Link

Vale res, he vist q pot tindre started, ended y weekDays rellenat. Pensava q eren exclusius.

Vale res, he vist q pot tindre started, ended y weekDays rellenat. Pensava q eren exclusius.
dated = ?
OR ? BETWEEN started AND ended
OR INSTR(weekDays, SUBSTRING(DAYNAME(?), 1, 3) ) > 0
dated = ?
OR ? BETWEEN started AND ended
OR weekDays LIKE ?
vicent marked this conversation as resolved Outdated
juan commented 2023-01-19 20:30:18 +00:00
Outdated
Review
Copy Link

Pasar la fecha directamnte y comparar así: ze.weekDays & (1 << WEEKDAY(?))

Además hay que tener en cuenta el tipo de evento type.

Todas las columnas de la consulta debería llevar el alias de la tabla.

Pasar la fecha directamnte y comparar así: `ze.weekDays & (1 << WEEKDAY(?))` Además hay que tener en cuenta el tipo de evento `type`. Todas las columnas de la consulta debería llevar el alias de la tabla.
)
vicent marked this conversation as resolved Outdated
juan commented 2023-01-26 16:38:05 +00:00
Outdated
Review
Copy Link

N'hi ha una tabulació de mes en tota la consulta, punt i coma no fa falta al final si nomes es una consulta.

N'hi ha una tabulació de mes en tota la consulta, punt i coma no fa falta al final si nomes es una consulta.
AND z.id IN (?)
ORDER BY type='day' DESC, type='range' DESC, type='indefinitely' DESC) z
GROUP BY z.id`;
return Self.rawSql(query, [date, date, date, zoneIds], myOptions);
return Self.rawSql(query, [date, date, dayName, zoneIds], myOptions);
vicent marked this conversation as resolved Outdated
juan commented 2023-01-19 20:31:45 +00:00
Outdated
Review
Copy Link

Pasar date en lugar de dayName

Pasar `date` en lugar de `dayName`
};
};