verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

fix: test e2e #1276

Merged
vicent merged 7 commits from fix_e2e_item.tags into dev 2023-01-30 13:36:10 +00:00
Conversation 0 Commits 7 Files Changed 2 +10 -26
2 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
modules/item/back/methods/tag/onSubmit.js
View File

@ -47,44 +47,32 @@ module.exports = function(Self) {
}
try {
const promises = [];
if (args.deletes) {
for (const itemTagId of args.deletes) {
const itemTagDeleted = models.ItemTag.destroyById(itemTagId, myOptions);
promises.push(itemTagDeleted);
}
for (const itemTagId of args.deletes)
await models.ItemTag.destroyById(itemTagId, myOptions);
}
if (args.updates) {
for (const row of args.updates) {
if (row.data.priority) {
const itemTag = await models.ItemTag.findById(row.where.id, null, myOptions);
const itemTagUpdatedPriority = itemTag.updateAttributes({
await itemTag.updateAttributes({
priority: row.data.priority + args.maxPriority
}, myOptions);
promises.push(itemTagUpdatedPriority);
}
}
for (const row of args.updates) {
const itemTag = await models.ItemTag.findById(row.where.id, null, myOptions);
const itemTagUpdated = itemTag.updateAttributes(row.data, myOptions);
promises.push(itemTagUpdated);
await itemTag.updateAttributes(row.data, myOptions);
}
}
if (args.creates) {
for (const itemTag of args.creates) {
const newItemTag = models.ItemTag.create(itemTag, myOptions);
promises.push(newItemTag);
for (const itemTag of args.creates)
await models.ItemTag.create(itemTag, myOptions);
}
}
const resolvedPromises = await Promise.all(promises);
if (tx) await tx.commit();
return resolvedPromises;
} catch (e) {
if (tx) await tx.rollback();
throw e;

12
modules/item/back/methods/tag/specs/onSubmit.spec.js
View File

@ -12,9 +12,8 @@ describe('tag onSubmit()', () => {
deletes: deletes
}
};
const result = await models.Tag.onSubmit(ctx, options);
await models.Tag.onSubmit(ctx, options);
expect(result.length).toEqual(1);
await tx.rollback();
} catch (e) {
await tx.rollback();
@ -33,9 +32,8 @@ describe('tag onSubmit()', () => {
updates: updates
}
};
const result = await models.Tag.onSubmit(ctx, options);
await models.Tag.onSubmit(ctx, options);
expect(result.length).toEqual(1);
await tx.rollback();
} catch (e) {
await tx.rollback();
@ -62,9 +60,8 @@ describe('tag onSubmit()', () => {
creates: creates
}
};
const result = await models.Tag.onSubmit(ctx, options);
await models.Tag.onSubmit(ctx, options);
expect(result.length).toEqual(1);
await tx.rollback();
} catch (e) {
await tx.rollback();
@ -88,9 +85,8 @@ describe('tag onSubmit()', () => {
}
};
const result = await models.Tag.onSubmit(ctx, options);
await models.Tag.onSubmit(ctx, options);
expect(result.length).toEqual(4);
await tx.rollback();
} catch (e) {
await tx.rollback();