verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

5918-worker.time-control_resend #1685

Merged
alexm merged 14 commits from 5918-worker.time-control_resend into dev 2023-10-18 09:10:19 +00:00
Conversation 0 Commits 14 Files Changed 6 +186 -55
vicent commented 2023-07-21 10:59:17 +00:00
Contributor
Copy Link
No description provided.
vicent added the
Missing tests
 label 2023-07-21 10:59:17 +00:00
vicent added 1 commit 2023-07-21 10:59:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8267daef3a refs #5918 fix: permite reenviar el correo si ha dado fallo
vicent changed title from refs #5918 fix: permite reenviar el correo si ha dado fallo to 5918-worker.time-control_resend 2023-07-28 10:29:41 +00:00
jgallego requested changes 2023-08-23 09:10:33 +00:00
modules/worker/front/time-control/index.js Outdated
@ -114,0 +117,4 @@
where: {
year: this._date.getFullYear(),
week: this.getWeekNumber(this._date)
}
jgallego commented 2023-08-23 09:09:58 +00:00
Owner
Copy Link

enviar el workerFk

enviar el workerFk
vicent commented 2023-08-24 07:05:44 +00:00
Author
Contributor
Copy Link

No se envía el workerFk, pq puede que ese workerFk no tenga ningún registro. Se ha solucionado poniendo un limit 1 en la petición.

No se envía el workerFk, pq puede que ese workerFk no tenga ningún registro. Se ha solucionado poniendo un limit 1 en la petición.
vicent marked this conversation as resolved
vicent added 1 commit 2023-08-24 05:57:59 +00:00
vicent added 1 commit 2023-08-24 07:09:04 +00:00
vicent requested review from jgallego 2023-08-24 07:09:10 +00:00
jgallego requested changes 2023-08-24 12:34:00 +00:00
modules/worker/front/time-control/index.js Outdated
@ -114,0 +116,4 @@
const filter = {
where: {
year: this._date.getFullYear(),
week: this.getWeekNumber(this._date)
jgallego commented 2023-08-24 12:33:16 +00:00
Owner
Copy Link

ací al final no pugueres posar el workerFk?

ací al final no pugueres posar el workerFk?
vicent commented 2023-08-24 12:35:30 +00:00
Author
Contributor
Copy Link

Teu havia possat en la nota de ahir:

No se envía el workerFk, pq puede que ese workerFk no tenga ningún registro. Se ha solucionado poniendo un limit 1 en la petición.

Just lo que soluciona esta tarea es poder enviar el registro horario aunq no se li haja enviat la ninguna volta.

Teu havia possat en la nota de ahir: No se envía el workerFk, pq puede que ese workerFk no tenga ningún registro. Se ha solucionado poniendo un limit 1 en la petición. Just lo que soluciona esta tarea es poder enviar el registro horario aunq no se li haja enviat la ninguna volta.
vicent marked this conversation as resolved
vicent added 1 commit 2023-08-25 08:04:35 +00:00
vicent requested review from jgallego 2023-08-25 08:04:50 +00:00
vicent added 1 commit 2023-08-25 08:04:51 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c4cf5f3a4f Merge branch 'dev' into 5918-worker.time-control_resend
jgallego approved these changes 2023-08-25 09:39:43 +00:00
Dismissed
vicent added 1 commit 2023-08-25 11:33:05 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
00b1746fd8 Merge branch 'dev' into 5918-worker.time-control_resend
alexm added 1 commit 2023-09-27 05:05:45 +00:00
alexm added 1 commit 2023-10-03 09:39:51 +00:00
alexm dismissed jgallego’s review 2023-10-03 09:39:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm added 1 commit 2023-10-03 12:03:59 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
45e41de9a9 refs #5918 fix(worker_time-control): isMailSended
alexm added 1 commit 2023-10-04 10:17:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
df6d10e514 refs #5918 fix(workerTimeControl): resend mail
alexm added 1 commit 2023-10-04 10:32:14 +00:00
alexm added 2 commits 2023-10-18 08:30:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
d1cb2a1d9a refs #5918 test: add updateWorkerTimeControlMail
alexm added
CR / Tests passed
 and removed
Missing tests
 labels 2023-10-18 08:31:00 +00:00
alexm added 1 commit 2023-10-18 08:45:32 +00:00
jgallego approved these changes 2023-10-18 09:09:35 +00:00
alexm merged commit bd6c82d2fd into dev 2023-10-18 09:10:19 +00:00
alexm deleted branch 5918-worker.time-control_resend 2023-10-18 09:10:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1685
No description provided.
Delete Branch "5918-worker.time-control_resend"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?