verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 54 Releases Wiki Activity

refs #6119 microsip link added #1729

Merged
jorgep merged 23 commits from 6119-addMicrosipLink into dev 2023-10-13 11:15:49 +00:00
Conversation 0 Commits 23 Files Changed 14 +16 -30
8 changed files with 16 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9536fdba58 - Show all commits

27
front/core/components/link-phone/index.html
View File

@ -1,13 +1,14 @@
<a
ng-if="$ctrl.phoneNumber"
href="tel:{{$ctrl.phoneNumber}}"
>
<vn-icon
flat
round
icon="phone"
title="MicroSIP"
ng-click="$event.stopPropagation();"
>
</vn-icon>
</a>
<span ng-if="$ctrl.phoneNumber">
{{$ctrl.phoneNumber}}
<a href="tel:{{$ctrl.phoneNumber}}">
<vn-icon
flat
round
icon="phone"
title="MicroSIP"
ng-click="$event.stopPropagation();"
>
</vn-icon>
</a>
</span>
<span ng-if="!$ctrl.phoneNumber">-</span>

4
front/core/components/link-phone/index.js
View File

@ -3,8 +3,6 @@ import './style.scss';
class Controller {
constructor() {
this.phoneNumber = null;
this.icon = true;
this.showNumber = true;
}
}
@ -13,7 +11,5 @@ ngModule.vnComponent('vnLinkPhone', {
controller: Controller,
bindings: {
phoneNumber: '<',
icon: '<?',
showNumber: '<?',
}
});

4
modules/client/front/summary/index.html
View File

@ -46,14 +46,14 @@
value="{{$ctrl.summary.contact}}">
</vn-label-value>
<vn-label-value label="Phone">
{{$ctrl.summary.phone | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.phone"
></vn-link-phone>
jorgep marked this conversation as resolved
juan commented 2023-09-11 07:03:10 +00:00
Review
Copy Link

Porqué se repite dos veces el valor del teléfono? Cual es la funcion del componente vnLinkPhone?

Porqué se repite dos veces el valor del teléfono? Cual es la funcion del componente vnLinkPhone?
jorgep commented 2023-09-18 06:12:01 +00:00
Review
Copy Link

Antes quería mostrar el número y un icono, pero , ahora solo se mostrará el icono del teléfono.

Antes quería mostrar el número y un icono, pero , ahora solo se mostrará el icono del teléfono.
</vn-label-value>
<vn-label-value label="Mobile">
{{$ctrl.summary.mobile | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.mobile"
></vn-link-phone>

1
modules/order/front/summary/index.html
View File

@ -49,7 +49,6 @@
value="{{$ctrl.summary.landed | date: 'dd/MM/yyyy HH:mm'}}">
</vn-label-value>
<vn-label-value label="Phone">
{{$ctrl.summary.address.phone | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.address.phone"
></vn-link-phone>

1
modules/route/front/roadmap/summary/index.html
View File

@ -26,7 +26,6 @@
<vn-label-value
label="Phone"
>
{{summary.phone | dashIfEmpty}}
<vn-link-phone
phone-number="summary.phone"
></vn-link-phone>

4
modules/ticket/front/summary/index.html
View File

@ -84,7 +84,6 @@
<vn-label-value label="Address phone"
ng-if="$ctrl.summary.address.phone != null"
>
{{$ctrl.summary.address.phone | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.address.phone"
></vn-link-phone>
@ -92,21 +91,18 @@
<vn-label-value label="Address mobile"
ng-if="$ctrl.summary.address.mobile != null"
>
{{$ctrl.summary.address.mobile | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.address.mobile"
></vn-link-phone>
</vn-label-value>
<vn-label-value label="Client phone"
ng-if="$ctrl.summary.client.phone != null">
{{$ctrl.summary.client.phone | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.client.phone"
></vn-link-phone>
</vn-label-value>
<vn-label-value label="Client mobile"
ng-if="$ctrl.summary.client.mobile != null">
{{$ctrl.summary.client.mobile | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.summary.client.mobile"
></vn-link-phone>

2
modules/worker/front/descriptor/index.html
View File

@ -38,7 +38,6 @@
<vn-label-value
label="Phone"
>
{{$ctrl.worker.phone | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.worker.phone"
></vn-link-phone>
@ -46,7 +45,6 @@
<vn-label-value
label="Extension"
>
{{$ctrl.worker.sip.extension | dashIfEmpty}}
<vn-link-phone
phone-number="$ctrl.worker.sip.extension"
></vn-link-phone>

3
modules/worker/front/summary/index.html
View File

@ -43,20 +43,17 @@
</span>
</vn-label-value>
<vn-label-value label="Mobile extension">
{{worker.mobileExtension | dashIfEmpty}}
<vn-link-phone
phone-number="worker.mobileExtension"
></vn-link-phone>
</vn-label-value>
<vn-label-value label="Business phone">
{{worker.phone | dashIfEmpty}}
<vn-link-phone
phone-number="worker.phone"
></vn-link-phone>
</vn-label-value>
<vn-label-value label="Personal phone"
>
{{worker.client.phone | dashIfEmpty}}
<vn-link-phone
phone-number="worker.client.phone"
></vn-link-phone>