verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6184 saveCmr #1788

Merged
guillermo merged 58 commits from 6184-saveCmr into dev 2024-02-13 06:47:06 +00:00
Conversation 2 Commits 58 Files Changed 27 +20 -24
2 changed files with 20 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 25fa154f60 - Show all commits

14
modules/route/back/methods/route/cmrEmail.js
View File

@ -70,21 +70,17 @@ module.exports = Self => {
};
const dms = await models.TicketDms.findOne({
where: {
ticketFk: ticketId
},
include: [
{
where: {ticketFk: ticketId},
include: [{
guillermo marked this conversation as resolved Outdated
alexm commented 2024-01-30 07:53:05 +00:00
Outdated
Review
Copy Link

Si solo se usa una vez params se puede poner directamente el objeto o si se quiere variable poner inmediatamente arriba asi facilita la lectura

Si solo se usa una vez params se puede poner directamente el objeto o si se quiere variable poner inmediatamente arriba asi facilita la lectura
relation: 'dms',
fields: ['id'],
scope: {
relation: 'dmsType',
where: {
code: 'cmr'
scope: {
where: {code: 'cmr'}
}
}
}
]
}]
}, myOptions);
if (!dms) throw new UserError('Cmr file does not exist');

20
modules/ticket/back/methods/ticket/saveSign.js
View File

@ -59,18 +59,18 @@ module.exports = Self => {
async function hasSignDms(ticketId) {
const ticketDms = await models.TicketDms.findOne({
where: {
ticketFk: ticketId
},
fields: ['dmsFk'],
include: [{
where: {ticketFk: ticketId},
include: [
{
relation: 'dms',
fields: ['id'],
scope: {
where: {dmsType: dmsTypeTicket.id}
where: {dmsTypeFk: dmsTypeTicket.id}
}
}]
}
]
}, myOptions);
if (ticketDms.dms().id) return true;
if (ticketDms.dms()?.id) return true;
}
async function createGestDoc(id) {
@ -133,9 +133,9 @@ module.exports = Self => {
if (await ticket.isSigned)
throw new UserError('Ticket is already signed');
if (location) setLocation(ticketId);
if (location) await setLocation(ticketId);
if (!await hasSignDms(ticketId))
createGestDoc(ticketId);
await createGestDoc(ticketId);
await ticket.updateAttribute('isSigned', true, myOptions);
const deliveryState = await models.State.findOne({