verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #6184 saveCmr #1788

Merged
guillermo merged 58 commits from 6184-saveCmr into dev 2024-02-13 06:47:06 +00:00
Conversation 2 Commits 58 Files Changed 27 +8 -7
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c0089b1fa0 - Show all commits

12
modules/ticket/back/methods/ticket/saveCmr.js
View File

@ -1,8 +1,6 @@
const UserError = require('vn-loopback/util/user-error');
module.exports = Self => {
Self.remoteMethodCtx('saveCmr', {
description: 'Save sign',
description: 'Save cmr',
accessType: 'WRITE',
accepts:
[
@ -34,10 +32,10 @@ module.exports = Self => {
try {
for (const ticketId of tickets) {
const cmrFk = await models.Ticket.findOne(
{where: {id: ticketId},
fields: ['cmrFk']
}, myOptions);
const cmrFk = await models.Ticket.findOne({
where: {id: ticketId},
fields: ['cmrFk']
}, myOptions);
guillermo marked this conversation as resolved Outdated
jgallego commented 2023-11-13 06:17:25 +00:00
Outdated
Review
Copy Link

Este el cree cada vegada pero es el mateix id per a tots. Pujal fora del for
El nom jo posaría dmsTypeCmr

Este el cree cada vegada pero es el mateix id per a tots. Pujal fora del for El nom jo posaría dmsTypeCmr
if (cmrFk) {
const dmsTypeCmr = await models.DmsType.findOne({

3
modules/ticket/back/models/ticket.json
View File

@ -63,6 +63,9 @@
},
"weight": {
"type": "number"
},
guillermo marked this conversation as resolved Outdated
jgallego commented 2023-11-13 06:33:04 +00:00
Outdated
Review
Copy Link

si el poses baix, ací dalt no cal. A no ser que vullgueres posar alguna propietat mes del tipo required..que no es el cas

si el poses baix, ací dalt no cal. A no ser que vullgueres posar alguna propietat mes del tipo required..que no es el cas
guillermo commented 2023-11-13 07:30:51 +00:00
Outdated
Review
Copy Link

Lo he tenido que poner ya que si no no me detecta ese campo.

Lo he tenido que poner ya que si no no me detecta ese campo.
"cmrFk": {
"type": "number"
}
},
"relations": {