From 3c58f86c2a3a30879b8c9ea6a6a41c24c6f6891b Mon Sep 17 00:00:00 2001 From: carlossa Date: Tue, 10 Oct 2023 13:44:22 +0200 Subject: [PATCH 01/26] refs #5919 locker back y front --- modules/worker/back/model-config.json | 3 +++ modules/worker/back/models/locker.json | 28 ++++++++++++++++++++++ modules/worker/front/basic-data/index.html | 7 +++--- modules/worker/front/basic-data/index.js | 5 ++++ 4 files changed, 39 insertions(+), 4 deletions(-) create mode 100644 modules/worker/back/models/locker.json diff --git a/modules/worker/back/model-config.json b/modules/worker/back/model-config.json index 8352eb0706..fe2b24c066 100644 --- a/modules/worker/back/model-config.json +++ b/modules/worker/back/model-config.json @@ -115,6 +115,9 @@ }, "Operator": { "dataSource": "vn" + }, + "locker": { + "dataSource": "vn" } } diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json new file mode 100644 index 0000000000..0e8f9d5439 --- /dev/null +++ b/modules/worker/back/models/locker.json @@ -0,0 +1,28 @@ +{ + "name": "locker", + "description": "Employee´s locker", + "base": "Loggable", + "options": { + "mysql": { + "table": "locker" + } + }, + "properties": { + "code": { + "type": "string" + }, + "gender": { + "type": "string" + }, + "workerFk": { + "type": "number" + } + }, + "relations": { + "id": { + "type": "belongsTo", + "model": "worker", + "foreignKey": "workerFk" + } + } +} diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index 2d85d018de..73b066739b 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -75,11 +75,10 @@ ng-model="$ctrl.worker.SSN" rule> - - + ng-model="$ctrl.worker.locker"> + diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index ea75d7b973..faea9804f0 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -13,6 +13,11 @@ class Controller extends Section { return this.$.watcher.submit() .then(() => this.card.reload()); } + + chooseLocker() { + const workerGender = this.worker.sex; + console.log(workerGender); + } } ngModule.vnComponent('vnWorkerBasicData', { -- 2.40.1 From c061841cacb9f88fd99c8b230c27ae3f18697b56 Mon Sep 17 00:00:00 2001 From: carlossa Date: Tue, 10 Oct 2023 13:58:33 +0200 Subject: [PATCH 02/26] refs #5919 locker and back --- .../back/methods/worker/chooseLocker.js | 32 +++++++++++++++++++ modules/worker/back/models/locker.js | 7 ++++ 2 files changed, 39 insertions(+) create mode 100644 modules/worker/back/methods/worker/chooseLocker.js create mode 100644 modules/worker/back/models/locker.js diff --git a/modules/worker/back/methods/worker/chooseLocker.js b/modules/worker/back/methods/worker/chooseLocker.js new file mode 100644 index 0000000000..b3b7678cad --- /dev/null +++ b/modules/worker/back/methods/worker/chooseLocker.js @@ -0,0 +1,32 @@ + +module.exports = Self => { + Self.remoteMethod('chooseLocker', { + description: 'Returns an unoccupied locker for the employee', + accessType: 'WRITE', + accepts: [{ + arg: 'filter', + type: 'Object', + description: 'Filter defining where and paginated data', + required: true + }], + returns: { + type: ['object'], + root: true + }, + http: { + path: `/chooseLocker`, + verb: 'GET' + } + }); + + Self.chooseLocker = async filter => { + const query = + `SELECT l.code AS locker_code + FROM worker w + JOIN locker l ON w.sex = l.gender + WHERE w.id = ? AND l.workerFk IS NULL; + `[this.worker.id]; + + return Self.chooseLocker(query, filter); + }; +}; diff --git a/modules/worker/back/models/locker.js b/modules/worker/back/models/locker.js new file mode 100644 index 0000000000..25b33f517f --- /dev/null +++ b/modules/worker/back/models/locker.js @@ -0,0 +1,7 @@ +module.exports = Self => { + require('../methods/worker/chooseLocker')(Self); + + Self.validatesUniquenessOf('locker', { + message: 'This locker has already been assigned' + }); +}; -- 2.40.1 From 38bf90da66157114bdc2217fb8429c6cc9f8f27c Mon Sep 17 00:00:00 2001 From: carlossa Date: Wed, 11 Oct 2023 13:26:27 +0200 Subject: [PATCH 03/26] refs #5919 sql --- db/changes/234201/00-locker.sql | 19 +++++++++++++++++++ modules/worker/front/basic-data/index.html | 5 +++-- 2 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 db/changes/234201/00-locker.sql diff --git a/db/changes/234201/00-locker.sql b/db/changes/234201/00-locker.sql new file mode 100644 index 0000000000..6e9eca307b --- /dev/null +++ b/db/changes/234201/00-locker.sql @@ -0,0 +1,19 @@ +CREATE TABLE `vn`.`locker` ( + `code` varchar(10) NOT NULL, + `gender` varchar(255) DEFAULT NULL, + `workerFk` int(10) unsigned DEFAULT NULL, + PRIMARY KEY (`code`), + UNIQUE KEY `code` (`code`), + KEY `workerFk` (`workerFk`), + CONSTRAINT `locker_ibfk_1` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci; + +-- Insertar taquillas disponibles para mujeres (1A - 73A / 1B - 73B) +INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES + ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), ('6A', 'M', NULL), ('7A', 'M', NULL), + ('1B', 'M', NULL), ('2B', 'M', NULL), ('3B', 'M', NULL), ('4B', 'M', NULL), ('5B', 'M', NULL), ('6B', 'M', NULL), ('7B', 'M', NULL); + +-- Insertar taquillas disponibles para mujeres (200A - 217A / 200B - 217B) +INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES + ('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), ('205A', 'F', NULL), ('206A', 'F', NULL), + ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), ('205B', 'F', NULL), ('206B', 'F', NULL); diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index 73b066739b..f9a73de6fd 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -77,8 +77,9 @@ - + ng-model="$ctrl.worker.locker" + data="chooseLocker"> + -- 2.40.1 From 5a375ebfda6086b0d91ee77c0f3718cb5a415ded Mon Sep 17 00:00:00 2001 From: carlossa Date: Mon, 16 Oct 2023 13:22:36 +0200 Subject: [PATCH 04/26] refs #5919 front back --- modules/worker/front/basic-data/index.html | 2 +- modules/worker/front/basic-data/index.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index f9a73de6fd..d832b27e5f 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -77,7 +77,7 @@ diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index faea9804f0..82ed2e6bf4 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -15,8 +15,7 @@ class Controller extends Section { } chooseLocker() { - const workerGender = this.worker.sex; - console.log(workerGender); + // } } -- 2.40.1 From fd64cb7e80375c7d2bf63e92c783bfa1535f2cd5 Mon Sep 17 00:00:00 2001 From: carlossa Date: Tue, 17 Oct 2023 13:08:00 +0200 Subject: [PATCH 05/26] refs #5919 front back --- db/changes/234201/00-locker.sql | 6 +++++- modules/worker/back/methods/worker/chooseLocker.js | 8 ++++---- modules/worker/back/models/locker.json | 7 ++----- modules/worker/back/models/worker.json | 3 --- modules/worker/front/basic-data/index.html | 6 +++--- modules/worker/front/summary/index.html | 2 +- modules/worker/front/summary/index.js | 2 +- 7 files changed, 16 insertions(+), 18 deletions(-) diff --git a/db/changes/234201/00-locker.sql b/db/changes/234201/00-locker.sql index 6e9eca307b..c925cb1af7 100644 --- a/db/changes/234201/00-locker.sql +++ b/db/changes/234201/00-locker.sql @@ -1,5 +1,5 @@ CREATE TABLE `vn`.`locker` ( - `code` varchar(10) NOT NULL, + `code` varchar(10) DEFAULT NULL, `gender` varchar(255) DEFAULT NULL, `workerFk` int(10) unsigned DEFAULT NULL, PRIMARY KEY (`code`), @@ -17,3 +17,7 @@ INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES ('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), ('205A', 'F', NULL), ('206A', 'F', NULL), ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), ('205B', 'F', NULL), ('206B', 'F', NULL); + + +-- Eliminar locker +ALTER TABLE `vn`.`worker` DROP COLUMN `locker`; diff --git a/modules/worker/back/methods/worker/chooseLocker.js b/modules/worker/back/methods/worker/chooseLocker.js index b3b7678cad..dc7775d08e 100644 --- a/modules/worker/back/methods/worker/chooseLocker.js +++ b/modules/worker/back/methods/worker/chooseLocker.js @@ -21,10 +21,10 @@ module.exports = Self => { Self.chooseLocker = async filter => { const query = - `SELECT l.code AS locker_code - FROM worker w - JOIN locker l ON w.sex = l.gender - WHERE w.id = ? AND l.workerFk IS NULL; + `SELECT l.code + FROM worker w + JOIN locker l ON w.sex = l.gender + WHERE w.id = ? AND l.workerFk IS NULL; `[this.worker.id]; return Self.chooseLocker(query, filter); diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json index 0e8f9d5439..0e72784b3d 100644 --- a/modules/worker/back/models/locker.json +++ b/modules/worker/back/models/locker.json @@ -1,6 +1,6 @@ { "name": "locker", - "description": "Employee´s locker", + "description": "Employee's locker", "base": "Loggable", "options": { "mysql": { @@ -13,13 +13,10 @@ }, "gender": { "type": "string" - }, - "workerFk": { - "type": "number" } }, "relations": { - "id": { + "worker": { "type": "belongsTo", "model": "worker", "foreignKey": "workerFk" diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index dbb3ed23f9..bea86d14d4 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -44,9 +44,6 @@ }, "code": { "type" : "string" - }, - "locker": { - "type" : "number" } }, "relations": { diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index d832b27e5f..b15c6c669d 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -77,9 +77,9 @@ - + url="Lockers" + data="$ctrl.locker.code"> + diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index 6604ef6ca8..0f34f4df84 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -52,7 +52,7 @@ value="{{worker.client.phone}}"> + value="{{::locker.code}}"> diff --git a/modules/worker/front/summary/index.js b/modules/worker/front/summary/index.js index 2bb1f08530..f1e4b8b599 100644 --- a/modules/worker/front/summary/index.js +++ b/modules/worker/front/summary/index.js @@ -52,7 +52,7 @@ class Controller extends Summary { scope: {fields: ['id', 'code', 'name']} } } - } + }, ] }; -- 2.40.1 From f35b2a4905baf3d0bd34a64cfc3c2c265d33adf3 Mon Sep 17 00:00:00 2001 From: carlossa Date: Tue, 26 Dec 2023 13:44:52 +0100 Subject: [PATCH 06/26] refs #5919 back chooseLocker --- db/changes/{234201 => 240201}/00-locker.sql | 14 ++++++-- .../back/methods/worker/chooseLocker.js | 32 ------------------- modules/worker/back/model-config.json | 2 +- modules/worker/back/models/locker.js | 7 ---- modules/worker/back/models/locker.json | 4 +-- modules/worker/back/models/worker.json | 5 +++ modules/worker/front/basic-data/index.html | 2 +- modules/worker/front/basic-data/index.js | 10 ++++-- modules/worker/front/summary/index.html | 2 +- modules/worker/front/summary/index.js | 4 +++ 10 files changed, 34 insertions(+), 48 deletions(-) rename db/changes/{234201 => 240201}/00-locker.sql (83%) delete mode 100644 modules/worker/back/methods/worker/chooseLocker.js delete mode 100644 modules/worker/back/models/locker.js diff --git a/db/changes/234201/00-locker.sql b/db/changes/240201/00-locker.sql similarity index 83% rename from db/changes/234201/00-locker.sql rename to db/changes/240201/00-locker.sql index c925cb1af7..20ab6ed16a 100644 --- a/db/changes/234201/00-locker.sql +++ b/db/changes/240201/00-locker.sql @@ -1,3 +1,6 @@ +ALTER TABLE vn.worker MODIFY COLUMN locker varchar(10) DEFAULT NULL NULL; + + CREATE TABLE `vn`.`locker` ( `code` varchar(10) DEFAULT NULL, `gender` varchar(255) DEFAULT NULL, @@ -8,6 +11,14 @@ CREATE TABLE `vn`.`locker` ( CONSTRAINT `locker_ibfk_1` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci; +ALTER TABLE `vn`.`worker` +ADD CONSTRAINT `worker_locker_fk` +FOREIGN KEY (`locker`) +REFERENCES `vn`.`locker` (`code`) +ON UPDATE CASCADE +ON DELETE SET NULL; + + -- Insertar taquillas disponibles para mujeres (1A - 73A / 1B - 73B) INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), ('6A', 'M', NULL), ('7A', 'M', NULL), @@ -19,5 +30,4 @@ INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), ('205B', 'F', NULL), ('206B', 'F', NULL); --- Eliminar locker -ALTER TABLE `vn`.`worker` DROP COLUMN `locker`; + diff --git a/modules/worker/back/methods/worker/chooseLocker.js b/modules/worker/back/methods/worker/chooseLocker.js deleted file mode 100644 index dc7775d08e..0000000000 --- a/modules/worker/back/methods/worker/chooseLocker.js +++ /dev/null @@ -1,32 +0,0 @@ - -module.exports = Self => { - Self.remoteMethod('chooseLocker', { - description: 'Returns an unoccupied locker for the employee', - accessType: 'WRITE', - accepts: [{ - arg: 'filter', - type: 'Object', - description: 'Filter defining where and paginated data', - required: true - }], - returns: { - type: ['object'], - root: true - }, - http: { - path: `/chooseLocker`, - verb: 'GET' - } - }); - - Self.chooseLocker = async filter => { - const query = - `SELECT l.code - FROM worker w - JOIN locker l ON w.sex = l.gender - WHERE w.id = ? AND l.workerFk IS NULL; - `[this.worker.id]; - - return Self.chooseLocker(query, filter); - }; -}; diff --git a/modules/worker/back/model-config.json b/modules/worker/back/model-config.json index fe2b24c066..8be67a10d4 100644 --- a/modules/worker/back/model-config.json +++ b/modules/worker/back/model-config.json @@ -116,7 +116,7 @@ "Operator": { "dataSource": "vn" }, - "locker": { + "Locker": { "dataSource": "vn" } } diff --git a/modules/worker/back/models/locker.js b/modules/worker/back/models/locker.js deleted file mode 100644 index 25b33f517f..0000000000 --- a/modules/worker/back/models/locker.js +++ /dev/null @@ -1,7 +0,0 @@ -module.exports = Self => { - require('../methods/worker/chooseLocker')(Self); - - Self.validatesUniquenessOf('locker', { - message: 'This locker has already been assigned' - }); -}; diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json index 0e72784b3d..9601ca129b 100644 --- a/modules/worker/back/models/locker.json +++ b/modules/worker/back/models/locker.json @@ -1,7 +1,7 @@ { - "name": "locker", + "name": "Locker", "description": "Employee's locker", - "base": "Loggable", + "base": "VnModel", "options": { "mysql": { "table": "locker" diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index 1a777fffeb..b045f14655 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -88,6 +88,11 @@ "type": "hasMany", "model": "WorkerTeamCollegues", "foreignKey": "workerFk" + }, + "locker": { + "type": "belongsTo", + "model": "Locker", + "foreignKey": "code" } } } diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index b15c6c669d..a3f122a493 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -78,7 +78,7 @@ + ng-model="$ctrl.locker.code"> diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index 82ed2e6bf4..bf162f49b3 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -13,9 +13,15 @@ class Controller extends Section { return this.$.watcher.submit() .then(() => this.card.reload()); } + async chooseLocker() { + const locker = + `SELECT l.code + FROM worker w + JOIN locker l ON w.sex = l.gender + WHERE w.id = ? AND l.workerFk IS NULL; + `[this.code]; - chooseLocker() { - // + return locker; } } diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index ff464aa79c..ba96d25a61 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -59,7 +59,7 @@ > + value="{{worker.locker.code}}"> diff --git a/modules/worker/front/summary/index.js b/modules/worker/front/summary/index.js index 0e7f46c7c6..a7387a1256 100644 --- a/modules/worker/front/summary/index.js +++ b/modules/worker/front/summary/index.js @@ -52,6 +52,10 @@ class Controller extends Summary { } } }, + { + relation: 'locker', + scope: {fields: ['code']} + } ] }; -- 2.40.1 From 6ceee45b13f342c10de6b0b26d85c85187ea982f Mon Sep 17 00:00:00 2001 From: carlossa Date: Thu, 28 Dec 2023 16:40:13 +0100 Subject: [PATCH 07/26] refs #5919 fix locker --- db/changes/240201/00-locker.sql | 4 +++- modules/worker/back/methods/worker/filter.js | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/db/changes/240201/00-locker.sql b/db/changes/240201/00-locker.sql index 20ab6ed16a..911c2c4dad 100644 --- a/db/changes/240201/00-locker.sql +++ b/db/changes/240201/00-locker.sql @@ -1,7 +1,9 @@ -ALTER TABLE vn.worker MODIFY COLUMN locker varchar(10) DEFAULT NULL NULL; +-- Eliminar locker +ALTER TABLE `vn`.`worker` DROP COLUMN `locker`; CREATE TABLE `vn`.`locker` ( + `id` int(100), `code` varchar(10) DEFAULT NULL, `gender` varchar(255) DEFAULT NULL, `workerFk` int(10) unsigned DEFAULT NULL, diff --git a/modules/worker/back/methods/worker/filter.js b/modules/worker/back/methods/worker/filter.js index 2f328d28fa..6ca4f30439 100644 --- a/modules/worker/back/methods/worker/filter.js +++ b/modules/worker/back/methods/worker/filter.js @@ -117,14 +117,15 @@ module.exports = Self => { stmt = new ParameterizedSQL( `SELECT w.id, u.email, p.extension, u.name as userName, - d.name AS department, w.lastName, u.nickname, mu.email + d.name AS department, w.lastName, u.nickname, mu.email, lc.code FROM worker w LEFT JOIN workerDepartment wd ON wd.workerFk = w.id LEFT JOIN department d ON d.id = wd.departmentFk LEFT JOIN client c ON c.id = w.id LEFT JOIN account.user u ON u.id = w.id LEFT JOIN pbx.sip p ON p.user_id = u.id - LEFT JOIN account.emailUser mu ON mu.userFk = u.id` + LEFT JOIN account.emailUser mu ON mu.userFk = u.id + LEFT JOIN locker lc ON lc.workerFk = w.id` ); stmt.merge(conn.makeSuffix(filter)); -- 2.40.1 From 3a429a31da0f48d9f8757016be824a3ced12172b Mon Sep 17 00:00:00 2001 From: carlossa Date: Fri, 29 Dec 2023 08:44:42 +0100 Subject: [PATCH 08/26] refs #5919 locker --- db/changes/240201/00-locker.sql | 6 +++--- modules/worker/back/models/worker.json | 3 --- modules/worker/front/basic-data/index.js | 18 +++++++++--------- modules/worker/front/summary/index.html | 2 +- modules/worker/front/summary/index.js | 4 ---- 5 files changed, 13 insertions(+), 20 deletions(-) diff --git a/db/changes/240201/00-locker.sql b/db/changes/240201/00-locker.sql index 911c2c4dad..b3ad0dfd4f 100644 --- a/db/changes/240201/00-locker.sql +++ b/db/changes/240201/00-locker.sql @@ -3,7 +3,7 @@ ALTER TABLE `vn`.`worker` DROP COLUMN `locker`; CREATE TABLE `vn`.`locker` ( - `id` int(100), + `id` int(100) auto_increment, `code` varchar(10) DEFAULT NULL, `gender` varchar(255) DEFAULT NULL, `workerFk` int(10) unsigned DEFAULT NULL, @@ -22,12 +22,12 @@ ON DELETE SET NULL; -- Insertar taquillas disponibles para mujeres (1A - 73A / 1B - 73B) -INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES +INSERT INTO `vn`.`locker` (id, code, gender, workerFk) VALUES ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), ('6A', 'M', NULL), ('7A', 'M', NULL), ('1B', 'M', NULL), ('2B', 'M', NULL), ('3B', 'M', NULL), ('4B', 'M', NULL), ('5B', 'M', NULL), ('6B', 'M', NULL), ('7B', 'M', NULL); -- Insertar taquillas disponibles para mujeres (200A - 217A / 200B - 217B) -INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES +INSERT INTO `vn`.`locker` (id, code, gender, workerFk) VALUES ('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), ('205A', 'F', NULL), ('206A', 'F', NULL), ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), ('205B', 'F', NULL), ('206B', 'F', NULL); diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index b045f14655..70c3881cf1 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -45,9 +45,6 @@ "code": { "type" : "string" }, - "locker": { - "type" : "number" - }, "fi": { "type" : "string" }, diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index bf162f49b3..aae9774ec2 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -13,16 +13,16 @@ class Controller extends Section { return this.$.watcher.submit() .then(() => this.card.reload()); } - async chooseLocker() { - const locker = - `SELECT l.code - FROM worker w - JOIN locker l ON w.sex = l.gender - WHERE w.id = ? AND l.workerFk IS NULL; - `[this.code]; + // async chooseLocker() { + // const locker = + // `SELECT l.code + // FROM worker w + // JOIN locker l ON w.sex = l.gender + // WHERE w.id = ? AND l.workerFk IS NULL; + // `[this.id]; - return locker; - } + // return locker; + // } } ngModule.vnComponent('vnWorkerBasicData', { diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index ba96d25a61..5d2b018dd4 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -59,7 +59,7 @@ > + > diff --git a/modules/worker/front/summary/index.js b/modules/worker/front/summary/index.js index a7387a1256..212609f582 100644 --- a/modules/worker/front/summary/index.js +++ b/modules/worker/front/summary/index.js @@ -51,10 +51,6 @@ class Controller extends Summary { scope: {fields: ['id', 'code', 'name']} } } - }, - { - relation: 'locker', - scope: {fields: ['code']} } ] }; -- 2.40.1 From e2eebf96f7ee9891519474f28482b91e07c11fcc Mon Sep 17 00:00:00 2001 From: carlossa Date: Fri, 29 Dec 2023 11:29:48 +0100 Subject: [PATCH 09/26] refs #5919 locker insert prod --- db/changes/240201/00-locker.sql | 57 ++++++++++++++++++++++++--------- 1 file changed, 42 insertions(+), 15 deletions(-) diff --git a/db/changes/240201/00-locker.sql b/db/changes/240201/00-locker.sql index b3ad0dfd4f..714ec7aff9 100644 --- a/db/changes/240201/00-locker.sql +++ b/db/changes/240201/00-locker.sql @@ -7,29 +7,56 @@ CREATE TABLE `vn`.`locker` ( `code` varchar(10) DEFAULT NULL, `gender` varchar(255) DEFAULT NULL, `workerFk` int(10) unsigned DEFAULT NULL, - PRIMARY KEY (`code`), + PRIMARY KEY (`id`), UNIQUE KEY `code` (`code`), KEY `workerFk` (`workerFk`), CONSTRAINT `locker_ibfk_1` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci; -ALTER TABLE `vn`.`worker` -ADD CONSTRAINT `worker_locker_fk` -FOREIGN KEY (`locker`) -REFERENCES `vn`.`locker` (`code`) -ON UPDATE CASCADE -ON DELETE SET NULL; - --- Insertar taquillas disponibles para mujeres (1A - 73A / 1B - 73B) -INSERT INTO `vn`.`locker` (id, code, gender, workerFk) VALUES - ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), ('6A', 'M', NULL), ('7A', 'M', NULL), - ('1B', 'M', NULL), ('2B', 'M', NULL), ('3B', 'M', NULL), ('4B', 'M', NULL), ('5B', 'M', NULL), ('6B', 'M', NULL), ('7B', 'M', NULL); +-- Insertar taquillas disponibles para hombres (1A - 73A / 1B - 73B) +INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES + ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), + ('6A', 'M', NULL), ('7A', 'M', NULL), ('8A', 'M', NULL), ('9A', 'M', NULL), ('10A', 'M', NULL), + ('11A', 'M', NULL), ('12A', 'M', NULL), ('13A', 'M', NULL), ('14A', 'M', NULL), ('15A', 'M', NULL), + ('16A', 'M', NULL), ('17A', 'M', NULL), ('18A', 'M', NULL), ('19A', 'M', NULL), ('20A', 'M', NULL), + ('21A', 'M', NULL), ('22A', 'M', NULL), ('23A', 'M', NULL), ('24A', 'M', NULL), ('25A', 'M', NULL), + ('26A', 'M', NULL), ('27A', 'M', NULL), ('28A', 'M', NULL), ('29A', 'M', NULL), ('30A', 'M', NULL), + ('31A', 'M', NULL), ('32A', 'M', NULL), ('33A', 'M', NULL), ('34A', 'M', NULL), ('35A', 'M', NULL), + ('36A', 'M', NULL), ('37A', 'M', NULL), ('38A', 'M', NULL), ('39A', 'M', NULL), ('40A', 'M', NULL), + ('41A', 'M', NULL), ('42A', 'M', NULL), ('43A', 'M', NULL), ('44A', 'M', NULL), ('45A', 'M', NULL), + ('46A', 'M', NULL), ('47A', 'M', NULL), ('48A', 'M', NULL), ('49A', 'M', NULL), ('50A', 'M', NULL), + ('51A', 'M', NULL), ('52A', 'M', NULL), ('53A', 'M', NULL), ('54A', 'M', NULL), ('55A', 'M', NULL), + ('56A', 'M', NULL), ('57A', 'M', NULL), ('58A', 'M', NULL), ('59A', 'M', NULL), ('60A', 'M', NULL), + ('61A', 'M', NULL), ('62A', 'M', NULL), ('63A', 'M', NULL), ('64A', 'M', NULL), ('65A', 'M', NULL), + ('66A', 'M', NULL), ('67A', 'M', NULL), ('68A', 'M', NULL), ('69A', 'M', NULL), ('70A', 'M', NULL), + ('71A', 'M', NULL), ('72A', 'M', NULL), ('73A', 'M', NULL), + ('1B', 'M', NULL), ('2B', 'M', NULL), ('3B', 'M', NULL), ('4B', 'M', NULL), ('5B', 'M', NULL), + ('6B', 'M', NULL), ('7B', 'M', NULL), ('8B', 'M', NULL), ('9B', 'M', NULL), ('10B', 'M', NULL), + ('11B', 'M', NULL), ('12B', 'M', NULL), ('13B', 'M', NULL), ('14B', 'M', NULL), ('15B', 'M', NULL), + ('16B', 'M', NULL), ('17B', 'M', NULL), ('18B', 'M', NULL), ('19B', 'M', NULL), ('20B', 'M', NULL), + ('21B', 'M', NULL), ('22B', 'M', NULL), ('23B', 'M', NULL), ('24B', 'M', NULL), ('25B', 'M', NULL), + ('26B', 'M', NULL), ('27B', 'M', NULL), ('28B', 'M', NULL), ('29B', 'M', NULL), ('30B', 'M', NULL), + ('31B', 'M', NULL), ('32B', 'M', NULL), ('33B', 'M', NULL), ('34B', 'M', NULL), ('35B', 'M', NULL), + ('36B', 'M', NULL), ('37B', 'M', NULL), ('38B', 'M', NULL), ('39B', 'M', NULL), ('40B', 'M', NULL), + ('41B', 'M', NULL), ('42B', 'M', NULL), ('43B', 'M', NULL), ('44B', 'M', NULL), ('45B', 'M', NULL), + ('46B', 'M', NULL), ('47B', 'M', NULL), ('48B', 'M', NULL), ('49B', 'M', NULL), ('50B', 'M', NULL), + ('51B', 'M', NULL), ('52B', 'M', NULL), ('53B', 'M', NULL), ('54B', 'M', NULL), ('55B', 'M', NULL), + ('56B', 'M', NULL), ('57B', 'M', NULL), ('58B', 'M', NULL), ('59B', 'M', NULL), ('60B', 'M', NULL), + ('61B', 'M', NULL), ('62B', 'M', NULL), ('63B', 'M', NULL), ('64B', 'M', NULL), ('65B', 'M', NULL), + ('66B', 'M', NULL), ('67B', 'M', NULL), ('68B', 'M', NULL), ('69B', 'M', NULL), ('70B', 'M', NULL), + ('71B', 'M', NULL), ('72B', 'M', NULL), ('73B', 'M', NULL); -- Insertar taquillas disponibles para mujeres (200A - 217A / 200B - 217B) -INSERT INTO `vn`.`locker` (id, code, gender, workerFk) VALUES - ('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), ('205A', 'F', NULL), ('206A', 'F', NULL), - ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), ('205B', 'F', NULL), ('206B', 'F', NULL); +INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES + ('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), + ('205A', 'F', NULL), ('206A', 'F', NULL), ('207A', 'F', NULL), ('208A', 'F', NULL), ('209A', 'F', NULL), + ('210A', 'F', NULL), ('211A', 'F', NULL), ('212A', 'F', NULL), ('213A', 'F', NULL), ('214A', 'F', NULL), + ('215A', 'F', NULL), ('216A', 'F', NULL), ('217A', 'F', NULL), + ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), + ('205B', 'F', NULL), ('206B', 'F', NULL), ('207B', 'F', NULL), ('208B', 'F', NULL), ('209B', 'F', NULL), + ('210B', 'F', NULL), ('211B', 'F', NULL), ('212B', 'F', NULL), ('213B', 'F', NULL), ('214B', 'F', NULL), + ('215B', 'F', NULL), ('216B', 'F', NULL), ('217B', 'F', NULL); -- 2.40.1 From 69739fca9c1866ebe34d4eb97e49ae2c5f145e5f Mon Sep 17 00:00:00 2001 From: carlossa Date: Wed, 3 Jan 2024 08:17:37 +0100 Subject: [PATCH 10/26] refs #5919 locker relation --- modules/worker/front/summary/index.html | 1 + modules/worker/front/summary/index.js | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index 5d2b018dd4..5e743efa35 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -59,6 +59,7 @@ > diff --git a/modules/worker/front/summary/index.js b/modules/worker/front/summary/index.js index 212609f582..647e47e643 100644 --- a/modules/worker/front/summary/index.js +++ b/modules/worker/front/summary/index.js @@ -51,7 +51,18 @@ class Controller extends Summary { scope: {fields: ['id', 'code', 'name']} } } + }, + { + relation: 'locker', + scope: { + fields: ['id', 'code', 'gender'], + include: { + relation: 'worker', + scope: {fields: ['id']} + } + } } + ] }; -- 2.40.1 From c0c3d913b7fd1322b708e3b86cf3c155543427d4 Mon Sep 17 00:00:00 2001 From: carlossa Date: Fri, 12 Jan 2024 09:03:54 +0100 Subject: [PATCH 11/26] refs #5919 locker --- modules/worker/back/models/locker.json | 12 ---------- modules/worker/back/models/worker.js | 6 ++--- modules/worker/back/models/worker.json | 7 ++++-- modules/worker/front/basic-data/index.html | 18 +++++++++++---- modules/worker/front/basic-data/index.js | 26 +++++++++++++--------- modules/worker/front/card/index.js | 5 +++++ modules/worker/front/summary/index.html | 5 +++-- modules/worker/front/summary/index.js | 7 +----- 8 files changed, 47 insertions(+), 39 deletions(-) diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json index 9601ca129b..62ddd0a5b9 100644 --- a/modules/worker/back/models/locker.json +++ b/modules/worker/back/models/locker.json @@ -2,11 +2,6 @@ "name": "Locker", "description": "Employee's locker", "base": "VnModel", - "options": { - "mysql": { - "table": "locker" - } - }, "properties": { "code": { "type": "string" @@ -14,12 +9,5 @@ "gender": { "type": "string" } - }, - "relations": { - "worker": { - "type": "belongsTo", - "model": "worker", - "foreignKey": "workerFk" - } } } diff --git a/modules/worker/back/models/worker.js b/modules/worker/back/models/worker.js index 985d83e9f7..266a3e1ca9 100644 --- a/modules/worker/back/models/worker.js +++ b/modules/worker/back/models/worker.js @@ -20,7 +20,7 @@ module.exports = Self => { require('../methods/worker/isAuthorized')(Self); require('../methods/worker/setPassword')(Self); - Self.validatesUniquenessOf('locker', { - message: 'This locker has already been assigned' - }); + // Self.validatesUniquenessOf('locker', { + // message: 'This locker has already been assigned' + // }); }; diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index 70c3881cf1..4680a4daae 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -53,6 +53,9 @@ }, "isF11Allowed": { "type" : "boolean" + }, + "sex": { + "type" : "string" } }, "relations": { @@ -87,9 +90,9 @@ "foreignKey": "workerFk" }, "locker": { - "type": "belongsTo", + "type": "hasOne", "model": "Locker", - "foreignKey": "code" + "foreignKey": "workerFk" } } } diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index a3f122a493..a835483cca 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -5,6 +5,12 @@ form="form" save="patch"> + +
@@ -75,11 +81,15 @@ ng-model="$ctrl.worker.SSN" rule> - - + data="$ctrl.$.locker.data" + show-field="code" + value-field="id" + ng-model="$ctrl.worker.locker.id"> + --> + diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index aae9774ec2..2d0b3f300e 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -8,21 +8,27 @@ class Controller extends Section { {code: 'M', name: this.$t('Married')}, {code: 'S', name: this.$t('Single')} ]; + this.$.lockerFilter = {workerFk: null}; + } + get worker() { + return this._worker; + } + + set worker(value) { + this._worker = value; + console.log('VALUE', value); + if (value) { + this.$.lockerFilter = {where: {AND: [{workerFk: null}, {gender: value.sex}]}}; + this.$.locker.refresh(); + } } onSubmit() { + console.log(this.worker); + console.log(this.$.watcher.orgData); + // if(this.$.worker.locker.id != ) return this.$.watcher.submit() .then(() => this.card.reload()); } - // async chooseLocker() { - // const locker = - // `SELECT l.code - // FROM worker w - // JOIN locker l ON w.sex = l.gender - // WHERE w.id = ? AND l.workerFk IS NULL; - // `[this.id]; - - // return locker; - // } } ngModule.vnComponent('vnWorkerBasicData', { diff --git a/modules/worker/front/card/index.js b/modules/worker/front/card/index.js index 9a40e31c2e..48cb80f1ea 100644 --- a/modules/worker/front/card/index.js +++ b/modules/worker/front/card/index.js @@ -28,6 +28,11 @@ class Controller extends ModuleCard { relation: 'department' } } + }, { + relation: 'locker', + scope: { + fields: ['id', 'code', 'gender'] + } } ] }; diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index 5e743efa35..b7212815f2 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -58,8 +58,9 @@ phone-number="worker.client.phone" > - diff --git a/modules/worker/front/summary/index.js b/modules/worker/front/summary/index.js index 647e47e643..1ee2de54e7 100644 --- a/modules/worker/front/summary/index.js +++ b/modules/worker/front/summary/index.js @@ -55,14 +55,9 @@ class Controller extends Summary { { relation: 'locker', scope: { - fields: ['id', 'code', 'gender'], - include: { - relation: 'worker', - scope: {fields: ['id']} - } + fields: ['id', 'code', 'gender'] } } - ] }; -- 2.40.1 From bf796c445d496c1692c64e682b802e0108e970c5 Mon Sep 17 00:00:00 2001 From: carlossa Date: Wed, 17 Jan 2024 13:20:28 +0100 Subject: [PATCH 12/26] refs #5919 fix section --- modules/worker/back/models/locker.json | 7 ++- modules/worker/front/basic-data/index.html | 2 +- modules/worker/front/basic-data/index.js | 23 +++++----- modules/worker/front/locker/index.html | 50 ++++++++++++++++++++ modules/worker/front/locker/index.js | 53 ++++++++++++++++++++++ modules/worker/front/locker/style.scss | 6 +++ 6 files changed, 127 insertions(+), 14 deletions(-) create mode 100644 modules/worker/front/locker/index.html create mode 100644 modules/worker/front/locker/index.js create mode 100644 modules/worker/front/locker/style.scss diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json index 62ddd0a5b9..b329648c10 100644 --- a/modules/worker/back/models/locker.json +++ b/modules/worker/back/models/locker.json @@ -1,7 +1,12 @@ { "name": "Locker", - "description": "Employee's locker", "base": "VnModel", + "description": "Employee's locker", + "options": { + "mysql": { + "table": "locker" + } + }, "properties": { "code": { "type": "string" diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index a835483cca..af320f6165 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -7,7 +7,7 @@ diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index 2d0b3f300e..24d7091a6f 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -8,20 +8,19 @@ class Controller extends Section { {code: 'M', name: this.$t('Married')}, {code: 'S', name: this.$t('Single')} ]; - this.$.lockerFilter = {workerFk: null}; - } - get worker() { - return this._worker; + // this.$.lockerFilter = {workerFk: null}; } + // get worker() { + // return this._worker; + // } - set worker(value) { - this._worker = value; - console.log('VALUE', value); - if (value) { - this.$.lockerFilter = {where: {AND: [{workerFk: null}, {gender: value.sex}]}}; - this.$.locker.refresh(); - } - } + // set worker(value) { + // this._worker = value; + // console.log('VALUE', value); + // if (value) + // this.$.lockerFilter = {where: {AND: [{workerFk: null}, {gender: value.sex}]}}; + // // this.$.locker.refresh(); + // } onSubmit() { console.log(this.worker); console.log(this.$.watcher.orgData); diff --git a/modules/worker/front/locker/index.html b/modules/worker/front/locker/index.html new file mode 100644 index 0000000000..c6d31dc858 --- /dev/null +++ b/modules/worker/front/locker/index.html @@ -0,0 +1,50 @@ +
+ + + + + + + + + + +
+ + + + + +
+ ID: {{id}} +
+
+ {{modelFk}}, {{serialNumber}} +
+ + + + + + + + + diff --git a/modules/worker/front/locker/index.js b/modules/worker/front/locker/index.js new file mode 100644 index 0000000000..885261e5c4 --- /dev/null +++ b/modules/worker/front/locker/index.js @@ -0,0 +1,53 @@ +import ngModule from '../module'; +import Section from 'salix/components/section'; +import './style.scss'; + +class Controller extends Section { + constructor($element, $) { + super($element, $); + const filter = { + where: {userFk: this.$params.id}, + include: {relation: 'deviceProduction'} + }; + this.$http.get('DeviceProductionUsers', {filter}). + then(res => { + if (res.data && res.data.length > 0) + this.setCurrentPDA(res.data[0]); + }); + } + + deallocatePDA() { + this.$http.post(`Workers/${this.$params.id}/deallocatePDA`, {pda: this.currentPDA.deviceProductionFk}) + .then(() => { + this.vnApp.showSuccess(this.$t('PDA deallocated')); + delete this.currentPDA; + }); + } + + allocatePDA() { + this.$http.post(`Workers/${this.$params.id}/allocatePDA`, {pda: this.newPDA}) + .then(res => { + if (res.data) + this.setCurrentPDA(res.data); + + this.vnApp.showSuccess(this.$t('PDA allocated')); + delete this.newPDA; + }); + } + + setCurrentPDA(data) { + this.currentPDA = data; + this.currentPDA.description = []; + this.currentPDA.description.push(`ID: ${this.currentPDA.deviceProductionFk}`); + this.currentPDA.description.push(`${this.$t('Model')}: ${this.currentPDA.deviceProduction.modelFk}`); + this.currentPDA.description.push(`${this.$t('Serial Number')}: ${this.currentPDA.deviceProduction.serialNumber}`); + this.currentPDA.description = this.currentPDA.description.join(' '); + } +} + +Controller.$inject = ['$element', '$scope']; + +ngModule.vnComponent('vnWorkerPda', { + template: require('./index.html'), + controller: Controller, +}); diff --git a/modules/worker/front/locker/style.scss b/modules/worker/front/locker/style.scss new file mode 100644 index 0000000000..c55c9d2187 --- /dev/null +++ b/modules/worker/front/locker/style.scss @@ -0,0 +1,6 @@ +@import "./variables"; + +.text-grey { + color: $color-font-light; +} + -- 2.40.1 From 0003779681b75db01be11f2a52333fa8699ee9f6 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 29 Apr 2024 11:35:08 +0200 Subject: [PATCH 13/26] fix: refs 5919 apply version --- db/{changes/240201 => versions/11019-grayDendro}/00-locker.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename db/{changes/240201 => versions/11019-grayDendro}/00-locker.sql (99%) diff --git a/db/changes/240201/00-locker.sql b/db/versions/11019-grayDendro/00-locker.sql similarity index 99% rename from db/changes/240201/00-locker.sql rename to db/versions/11019-grayDendro/00-locker.sql index 714ec7aff9..462f56caad 100644 --- a/db/changes/240201/00-locker.sql +++ b/db/versions/11019-grayDendro/00-locker.sql @@ -5,7 +5,7 @@ ALTER TABLE `vn`.`worker` DROP COLUMN `locker`; CREATE TABLE `vn`.`locker` ( `id` int(100) auto_increment, `code` varchar(10) DEFAULT NULL, - `gender` varchar(255) DEFAULT NULL, + `gender` ENUM('M','F') DEFAULT NULL, `workerFk` int(10) unsigned DEFAULT NULL, PRIMARY KEY (`id`), UNIQUE KEY `code` (`code`), -- 2.40.1 From 50ea41f99adaed1040f97d65a2d33c37502c6902 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 29 Apr 2024 11:43:56 +0200 Subject: [PATCH 14/26] fix: refs #5919 rollback --- modules/worker/front/basic-data/index.html | 12 ++--- modules/worker/front/basic-data/index.js | 14 ------ modules/worker/front/locker/index.html | 50 -------------------- modules/worker/front/locker/index.js | 53 ---------------------- modules/worker/front/locker/style.scss | 6 --- modules/worker/front/summary/index.html | 5 +- 6 files changed, 5 insertions(+), 135 deletions(-) delete mode 100644 modules/worker/front/locker/index.html delete mode 100644 modules/worker/front/locker/index.js delete mode 100644 modules/worker/front/locker/style.scss diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index af320f6165..d3a07baa31 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -81,15 +81,9 @@ ng-model="$ctrl.worker.SSN" rule> - - + diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index 24d7091a6f..cbf8291dec 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -8,23 +8,9 @@ class Controller extends Section { {code: 'M', name: this.$t('Married')}, {code: 'S', name: this.$t('Single')} ]; - // this.$.lockerFilter = {workerFk: null}; } - // get worker() { - // return this._worker; - // } - // set worker(value) { - // this._worker = value; - // console.log('VALUE', value); - // if (value) - // this.$.lockerFilter = {where: {AND: [{workerFk: null}, {gender: value.sex}]}}; - // // this.$.locker.refresh(); - // } onSubmit() { - console.log(this.worker); - console.log(this.$.watcher.orgData); - // if(this.$.worker.locker.id != ) return this.$.watcher.submit() .then(() => this.card.reload()); } diff --git a/modules/worker/front/locker/index.html b/modules/worker/front/locker/index.html deleted file mode 100644 index c6d31dc858..0000000000 --- a/modules/worker/front/locker/index.html +++ /dev/null @@ -1,50 +0,0 @@ -
- - - - - - - - - - -
-
- - - - -
- ID: {{id}} -
-
- {{modelFk}}, {{serialNumber}} -
- - - - - - - - -
diff --git a/modules/worker/front/locker/index.js b/modules/worker/front/locker/index.js deleted file mode 100644 index 885261e5c4..0000000000 --- a/modules/worker/front/locker/index.js +++ /dev/null @@ -1,53 +0,0 @@ -import ngModule from '../module'; -import Section from 'salix/components/section'; -import './style.scss'; - -class Controller extends Section { - constructor($element, $) { - super($element, $); - const filter = { - where: {userFk: this.$params.id}, - include: {relation: 'deviceProduction'} - }; - this.$http.get('DeviceProductionUsers', {filter}). - then(res => { - if (res.data && res.data.length > 0) - this.setCurrentPDA(res.data[0]); - }); - } - - deallocatePDA() { - this.$http.post(`Workers/${this.$params.id}/deallocatePDA`, {pda: this.currentPDA.deviceProductionFk}) - .then(() => { - this.vnApp.showSuccess(this.$t('PDA deallocated')); - delete this.currentPDA; - }); - } - - allocatePDA() { - this.$http.post(`Workers/${this.$params.id}/allocatePDA`, {pda: this.newPDA}) - .then(res => { - if (res.data) - this.setCurrentPDA(res.data); - - this.vnApp.showSuccess(this.$t('PDA allocated')); - delete this.newPDA; - }); - } - - setCurrentPDA(data) { - this.currentPDA = data; - this.currentPDA.description = []; - this.currentPDA.description.push(`ID: ${this.currentPDA.deviceProductionFk}`); - this.currentPDA.description.push(`${this.$t('Model')}: ${this.currentPDA.deviceProduction.modelFk}`); - this.currentPDA.description.push(`${this.$t('Serial Number')}: ${this.currentPDA.deviceProduction.serialNumber}`); - this.currentPDA.description = this.currentPDA.description.join(' '); - } -} - -Controller.$inject = ['$element', '$scope']; - -ngModule.vnComponent('vnWorkerPda', { - template: require('./index.html'), - controller: Controller, -}); diff --git a/modules/worker/front/locker/style.scss b/modules/worker/front/locker/style.scss deleted file mode 100644 index c55c9d2187..0000000000 --- a/modules/worker/front/locker/style.scss +++ /dev/null @@ -1,6 +0,0 @@ -@import "./variables"; - -.text-grey { - color: $color-font-light; -} - diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index b7212815f2..5e743efa35 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -58,9 +58,8 @@ phone-number="worker.client.phone" > - -- 2.40.1 From 7240269f5b0bb7dd95b9866d8f29a31e72c95423 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 29 Apr 2024 11:45:54 +0200 Subject: [PATCH 15/26] fix: refs #5919 rollback --- modules/worker/front/basic-data/index.html | 9 ++------- modules/worker/front/summary/index.html | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index d3a07baa31..e42937b85f 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -5,12 +5,6 @@ form="form" save="patch"> - -
@@ -83,7 +77,8 @@ + diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index 5e743efa35..48a1545294 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -59,7 +59,7 @@ > -- 2.40.1 From f6e89c904987099905b9a25bf8fb4af0ca83f12d Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 29 Apr 2024 11:46:58 +0200 Subject: [PATCH 16/26] fix: refs #5919 rollback --- modules/worker/front/basic-data/index.html | 3 ++- modules/worker/front/basic-data/index.js | 1 - modules/worker/front/summary/index.html | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index e42937b85f..2d85d018de 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -77,7 +77,8 @@ + label="Locker" + ng-model="$ctrl.worker.locker"> diff --git a/modules/worker/front/basic-data/index.js b/modules/worker/front/basic-data/index.js index cbf8291dec..ea75d7b973 100644 --- a/modules/worker/front/basic-data/index.js +++ b/modules/worker/front/basic-data/index.js @@ -9,7 +9,6 @@ class Controller extends Section { {code: 'S', name: this.$t('Single')} ]; } - onSubmit() { return this.$.watcher.submit() .then(() => this.card.reload()); diff --git a/modules/worker/front/summary/index.html b/modules/worker/front/summary/index.html index 48a1545294..2372634bc2 100644 --- a/modules/worker/front/summary/index.html +++ b/modules/worker/front/summary/index.html @@ -59,8 +59,7 @@ > + value="{{worker.locker}}"> -- 2.40.1 From be69b5e2c434de06db2b9831d51f40ee6c944ab8 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 29 Apr 2024 12:04:31 +0200 Subject: [PATCH 17/26] fix: refs #5919 rollback --- modules/worker/back/methods/worker/filter.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/worker/back/methods/worker/filter.js b/modules/worker/back/methods/worker/filter.js index 6ca4f30439..2f328d28fa 100644 --- a/modules/worker/back/methods/worker/filter.js +++ b/modules/worker/back/methods/worker/filter.js @@ -117,15 +117,14 @@ module.exports = Self => { stmt = new ParameterizedSQL( `SELECT w.id, u.email, p.extension, u.name as userName, - d.name AS department, w.lastName, u.nickname, mu.email, lc.code + d.name AS department, w.lastName, u.nickname, mu.email FROM worker w LEFT JOIN workerDepartment wd ON wd.workerFk = w.id LEFT JOIN department d ON d.id = wd.departmentFk LEFT JOIN client c ON c.id = w.id LEFT JOIN account.user u ON u.id = w.id LEFT JOIN pbx.sip p ON p.user_id = u.id - LEFT JOIN account.emailUser mu ON mu.userFk = u.id - LEFT JOIN locker lc ON lc.workerFk = w.id` + LEFT JOIN account.emailUser mu ON mu.userFk = u.id` ); stmt.merge(conn.makeSuffix(filter)); -- 2.40.1 From 9802f0066c9a892a73b6929af999205ff8d05825 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 29 Apr 2024 16:05:36 +0200 Subject: [PATCH 18/26] fix: refs #5919 unique key & unassigned locker --- db/routines/vn/procedures/workerDisable.sql | 4 ++++ db/versions/11019-grayDendro/00-locker.sql | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/db/routines/vn/procedures/workerDisable.sql b/db/routines/vn/procedures/workerDisable.sql index 4b10cb7fa2..04612a6dc5 100644 --- a/db/routines/vn/procedures/workerDisable.sql +++ b/db/routines/vn/procedures/workerDisable.sql @@ -28,5 +28,9 @@ mainLabel:BEGIN UPDATE `client` c SET c.salesPersonFk = null WHERE c.salesPersonFk = vUserId; + + UPDATE locker l + SET l.workerFk = NULL + WHERE l.workerFk = vUserId; END$$ DELIMITER ; diff --git a/db/versions/11019-grayDendro/00-locker.sql b/db/versions/11019-grayDendro/00-locker.sql index 462f56caad..2cb866b11b 100644 --- a/db/versions/11019-grayDendro/00-locker.sql +++ b/db/versions/11019-grayDendro/00-locker.sql @@ -9,7 +9,7 @@ CREATE TABLE `vn`.`locker` ( `workerFk` int(10) unsigned DEFAULT NULL, PRIMARY KEY (`id`), UNIQUE KEY `code` (`code`), - KEY `workerFk` (`workerFk`), + UNIQUE KEY `workerFk` (`workerFk`), CONSTRAINT `locker_ibfk_1` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci; -- 2.40.1 From 26ff5e8fa9ee7f933b024bc47022b59678d5e7a2 Mon Sep 17 00:00:00 2001 From: jorgep Date: Wed, 8 May 2024 11:03:18 +0200 Subject: [PATCH 19/26] feat; refs #5919 WIP acls --- db/versions/11019-grayDendro/01-aclLocker.sql | 7 +++++++ modules/worker/back/models/locker.json | 14 ++++++++++++- modules/worker/back/models/worker.json | 20 ++++++++++++++++++- 3 files changed, 39 insertions(+), 2 deletions(-) create mode 100644 db/versions/11019-grayDendro/01-aclLocker.sql diff --git a/db/versions/11019-grayDendro/01-aclLocker.sql b/db/versions/11019-grayDendro/01-aclLocker.sql new file mode 100644 index 0000000000..6b3a66817e --- /dev/null +++ b/db/versions/11019-grayDendro/01-aclLocker.sql @@ -0,0 +1,7 @@ +INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`) + VALUES ('Locker', '__get__codes', 'READ', 'ALLOW', 'ROLE', 'employee'), + ('Locker', '*', '*', 'ALLOW', 'ROLE', 'hr'), + ('Locker', '*', '*', 'ALLOW', 'ROLE', 'productionBoss'), + ('Worker', '__get__locker', 'READ', 'ALLOW', 'ROLE', 'hr'), + ('Worker', '__get__locker', 'READ', 'ALLOW', 'ROLE', 'productionBoss'), + ('Worker', '__get__locker', 'READ', 'ALLOW', 'ROLE', 'productionBoss'); diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json index b329648c10..1609df32db 100644 --- a/modules/worker/back/models/locker.json +++ b/modules/worker/back/models/locker.json @@ -1,7 +1,7 @@ { "name": "Locker", "base": "VnModel", - "description": "Employee's locker", + "description": "Worker's locker", "options": { "mysql": { "table": "locker" @@ -14,5 +14,17 @@ "gender": { "type": "string" } + }, + "relations": { + "user": { + "type": "belongsTo", + "model": "VnUser", + "foreignKey": "workerFk" + } + }, + "scopes": { + "codes": { + "fields": ["id","code"] + } } } diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index af31b11fe0..cbe0e45867 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -97,5 +97,23 @@ "model": "Locker", "foreignKey": "workerFk" } - } + }, + "scopes":{ + "locker": { + "fields":["id","sex"], + "include": { + "relation": "locker", + "scope": {"fields": ["id", "code"]} + } + } + }, + "acls":[ + { + "property": "__get__locker", + "accessType": "READ", + "permission": "ALLOW", + "principalType": "ROLE", + "principalId": "$owner" + } + ] } -- 2.40.1 From 7f4965879c1379fc4b587fcc793fd82c6d6c26fa Mon Sep 17 00:00:00 2001 From: jorgep Date: Thu, 9 May 2024 15:54:34 +0200 Subject: [PATCH 20/26] fix: refs #5919 get locker by relation --- db/versions/11019-grayDendro/01-aclLocker.sql | 1 - modules/worker/back/models/locker.json | 7 ------- modules/worker/back/models/worker.json | 9 --------- 3 files changed, 17 deletions(-) diff --git a/db/versions/11019-grayDendro/01-aclLocker.sql b/db/versions/11019-grayDendro/01-aclLocker.sql index 6b3a66817e..7bc8b12a06 100644 --- a/db/versions/11019-grayDendro/01-aclLocker.sql +++ b/db/versions/11019-grayDendro/01-aclLocker.sql @@ -3,5 +3,4 @@ INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `pri ('Locker', '*', '*', 'ALLOW', 'ROLE', 'hr'), ('Locker', '*', '*', 'ALLOW', 'ROLE', 'productionBoss'), ('Worker', '__get__locker', 'READ', 'ALLOW', 'ROLE', 'hr'), - ('Worker', '__get__locker', 'READ', 'ALLOW', 'ROLE', 'productionBoss'), ('Worker', '__get__locker', 'READ', 'ALLOW', 'ROLE', 'productionBoss'); diff --git a/modules/worker/back/models/locker.json b/modules/worker/back/models/locker.json index 1609df32db..335fca5a96 100644 --- a/modules/worker/back/models/locker.json +++ b/modules/worker/back/models/locker.json @@ -15,13 +15,6 @@ "type": "string" } }, - "relations": { - "user": { - "type": "belongsTo", - "model": "VnUser", - "foreignKey": "workerFk" - } - }, "scopes": { "codes": { "fields": ["id","code"] diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index 6080af77c3..76ad08d09e 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -101,15 +101,6 @@ "foreignKey": "workerFk" } }, - "scopes":{ - "locker": { - "fields":["id","sex"], - "include": { - "relation": "locker", - "scope": {"fields": ["id", "code"]} - } - } - }, "acls":[ { "property": "__get__locker", -- 2.40.1 From af11bb8663009284bc043bcd25e1b8a05fc4e95f Mon Sep 17 00:00:00 2001 From: jorgep Date: Fri, 10 May 2024 13:04:12 +0200 Subject: [PATCH 21/26] feat: refs #5919 hook --- .../11043-blackRoebelini/00-logLocker.sql | 2 ++ modules/worker/back/models/locker.js | 21 +++++++++++++++++++ modules/worker/back/models/worker.json | 2 +- 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 db/versions/11043-blackRoebelini/00-logLocker.sql create mode 100644 modules/worker/back/models/locker.js diff --git a/db/versions/11043-blackRoebelini/00-logLocker.sql b/db/versions/11043-blackRoebelini/00-logLocker.sql new file mode 100644 index 0000000000..ba615420bb --- /dev/null +++ b/db/versions/11043-blackRoebelini/00-logLocker.sql @@ -0,0 +1,2 @@ +ALTER TABLE vn.workerLog + MODIFY COLUMN changedModel enum('Worker','Calendar','WorkerTimeControlMail','Business','WorkerDms','WorkerTimeControl', 'Locker') NOT NULL DEFAULT 'Worker'; diff --git a/modules/worker/back/models/locker.js b/modules/worker/back/models/locker.js new file mode 100644 index 0000000000..4475c2cd1c --- /dev/null +++ b/modules/worker/back/models/locker.js @@ -0,0 +1,21 @@ +module.exports = Self => { + Self.observe('before save', async ctx => { + const models = Self.app.models; + const changes = ctx.data || ctx.instance; + const instance = ctx.currentInstance; + + const workerFk = changes?.workerFk || instance?.workerFk; + if (workerFk) { + const locker = await models.Locker.findOne({ + where: {workerFk} + }, ctx.options); + + if (locker) { + await Self.rawSql( + 'UPDATE locker SET workerFk = NULL where workerFk = ?', + [workerFk], + ctx.options); + } + } + }); +}; diff --git a/modules/worker/back/models/worker.json b/modules/worker/back/models/worker.json index 76ad08d09e..adfe2c58e9 100644 --- a/modules/worker/back/models/worker.json +++ b/modules/worker/back/models/worker.json @@ -96,7 +96,7 @@ "foreignKey": "workerFk" }, "locker": { - "type": "hasOne", + "type": "hasMany", "model": "Locker", "foreignKey": "workerFk" } -- 2.40.1 From 1996a00af1b29e72a3a575d50f27d56336e3f95e Mon Sep 17 00:00:00 2001 From: jorgep Date: Fri, 10 May 2024 13:31:21 +0200 Subject: [PATCH 22/26] feat: refs #5919 drop version --- db/versions/11019-grayDendro/00-locker.sql | 8 +++----- db/versions/11043-blackRoebelini/00-logLocker.sql | 2 -- 2 files changed, 3 insertions(+), 7 deletions(-) delete mode 100644 db/versions/11043-blackRoebelini/00-logLocker.sql diff --git a/db/versions/11019-grayDendro/00-locker.sql b/db/versions/11019-grayDendro/00-locker.sql index 2cb866b11b..831fdc616c 100644 --- a/db/versions/11019-grayDendro/00-locker.sql +++ b/db/versions/11019-grayDendro/00-locker.sql @@ -1,7 +1,6 @@ -- Eliminar locker ALTER TABLE `vn`.`worker` DROP COLUMN `locker`; - CREATE TABLE `vn`.`locker` ( `id` int(100) auto_increment, `code` varchar(10) DEFAULT NULL, @@ -13,6 +12,8 @@ CREATE TABLE `vn`.`locker` ( CONSTRAINT `locker_ibfk_1` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci; +ALTER TABLE vn.workerLog + MODIFY COLUMN changedModel enum('Worker','Calendar','WorkerTimeControlMail','Business','WorkerDms','WorkerTimeControl', 'Locker') NOT NULL DEFAULT 'Worker'; -- Insertar taquillas disponibles para hombres (1A - 73A / 1B - 73B) INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES @@ -56,7 +57,4 @@ INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), ('205B', 'F', NULL), ('206B', 'F', NULL), ('207B', 'F', NULL), ('208B', 'F', NULL), ('209B', 'F', NULL), ('210B', 'F', NULL), ('211B', 'F', NULL), ('212B', 'F', NULL), ('213B', 'F', NULL), ('214B', 'F', NULL), - ('215B', 'F', NULL), ('216B', 'F', NULL), ('217B', 'F', NULL); - - - + ('215B', 'F', NULL), ('216B', 'F', NULL), ('217B', 'F', NULL); \ No newline at end of file diff --git a/db/versions/11043-blackRoebelini/00-logLocker.sql b/db/versions/11043-blackRoebelini/00-logLocker.sql deleted file mode 100644 index ba615420bb..0000000000 --- a/db/versions/11043-blackRoebelini/00-logLocker.sql +++ /dev/null @@ -1,2 +0,0 @@ -ALTER TABLE vn.workerLog - MODIFY COLUMN changedModel enum('Worker','Calendar','WorkerTimeControlMail','Business','WorkerDms','WorkerTimeControl', 'Locker') NOT NULL DEFAULT 'Worker'; -- 2.40.1 From 8943bc7115f634dd3a8b008300ba6dbf91ed8ac5 Mon Sep 17 00:00:00 2001 From: jorgep Date: Fri, 10 May 2024 14:04:34 +0200 Subject: [PATCH 23/26] fix: refs #5919 back tests --- db/versions/11019-grayDendro/00-locker.sql | 80 +++++++++++----------- modules/worker/back/models/worker.js | 4 -- 2 files changed, 40 insertions(+), 44 deletions(-) diff --git a/db/versions/11019-grayDendro/00-locker.sql b/db/versions/11019-grayDendro/00-locker.sql index 831fdc616c..7e63e06fa3 100644 --- a/db/versions/11019-grayDendro/00-locker.sql +++ b/db/versions/11019-grayDendro/00-locker.sql @@ -12,49 +12,49 @@ CREATE TABLE `vn`.`locker` ( CONSTRAINT `locker_ibfk_1` FOREIGN KEY (`workerFk`) REFERENCES `worker` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci; -ALTER TABLE vn.workerLog - MODIFY COLUMN changedModel enum('Worker','Calendar','WorkerTimeControlMail','Business','WorkerDms','WorkerTimeControl', 'Locker') NOT NULL DEFAULT 'Worker'; +ALTER TABLE `vn`.`workerLog` + MODIFY COLUMN changedModel enum('Worker','Calendar','WorkerTimeControlMail','Business','WorkerDms','WorkerTimeControl', 'Locker') NOT NULL DEFAULT 'Worker'; -- Insertar taquillas disponibles para hombres (1A - 73A / 1B - 73B) INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES - ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), - ('6A', 'M', NULL), ('7A', 'M', NULL), ('8A', 'M', NULL), ('9A', 'M', NULL), ('10A', 'M', NULL), - ('11A', 'M', NULL), ('12A', 'M', NULL), ('13A', 'M', NULL), ('14A', 'M', NULL), ('15A', 'M', NULL), - ('16A', 'M', NULL), ('17A', 'M', NULL), ('18A', 'M', NULL), ('19A', 'M', NULL), ('20A', 'M', NULL), - ('21A', 'M', NULL), ('22A', 'M', NULL), ('23A', 'M', NULL), ('24A', 'M', NULL), ('25A', 'M', NULL), - ('26A', 'M', NULL), ('27A', 'M', NULL), ('28A', 'M', NULL), ('29A', 'M', NULL), ('30A', 'M', NULL), - ('31A', 'M', NULL), ('32A', 'M', NULL), ('33A', 'M', NULL), ('34A', 'M', NULL), ('35A', 'M', NULL), - ('36A', 'M', NULL), ('37A', 'M', NULL), ('38A', 'M', NULL), ('39A', 'M', NULL), ('40A', 'M', NULL), - ('41A', 'M', NULL), ('42A', 'M', NULL), ('43A', 'M', NULL), ('44A', 'M', NULL), ('45A', 'M', NULL), - ('46A', 'M', NULL), ('47A', 'M', NULL), ('48A', 'M', NULL), ('49A', 'M', NULL), ('50A', 'M', NULL), - ('51A', 'M', NULL), ('52A', 'M', NULL), ('53A', 'M', NULL), ('54A', 'M', NULL), ('55A', 'M', NULL), - ('56A', 'M', NULL), ('57A', 'M', NULL), ('58A', 'M', NULL), ('59A', 'M', NULL), ('60A', 'M', NULL), - ('61A', 'M', NULL), ('62A', 'M', NULL), ('63A', 'M', NULL), ('64A', 'M', NULL), ('65A', 'M', NULL), - ('66A', 'M', NULL), ('67A', 'M', NULL), ('68A', 'M', NULL), ('69A', 'M', NULL), ('70A', 'M', NULL), - ('71A', 'M', NULL), ('72A', 'M', NULL), ('73A', 'M', NULL), - ('1B', 'M', NULL), ('2B', 'M', NULL), ('3B', 'M', NULL), ('4B', 'M', NULL), ('5B', 'M', NULL), - ('6B', 'M', NULL), ('7B', 'M', NULL), ('8B', 'M', NULL), ('9B', 'M', NULL), ('10B', 'M', NULL), - ('11B', 'M', NULL), ('12B', 'M', NULL), ('13B', 'M', NULL), ('14B', 'M', NULL), ('15B', 'M', NULL), - ('16B', 'M', NULL), ('17B', 'M', NULL), ('18B', 'M', NULL), ('19B', 'M', NULL), ('20B', 'M', NULL), - ('21B', 'M', NULL), ('22B', 'M', NULL), ('23B', 'M', NULL), ('24B', 'M', NULL), ('25B', 'M', NULL), - ('26B', 'M', NULL), ('27B', 'M', NULL), ('28B', 'M', NULL), ('29B', 'M', NULL), ('30B', 'M', NULL), - ('31B', 'M', NULL), ('32B', 'M', NULL), ('33B', 'M', NULL), ('34B', 'M', NULL), ('35B', 'M', NULL), - ('36B', 'M', NULL), ('37B', 'M', NULL), ('38B', 'M', NULL), ('39B', 'M', NULL), ('40B', 'M', NULL), - ('41B', 'M', NULL), ('42B', 'M', NULL), ('43B', 'M', NULL), ('44B', 'M', NULL), ('45B', 'M', NULL), - ('46B', 'M', NULL), ('47B', 'M', NULL), ('48B', 'M', NULL), ('49B', 'M', NULL), ('50B', 'M', NULL), - ('51B', 'M', NULL), ('52B', 'M', NULL), ('53B', 'M', NULL), ('54B', 'M', NULL), ('55B', 'M', NULL), - ('56B', 'M', NULL), ('57B', 'M', NULL), ('58B', 'M', NULL), ('59B', 'M', NULL), ('60B', 'M', NULL), - ('61B', 'M', NULL), ('62B', 'M', NULL), ('63B', 'M', NULL), ('64B', 'M', NULL), ('65B', 'M', NULL), - ('66B', 'M', NULL), ('67B', 'M', NULL), ('68B', 'M', NULL), ('69B', 'M', NULL), ('70B', 'M', NULL), - ('71B', 'M', NULL), ('72B', 'M', NULL), ('73B', 'M', NULL); + ('1A', 'M', NULL), ('2A', 'M', NULL), ('3A', 'M', NULL), ('4A', 'M', NULL), ('5A', 'M', NULL), + ('6A', 'M', NULL), ('7A', 'M', NULL), ('8A', 'M', NULL), ('9A', 'M', NULL), ('10A', 'M', NULL), + ('11A', 'M', NULL), ('12A', 'M', NULL), ('13A', 'M', NULL), ('14A', 'M', NULL), ('15A', 'M', NULL), + ('16A', 'M', NULL), ('17A', 'M', NULL), ('18A', 'M', NULL), ('19A', 'M', NULL), ('20A', 'M', NULL), + ('21A', 'M', NULL), ('22A', 'M', NULL), ('23A', 'M', NULL), ('24A', 'M', NULL), ('25A', 'M', NULL), + ('26A', 'M', NULL), ('27A', 'M', NULL), ('28A', 'M', NULL), ('29A', 'M', NULL), ('30A', 'M', NULL), + ('31A', 'M', NULL), ('32A', 'M', NULL), ('33A', 'M', NULL), ('34A', 'M', NULL), ('35A', 'M', NULL), + ('36A', 'M', NULL), ('37A', 'M', NULL), ('38A', 'M', NULL), ('39A', 'M', NULL), ('40A', 'M', NULL), + ('41A', 'M', NULL), ('42A', 'M', NULL), ('43A', 'M', NULL), ('44A', 'M', NULL), ('45A', 'M', NULL), + ('46A', 'M', NULL), ('47A', 'M', NULL), ('48A', 'M', NULL), ('49A', 'M', NULL), ('50A', 'M', NULL), + ('51A', 'M', NULL), ('52A', 'M', NULL), ('53A', 'M', NULL), ('54A', 'M', NULL), ('55A', 'M', NULL), + ('56A', 'M', NULL), ('57A', 'M', NULL), ('58A', 'M', NULL), ('59A', 'M', NULL), ('60A', 'M', NULL), + ('61A', 'M', NULL), ('62A', 'M', NULL), ('63A', 'M', NULL), ('64A', 'M', NULL), ('65A', 'M', NULL), + ('66A', 'M', NULL), ('67A', 'M', NULL), ('68A', 'M', NULL), ('69A', 'M', NULL), ('70A', 'M', NULL), + ('71A', 'M', NULL), ('72A', 'M', NULL), ('73A', 'M', NULL), + ('1B', 'M', NULL), ('2B', 'M', NULL), ('3B', 'M', NULL), ('4B', 'M', NULL), ('5B', 'M', NULL), + ('6B', 'M', NULL), ('7B', 'M', NULL), ('8B', 'M', NULL), ('9B', 'M', NULL), ('10B', 'M', NULL), + ('11B', 'M', NULL), ('12B', 'M', NULL), ('13B', 'M', NULL), ('14B', 'M', NULL), ('15B', 'M', NULL), + ('16B', 'M', NULL), ('17B', 'M', NULL), ('18B', 'M', NULL), ('19B', 'M', NULL), ('20B', 'M', NULL), + ('21B', 'M', NULL), ('22B', 'M', NULL), ('23B', 'M', NULL), ('24B', 'M', NULL), ('25B', 'M', NULL), + ('26B', 'M', NULL), ('27B', 'M', NULL), ('28B', 'M', NULL), ('29B', 'M', NULL), ('30B', 'M', NULL), + ('31B', 'M', NULL), ('32B', 'M', NULL), ('33B', 'M', NULL), ('34B', 'M', NULL), ('35B', 'M', NULL), + ('36B', 'M', NULL), ('37B', 'M', NULL), ('38B', 'M', NULL), ('39B', 'M', NULL), ('40B', 'M', NULL), + ('41B', 'M', NULL), ('42B', 'M', NULL), ('43B', 'M', NULL), ('44B', 'M', NULL), ('45B', 'M', NULL), + ('46B', 'M', NULL), ('47B', 'M', NULL), ('48B', 'M', NULL), ('49B', 'M', NULL), ('50B', 'M', NULL), + ('51B', 'M', NULL), ('52B', 'M', NULL), ('53B', 'M', NULL), ('54B', 'M', NULL), ('55B', 'M', NULL), + ('56B', 'M', NULL), ('57B', 'M', NULL), ('58B', 'M', NULL), ('59B', 'M', NULL), ('60B', 'M', NULL), + ('61B', 'M', NULL), ('62B', 'M', NULL), ('63B', 'M', NULL), ('64B', 'M', NULL), ('65B', 'M', NULL), + ('66B', 'M', NULL), ('67B', 'M', NULL), ('68B', 'M', NULL), ('69B', 'M', NULL), ('70B', 'M', NULL), + ('71B', 'M', NULL), ('72B', 'M', NULL), ('73B', 'M', NULL); -- Insertar taquillas disponibles para mujeres (200A - 217A / 200B - 217B) INSERT INTO `vn`.`locker` (code, gender, workerFk) VALUES - ('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), - ('205A', 'F', NULL), ('206A', 'F', NULL), ('207A', 'F', NULL), ('208A', 'F', NULL), ('209A', 'F', NULL), - ('210A', 'F', NULL), ('211A', 'F', NULL), ('212A', 'F', NULL), ('213A', 'F', NULL), ('214A', 'F', NULL), - ('215A', 'F', NULL), ('216A', 'F', NULL), ('217A', 'F', NULL), - ('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), - ('205B', 'F', NULL), ('206B', 'F', NULL), ('207B', 'F', NULL), ('208B', 'F', NULL), ('209B', 'F', NULL), - ('210B', 'F', NULL), ('211B', 'F', NULL), ('212B', 'F', NULL), ('213B', 'F', NULL), ('214B', 'F', NULL), - ('215B', 'F', NULL), ('216B', 'F', NULL), ('217B', 'F', NULL); \ No newline at end of file +('200A', 'F', NULL), ('201A', 'F', NULL), ('202A', 'F', NULL), ('203A', 'F', NULL), ('204A', 'F', NULL), +('205A', 'F', NULL), ('206A', 'F', NULL), ('207A', 'F', NULL), ('208A', 'F', NULL), ('209A', 'F', NULL), +('210A', 'F', NULL), ('211A', 'F', NULL), ('212A', 'F', NULL), ('213A', 'F', NULL), ('214A', 'F', NULL), +('215A', 'F', NULL), ('216A', 'F', NULL), ('217A', 'F', NULL), +('200B', 'F', NULL), ('201B', 'F', NULL), ('202B', 'F', NULL), ('203B', 'F', NULL), ('204B', 'F', NULL), +('205B', 'F', NULL), ('206B', 'F', NULL), ('207B', 'F', NULL), ('208B', 'F', NULL), ('209B', 'F', NULL), +('210B', 'F', NULL), ('211B', 'F', NULL), ('212B', 'F', NULL), ('213B', 'F', NULL), ('214B', 'F', NULL), +('215B', 'F', NULL), ('216B', 'F', NULL), ('217B', 'F', NULL); \ No newline at end of file diff --git a/modules/worker/back/models/worker.js b/modules/worker/back/models/worker.js index b475bf26e2..076f2eaab5 100644 --- a/modules/worker/back/models/worker.js +++ b/modules/worker/back/models/worker.js @@ -21,10 +21,6 @@ module.exports = Self => { require('../methods/worker/isAuthorized')(Self); require('../methods/worker/setPassword')(Self); - Self.validatesUniquenessOf('locker', { - message: 'This locker has already been assigned' - }); - Self.validateAsync('fi', tinIsValid, { message: 'Invalid TIN' }); -- 2.40.1 From cbb7cb18eb74232cfaa94b75a2bc1c8a381fa122 Mon Sep 17 00:00:00 2001 From: jorgep Date: Fri, 10 May 2024 16:02:50 +0200 Subject: [PATCH 24/26] fix: refs #5919 delete locker field --- e2e/paths/03-worker/02_basicData.spec.js | 2 -- modules/worker/front/basic-data/index.html | 5 ----- 2 files changed, 7 deletions(-) diff --git a/e2e/paths/03-worker/02_basicData.spec.js b/e2e/paths/03-worker/02_basicData.spec.js index 381375dc7e..66a597dd13 100644 --- a/e2e/paths/03-worker/02_basicData.spec.js +++ b/e2e/paths/03-worker/02_basicData.spec.js @@ -25,7 +25,6 @@ describe('Worker basic data path', () => { await page.overwrite(selectors.workerBasicData.name, 'David C.'); await page.overwrite(selectors.workerBasicData.surname, 'H.'); await page.overwrite(selectors.workerBasicData.phone, '444332211'); - await page.overwrite(selectors.workerBasicData.locker, '1'); await page.click(selectors.workerBasicData.saveButton); const message = await page.waitForSnackbar(); @@ -37,6 +36,5 @@ describe('Worker basic data path', () => { expect(await page.waitToGetProperty(selectors.workerBasicData.name, 'value')).toEqual('David C.'); expect(await page.waitToGetProperty(selectors.workerBasicData.surname, 'value')).toEqual('H.'); expect(await page.waitToGetProperty(selectors.workerBasicData.phone, 'value')).toEqual('444332211'); - expect(await page.waitToGetProperty(selectors.workerBasicData.locker, 'value')).toEqual('1'); }); }); diff --git a/modules/worker/front/basic-data/index.html b/modules/worker/front/basic-data/index.html index 2d85d018de..aa3f6ca79b 100644 --- a/modules/worker/front/basic-data/index.html +++ b/modules/worker/front/basic-data/index.html @@ -75,11 +75,6 @@ ng-model="$ctrl.worker.SSN" rule> - - -- 2.40.1 From e16e5e3db3fd5b9b6efdce361f5014b0de9288d6 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 13 May 2024 13:19:28 +0200 Subject: [PATCH 25/26] feat: refs #5919 back test --- db/dump/fixtures.before.sql | 4 +- .../worker/back/models/specs/locker.spec.js | 56 +++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 modules/worker/back/models/specs/locker.spec.js diff --git a/db/dump/fixtures.before.sql b/db/dump/fixtures.before.sql index 348c1fd067..895046e3d0 100644 --- a/db/dump/fixtures.before.sql +++ b/db/dump/fixtures.before.sql @@ -3789,4 +3789,6 @@ INSERT INTO vn.workerTeam(id, team, workerFk) (8, 1, 19); INSERT INTO vn.workCenter (id, name, payrollCenterFk, counter, warehouseFk, street, geoFk, deliveryManAdjustment) - VALUES(100, 'workCenterOne', 1, NULL, 1, 'gotham', NULL, NULL); \ No newline at end of file + VALUES(100, 'workCenterOne', 1, NULL, 1, 'gotham', NULL, NULL); + +UPDATE vn.locker SET workerFk = 1110 WHERE id = 147; \ No newline at end of file diff --git a/modules/worker/back/models/specs/locker.spec.js b/modules/worker/back/models/specs/locker.spec.js new file mode 100644 index 0000000000..2418f1169f --- /dev/null +++ b/modules/worker/back/models/specs/locker.spec.js @@ -0,0 +1,56 @@ +const {models} = require('vn-loopback/server/server'); + +fdescribe('locker model ', () => { + const productionBossId = 50; + const hrBuyerId = 124; + const hrId = 37; + const jessicaJonesId = 1110; + const bruceBannerId = 1109; + const lockerMaleId = 1; + const lockerFemaleId = 147; + let ctx; + let options; + let tx; + + beforeEach(async() => { + ctx = { + req: { + accessToken: {userId: hrId}, + headers: {origin: 'http://localhost'} + }, + }; + options = {transaction: tx}; + tx = await models.Locker.beginTransaction({}); + options.transaction = tx; + }); + + afterEach(async() => { + await tx.rollback(); + }); + + it('should allocate a locker', async() => { + ctx.req.accessToken.userId = productionBossId; + + const locker = await models.Locker.findById(lockerMaleId, null, options); + await locker.updateAttributes({workerFk: bruceBannerId}, options); + + expect(locker.workerFk).toEqual(bruceBannerId); + }); + + it('should take away a locker', async() => { + ctx.req.accessToken.userId = hrBuyerId; + const locker = await models.Locker.findById(lockerFemaleId, null, options); + await locker.updateAttributes({workerFk: null}, options); + + expect(locker.workerFk).toEqual(null); + }); + + it('should change a locker', async() => { + const locker = await models.Locker.findById(148, null, options); + await locker.updateAttributes({workerFk: jessicaJonesId}, options); + const oldLocker = await models.Locker.findById(lockerFemaleId, null, options); + + expect(locker.workerFk).toEqual(jessicaJonesId); + expect(oldLocker.workerFk).toEqual(null); + }); +}); -- 2.40.1 From 1f393300412cc08335c8fbe522fec235d3a0dc34 Mon Sep 17 00:00:00 2001 From: jorgep Date: Mon, 13 May 2024 14:00:19 +0200 Subject: [PATCH 26/26] fix: refs #5919 drop focus --- modules/worker/back/models/specs/locker.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/worker/back/models/specs/locker.spec.js b/modules/worker/back/models/specs/locker.spec.js index 2418f1169f..32abb830e6 100644 --- a/modules/worker/back/models/specs/locker.spec.js +++ b/modules/worker/back/models/specs/locker.spec.js @@ -1,6 +1,6 @@ const {models} = require('vn-loopback/server/server'); -fdescribe('locker model ', () => { +describe('locker model ', () => { const productionBossId = 50; const hrBuyerId = 124; const hrId = 37; -- 2.40.1