#5666 - Loggable to mixin #1826

Merged
alexm merged 29 commits from 5666-loggable_to_mixin into dev 2024-01-04 09:21:57 +00:00
4 changed files with 15 additions and 7 deletions
Showing only changes of commit 035b31d878 - Show all commits

View File

@ -23,7 +23,7 @@ export function directive($translate, $window) {
let rule = $attrs.rule.split('.');
let modelName = rule.shift();
let fieldName = rule.shift();
let modelAlias = $attrs.ruleAlias;
jsegarra marked this conversation as resolved Outdated

He añadido este attrs para que desde las rutas de role/:id/basic-data y create se puedan cargar los datos entrantes del registro

He añadido este attrs para que desde las rutas de role/:id/basic-data y create se puedan cargar los datos entrantes del registro
Outdated
Review

No es necesario modificar rule, hay que usar rule="VnRule.[propiedad]" para que aplique las reglas de validación del modelo VnRole

No es necesario modificar rule, hay que usar `rule="VnRule.[propiedad]"` para que aplique las reglas de validación del modelo `VnRole`
let split = $attrs.ngModel.split('.');
if (!fieldName) fieldName = split.pop() || null;
if (!modelName) modelName = firstUpper(split.pop() || '');
@ -31,8 +31,12 @@ export function directive($translate, $window) {
if (!modelName || !fieldName)
throw new Error(`rule: Cannot retrieve model or field attribute`);
let modelValidations = vnValidations[modelName];
if (!modelValidations)
modelValidations = vnValidations[modelAlias];
if (!modelValidations)
throw new Error(`rule: Model '${modelName}' doesn't exist`);

View File

@ -7,6 +7,7 @@
<form
name="form"
ng-submit="watcher.submit()"
class="vn-w-md">
<vn-card class="vn-pa-lg">
<vn-vertical>
@ -14,12 +15,15 @@
label="Name"
ng-model="$ctrl.role.name"
rule
rule-alias="VnRole"
vn-focus>
</vn-textfield>
<vn-textfield
label="Description"
ng-model="$ctrl.role.description"
rule>
label="Description"
ng-model="$ctrl.role.description"
rule
rule-alias="VnRole"
>
</vn-textfield>
</vn-vertical>
</vn-card>

View File

@ -13,13 +13,13 @@
<vn-vertical>
<vn-textfield
label="Name"
ng-model="$ctrl.role.name"
ng-model="$ctrl.VnRole.name"
rule
vn-focus>
</vn-textfield>
<vn-textfield
label="Description"
ng-model="$ctrl.role.description"
ng-model="$ctrl.VnRole.description"
jsegarra marked this conversation as resolved Outdated
Outdated
Review

En lugar de modificar la directiva rule, hay que utilizar rule="VnRole.[propiedad]" para que aplique las reglas del modelo VnRole

En lugar de modificar la directiva rule, hay que utilizar `rule="VnRole.[propiedad]"` para que aplique las reglas del modelo VnRole
rule>
</vn-textfield>
</vn-vertical>

View File

@ -24,4 +24,4 @@
on-accept="$ctrl.onDelete()"
question="Are you sure you want to continue?"
message="Role will be removed">
</vn-confirm>
</vn-confirm>