verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

#6276 createNewWarehouse methods migrated from silex to salix #1850

Merged
jorgep merged 158 commits from 6276-createNewWarehouse into dev 2024-03-06 11:32:11 +00:00
Conversation 4 Commits 158 Files Changed 59 +17 -19
9 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2a6abffef9 - Show all commits

3
back/methods/collection/assignCollection.js
View File

@ -16,7 +16,6 @@ module.exports = Self => {
Self.assignCollection = async(ctx, options) => { Self.assignCollection = async(ctx, options) => {
const userId = ctx.req.accessToken.userId; const userId = ctx.req.accessToken.userId;
const myOptions = {userId}; const myOptions = {userId};
const $t = ctx.req.__;
if (typeof options == 'object') if (typeof options == 'object')
Object.assign(myOptions, options); Object.assign(myOptions, options);
@ -26,7 +25,7 @@ module.exports = Self => {
const [assignedCollection] = await Self.rawSql('SELECT @vCollectionFk'); const [assignedCollection] = await Self.rawSql('SELECT @vCollectionFk');
const {'@vCollectionFk': collectionFk} = assignedCollection; const {'@vCollectionFk': collectionFk} = assignedCollection;
if (!collectionFk) throw new UserError($t('There are not picking tickets')); if (!collectionFk) throw new UserError('There are not picking tickets');
await Self.rawSql('CALL vn.collection_printSticker(?, NULL)', [collectionFk], myOptions); await Self.rawSql('CALL vn.collection_printSticker(?, NULL)', [collectionFk], myOptions);
jorgep marked this conversation as resolved Outdated
alexm commented 2024-01-30 07:03:13 +00:00
Outdated
Review
Copy Link

No hace falta usar $t, UserError traduce por defecto.

No hace falta usar $t, UserError traduce por defecto.
return collectionFk; return collectionFk;

6
back/methods/mobile-app-version-control/getVersion.js
View File

@ -29,9 +29,9 @@ module.exports = Self => {
let fields = ['id', 'appName']; let fields = ['id', 'appName'];
if (workerFk) if (workerFk)
jorgep marked this conversation as resolved
alexm commented 2024-01-30 07:10:10 +00:00
Review
Copy Link

Javascript tiene una forma muy sencilla de 'fusionar' arrays
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat

Javascript tiene una forma muy sencilla de 'fusionar' arrays https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat
fields = [...fields, ...['isVersionBetaCritical', 'versionBeta', 'urlBeta']]; fields = fields.concat(['isVersionBetaCritical', 'versionBeta', 'urlBeta']);
else else
fields = [...fields, ...['isVersionCritical', 'version', 'urlProduction']]; fields = fields.concat(['isVersionCritical', 'version', 'urlProduction']);
const filter = { const filter = {
where: { where: {
@ -40,6 +40,6 @@ module.exports = Self => {
fields, fields,
}; };
return await Self.findOne(filter); return Self.findOne(filter);
jorgep marked this conversation as resolved Outdated
alexm commented 2024-01-30 07:13:13 +00:00
Outdated
Review
Copy Link

en un return no hace falta poner 'await'

Bing:

En JavaScript, la mayoría de las veces, no hay diferencia observable entre return await myFunction() y return myFunction()12. Ambas versiones tienen el mismo comportamiento observable.
en un return no hace falta poner 'await' Bing: ``` En JavaScript, la mayoría de las veces, no hay diferencia observable entre return await myFunction() y return myFunction()12. Ambas versiones tienen el mismo comportamiento observable. ```
}; };
}; };

1
modules/item/back/methods/item/card.js
View File

@ -36,7 +36,6 @@ module.exports = Self => {
fields: ['code'], fields: ['code'],
where: { where: {
jorgep marked this conversation as resolved Outdated
jgallego commented 2024-02-17 07:07:50 +00:00
Outdated
Review
Copy Link

quitar esta llamada, dentro de item_getInfo ya se llama a barcodeToItem por tanto itemInfo ya contiene el id que se busca

quitar esta llamada, dentro de item_getInfo ya se llama a barcodeToItem por tanto itemInfo ya contiene el id que se busca
jorgep commented 2024-02-19 10:58:47 +00:00
Outdated
Review
Copy Link

@sergiodt es correcto o quieres los barcodes tambien?

@sergiodt es correcto o quieres los barcodes tambien?
itemFk: realIdItem itemFk: realIdItem
} }
jorgep marked this conversation as resolved Outdated
jgallego commented 2024-01-29 08:10:15 +00:00
Outdated
Review
Copy Link

quitar salto

quitar salto
}); });

13
modules/ticket/back/methods/ticket/specs/setDeleted.spec.js
View File

@ -50,14 +50,17 @@ describe('ticket setDeleted()', () => {
return value; return value;
}; };
const ticketId = 23; const ticketId = 23;
const [sectorCollectionBefore] = await models.Ticket.rawSql(
await models.Ticket.setDeleted(ctx, ticketId, options);
const [sectorCollection] = await models.Ticket.rawSql(
`SELECT COUNT(*) numberRows `SELECT COUNT(*) numberRows
FROM vn.sectorCollection`, [], options); FROM vn.sectorCollection`, [], options);
expect(sectorCollection.numberRows).toEqual(1); await models.Ticket.setDeleted(ctx, ticketId, options);
const [sectorCollectionAfter] = await models.Ticket.rawSql(
`SELECT COUNT(*) numberRows
jorgep marked this conversation as resolved Outdated
jgallego commented 2024-01-29 08:24:44 +00:00
Outdated
Review
Copy Link

ejecuta antes de borrar SELECT COUNT(*) numberRows
FROM vn.sectorCollection`, [], options);
FROM vn.sectorCollection
y así quitas el uno y el test lo haces dinamico

ejecuta antes de borrar SELECT COUNT(*) numberRows FROM vn.sectorCollection`, [], options); FROM vn.sectorCollection y así quitas el uno y el test lo haces dinamico
FROM vn.sectorCollection`, [], options);
expect(sectorCollectionAfter.numberRows).toEqual(sectorCollectionBefore.numberRows - 1);
await tx.rollback(); await tx.rollback();
} catch (e) { } catch (e) {

3
modules/ticket/back/models/expeditionPallet.json
View File

@ -12,9 +12,6 @@
"id": true, "id": true,
"description": "Identifier" "description": "Identifier"
}, },
"truckFk": {
"type": "number"
},
"built": { "built": {
jorgep marked this conversation as resolved
jgallego commented 2024-01-29 08:26:00 +00:00
Review
Copy Link

al poner la relacion este bloque lo puedes quitar

al poner la relacion este bloque lo puedes quitar
"type": "date" "type": "date"
}, },