verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 64 Releases Wiki Activity

#4466 InvoiceIn Rectification #1902

Merged
jorgep merged 20 commits from 4466-invoiceInRectificated into dev 2024-02-06 07:49:20 +00:00
Conversation 0 Commits 20 Files Changed 13 +4 -14
2 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 05478b43f2 - Show all commits

4
modules/invoiceIn/back/methods/invoice-in/clone.js
View File

@ -110,9 +110,7 @@ module.exports = Self => {
foreignValue: dueDated.foreignValue, foreignValue: dueDated.foreignValue,
}, myOptions)); }, myOptions));
} }
} } else {
if (isRectification) {
for (let intrastat of invoiceInIntrastat) { for (let intrastat of invoiceInIntrastat) {
promises.push(models.InvoiceInIntrastat.create({ promises.push(models.InvoiceInIntrastat.create({
jorgep marked this conversation as resolved
alexm commented 2024-02-05 07:30:17 +00:00
Review
Copy Link

En este cas faria una if else

En este cas faria una if else
invoiceInFk: clone.id, invoiceInFk: clone.id,

12
modules/ticket/back/methods/sale/specs/clone.spec.js
View File

@ -70,19 +70,11 @@ describe('Ticket cloning - clone function', () => {
it('should create a ticket without sales', async() => { it('should create a ticket without sales', async() => {
const servicesIds = [4]; const servicesIds = [4];
const tx = await models.Sale.beginTransaction({});
const options = {transaction: tx}; const tickets = await models.Sale.clone(ctx, null, servicesIds, false, false, options);
try {
const tickets = await models.Sale.clone(ctx, null, servicesIds, false, options);
const refundedTicket = await getTicketRefund(tickets[0].id, options); const refundedTicket = await getTicketRefund(tickets[0].id, options);
expect(refundedTicket).toBeDefined(); expect(refundedTicket).toBeDefined();
await tx.rollback();
} catch (e) {
await tx.rollback();
throw e;
}
}); });
}); });