verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 66 Releases Wiki Activity

#6321 - Negative tickets #1945

Merged
jsegarra merged 146 commits from 6321_negative_tickets into dev 2025-02-11 08:45:33 +00:00
Conversation 0 Commits 146 Files Changed 27 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9626b6c0ff - Show all commits

6
modules/ticket/back/methods/ticket/itemLackDetail.js
View File

@ -53,8 +53,8 @@ module.exports = Self => {
s.quantity, s.quantity,
ag.name, ag.name,
ag.id agencyFk, ag.id agencyFk,
jsegarra marked this conversation as resolved Outdated
jgallego commented 2025-01-31 14:30:24 +00:00
Outdated
Review
Copy Link

es una chorrada pero comovas a cambiar cosas, no solemos poner los AS en los select

es una chorrada pero comovas a cambiar cosas, no solemos poner los AS en los select
IF(ISNULL(tls.alertLevel),0,tls.alertLevel) alertLevel, tls.alertLevel alertLevel,
jsegarra marked this conversation as resolved Outdated
jgallego commented 2025-02-06 11:59:13 +00:00
Outdated
Review
Copy Link

tls.alertLevel

tls.alertLevel
IF(ISNULL(st.name),'Libre',st.name) stateName, st.name stateName,
s.id saleFk, s.id saleFk,
s.itemFk, s.itemFk,
s.price price, s.price price,
@ -68,7 +68,7 @@ module.exports = Self => {
DATE_FORMAT(IF(HOUR(t.shipped), t.shipped, IF(zc.hour, zc.hour, z.hour)),'%H:%i') minTimed, DATE_FORMAT(IF(HOUR(t.shipped), t.shipped, IF(zc.hour, zc.hour, z.hour)),'%H:%i') minTimed,
FALSE isBasket, FALSE isBasket,
substitution.hasObservation, substitution.hasObservation,
d.code = 'spainTeamVip' hasToIgnore (d.code = 'spainTeamVip') hasToIgnore
jsegarra marked this conversation as resolved Outdated
jgallego commented 2025-02-06 12:00:21 +00:00
Outdated
Review
Copy Link

(d.code = 'spainTeamVip') hasToIgnore

(d.code = 'spainTeamVip') hasToIgnore
FROM sale s FROM sale s
jgallego marked this conversation as resolved
jgallego commented 2025-02-05 06:40:54 +00:00
Review
Copy Link

esto hace que las consultas sean muy lentas, hay que buscar alternativa, busca si encuentras otra consulta similar por la BBDD

esto hace que las consultas sean muy lentas, hay que buscar alternativa, busca si encuentras otra consulta similar por la BBDD
😕 1
jsegarra commented 2025-02-06 11:42:40 +00:00
Review
Copy Link

cambiado

cambiado
LEFT JOIN saleGroupDetail sgd ON sgd.saleFk = s.id LEFT JOIN saleGroupDetail sgd ON sgd.saleFk = s.id
JOIN ticket t ON t.id = s.ticketFk JOIN ticket t ON t.id = s.ticketFk