verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 62 Releases Wiki Activity

#6321 - Negative tickets #1945

Merged
jsegarra merged 146 commits from 6321_negative_tickets into dev 2025-02-11 08:45:33 +00:00
Conversation 0 Commits 146 Files Changed 27 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit cc3f2da639 - Show all commits

8
modules/ticket/back/methods/ticket/itemLackDetail.js
View File

@ -2,11 +2,11 @@ const {ParameterizedSQL} = require('loopback-connector');
module.exports = Self => {
Self.remoteMethod('itemLackDetail', {
description: 'Download a ticket delivery note document',
description: 'Retrieve detail from ticket',
jsegarra marked this conversation as resolved Outdated
jgallego commented 2024-04-02 05:30:15 +00:00
Outdated
Review
Copy Link

esta descripcion corresponde ?

esta descripcion corresponde ?
👎 1
accessType: 'READ',
accepts: [
{
arg: 'id',
arg: 'itemFk',
jsegarra marked this conversation as resolved Outdated
jgallego commented 2024-04-02 05:31:36 +00:00
Outdated
Review
Copy Link

si estamos en la seccion ticket, yo el argumento lo llamaria itemFk, porque a mitad codigo, id puede dar confusion a que es el id de la entidad, en este caso ticket

si estamos en la seccion ticket, yo el argumento lo llamaria itemFk, porque a mitad codigo, id puede dar confusion a que es el id de la entidad, en este caso ticket
👍 1
type: 'number',
description: 'The item id',
},
@ -24,7 +24,7 @@ module.exports = Self => {
},
});
Self.itemLackDetail = async(id, options) => {
Self.itemLackDetail = async(itemFk, options) => {
const conn = Self.dataSource.connector;
const myOptions = {};
@ -71,7 +71,7 @@ module.exports = Self => {
AND t.landed >= util.VN_CURDATE()
jsegarra marked this conversation as resolved Outdated
jgallego commented 2025-02-06 12:00:21 +00:00
Outdated
Review
Copy Link

(d.code = 'spainTeamVip') hasToIgnore

(d.code = 'spainTeamVip') hasToIgnore
AND t.landed < util.VN_CURDATE() + INTERVAL ? + 1 DAY
jgallego marked this conversation as resolved
jgallego commented 2025-02-05 06:40:54 +00:00
Review
Copy Link

esto hace que las consultas sean muy lentas, hay que buscar alternativa, busca si encuentras otra consulta similar por la BBDD

esto hace que las consultas sean muy lentas, hay que buscar alternativa, busca si encuentras otra consulta similar por la BBDD
😕 1
jsegarra commented 2025-02-06 11:42:40 +00:00
Review
Copy Link

cambiado

cambiado
`,
[id, 2]);
[itemFk, 2]);
const sql = ParameterizedSQL.join([stmt], ';');
const result = await conn.executeStmt(sql, myOptions);