verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

#6321 - Negative tickets #1945

Open
jsegarra wants to merge 97 commits from 6321_negative_tickets into dev
pull from: 6321_negative_tickets
merge into: verdnatura:dev
Conversation 0 Commits 97 Files Changed 27 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit cc3f2da639 - Show all commits

8
modules/ticket/back/methods/ticket/itemLackDetail.js
View File

@ -2,11 +2,11 @@ const {ParameterizedSQL} = require('loopback-connector');
module.exports = Self => { module.exports = Self => {
Self.remoteMethod('itemLackDetail', { Self.remoteMethod('itemLackDetail', {
description: 'Download a ticket delivery note document', description: 'Retrieve detail from ticket',
jsegarra marked this conversation as resolved Outdated
jgallego commented 2024-04-02 05:30:15 +00:00
Outdated
Review
Copy Link

esta descripcion corresponde ?

esta descripcion corresponde ?
👎 1
accessType: 'READ', accessType: 'READ',
accepts: [ accepts: [
{ {
arg: 'id', arg: 'itemFk',
jsegarra marked this conversation as resolved Outdated
jgallego commented 2024-04-02 05:31:36 +00:00
Outdated
Review
Copy Link

si estamos en la seccion ticket, yo el argumento lo llamaria itemFk, porque a mitad codigo, id puede dar confusion a que es el id de la entidad, en este caso ticket

si estamos en la seccion ticket, yo el argumento lo llamaria itemFk, porque a mitad codigo, id puede dar confusion a que es el id de la entidad, en este caso ticket
👍 1
type: 'number', type: 'number',
description: 'The item id', description: 'The item id',
}, },
@ -24,7 +24,7 @@ module.exports = Self => {
}, },
}); });
Self.itemLackDetail = async(id, options) => { Self.itemLackDetail = async(itemFk, options) => {
const conn = Self.dataSource.connector; const conn = Self.dataSource.connector;
const myOptions = {}; const myOptions = {};
@ -71,7 +71,7 @@ module.exports = Self => {
AND t.landed >= util.VN_CURDATE() AND t.landed >= util.VN_CURDATE()
AND t.landed < util.VN_CURDATE() + INTERVAL ? + 1 DAY AND t.landed < util.VN_CURDATE() + INTERVAL ? + 1 DAY
`, `,
[id, 2]); [itemFk, 2]);
const sql = ParameterizedSQL.join([stmt], ';'); const sql = ParameterizedSQL.join([stmt], ';');
const result = await conn.executeStmt(sql, myOptions); const result = await conn.executeStmt(sql, myOptions);