6745-2404_testToMaster #1950

Merged
alexm merged 191 commits from 6745-2404_testToMaster into master 2024-01-25 07:39:13 +00:00
2 changed files with 2 additions and 7 deletions
Showing only changes of commit e9773b3885 - Show all commits

View File

@ -136,8 +136,6 @@ module.exports = Self => {
code: 'DELIVERED'
}
}, options);
if (!deliveryState)
throw new UserError('The DELIVERED state does not exist');
await models.Ticket.state(ctx, {
ticketFk: ticketId,

View File

@ -58,13 +58,10 @@ module.exports = Self => {
fields: ['stateFk']
}, myOptions);
const oldStateAllowed = ticketState ?
await models.State.isEditable(ctx, ticketState.stateFk, myOptions) :
false;
const oldStateAllowed = ticketState && await models.State.isEditable(ctx, ticketState.stateFk, myOptions);
const newStateAllowed = await models.State.isEditable(ctx, params.stateFk, myOptions);
if (!((!ticketState || oldStateAllowed == true) && newStateAllowed == true))
if ((ticketState && !oldStateAllowed) || !newStateAllowed)
throw new UserError(`You don't have enough privileges`, 'ACCESS_DENIED');
await Self.rawSql(`CALL vn.ticket_setState(?, ?)`, [params.ticketFk, params.code], myOptions);