verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

DEP: #7004 - HOTFIX Create new Supplier #2148

Closed
jsegarra wants to merge 9 commits from 7004_hotFix_newSupplier into master
pull from: 7004_hotFix_newSupplier
merge into: verdnatura:master
Conversation 1 Commits 9 Files Changed 8 +232 -233
jsegarra commented 2024-03-07 18:18:28 +00:00
Member
Copy Link
No description provided.
jsegarra added 4 commits 2024-03-08 06:01:13 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
200e15ce74 refs #7004 fix: front
jsegarra added 1 commit 2024-03-08 06:01:40 +00:00
gitea/salix/pipeline/pr-master Build queued... Details
05e3129d34 refs #7004 fix: test
jsegarra requested review from alexm 2024-03-08 07:08:37 +00:00
jsegarra changed title from WIP: #7004 - HOTFIX Create new Supplier to #7004 - HOTFIX Create new Supplier 2024-03-08 07:08:39 +00:00
jsegarra added 1 commit 2024-03-08 07:08:45 +00:00
gitea/salix/pipeline/pr-master This commit looks good Details
3b17a6fe0f Merge branch 'master' into 7004_hotFix_newSupplier
alexm requested changes 2024-03-08 07:15:17 +00:00
modules/supplier/back/methods/supplier/updateFiscalData.js Outdated
@ -87,6 +87,14 @@ module.exports = Self => {
}
}
if (!city) {
alexm commented 2024-03-08 07:13:32 +00:00
Member
Copy Link

Y pq no poner los argumentos como requeridos?

Y pq no poner los argumentos como requeridos?
jsegarra commented 2024-03-08 07:20:19 +00:00
Author
Member
Copy Link

No puedes hacer eso porque la segunda vez que guardas, si esos campos no los has modificado te dará error porque en el body de la request no aparece

No puedes hacer eso porque la segunda vez que guardas, si esos campos no los has modificado te dará error porque en el body de la request no aparece
alexm commented 2024-03-08 07:24:21 +00:00
Member
Copy Link

Entonces con if pasaria lo mismo

Entonces con if pasaria lo mismo
jsegarra commented 2024-03-08 07:49:07 +00:00
Author
Member
Copy Link

He modificado la condición porque lo que no queremos que sea null y antes aceptaba undefined y null.
Ahora es mas restrictivo.

He modificado la condición porque lo que no queremos que sea null y antes aceptaba undefined y null. Ahora es mas restrictivo.
jsegarra changed title from #7004 - HOTFIX Create new Supplier to WIP: #7004 - HOTFIX Create new Supplier 2024-03-08 07:17:26 +00:00
alexm commented 2024-03-08 07:21:55 +00:00
Member
Copy Link

Aparte si el fallo viene de otra tarea veria mas conveniente usar el id de esa tarea en vez de crear una nueva

Aparte si el fallo viene de otra tarea veria mas conveniente usar el id de esa tarea en vez de crear una nueva
jsegarra added 2 commits 2024-03-08 07:46:24 +00:00
jsegarra changed title from WIP: #7004 - HOTFIX Create new Supplier to #7004 - HOTFIX Create new Supplier 2024-03-08 07:48:17 +00:00
jsegarra requested review from alexm 2024-03-08 07:48:19 +00:00
jsegarra added 1 commit 2024-03-08 08:41:56 +00:00
gitea/salix/pipeline/pr-master Build started... Details
e6b2424f3e refs #7004 perf: improve city/nif validation
alexm approved these changes 2024-03-08 08:49:24 +00:00
jsegarra changed title from #7004 - HOTFIX Create new Supplier to DEP: #7004 - HOTFIX Create new Supplier 2024-03-08 09:42:13 +00:00
jsegarra closed this pull request 2024-03-08 09:42:25 +00:00
jgallego requested changes 2024-03-08 09:46:28 +00:00
jgallego left a comment
Owner
Copy Link

pongo validate: false para que puedas solicitar revision de nuevo

pongo validate: false para que puedas solicitar revision de nuevo
Some checks are pending
gitea/salix/pipeline/pr-master Build started...
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2148
No description provided.
Delete Branch "7004_hotFix_newSupplier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?