verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

feat: refs #6610 fixDeleteTickets #2154

Merged
robert merged 6 commits from 6610-hotFixDeleteTicketsWeekly into master 2024-03-11 11:15:05 +00:00
Conversation 0 Commits 6 Files Changed 1 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b1e90fabb2 - Show all commits

10
db/routines/vn/procedures/clean.sql
View File

@ -183,19 +183,19 @@ BEGIN
DELETE FROM travelLog WHERE creationDate < v3Month;
CREATE OR REPLACE TEMPORARY TABLE tTicketDelete
SELECT DISTINCT tl.originFk ticketFk, sub.ticketFk aa
SELECT DISTINCT tl.originFk ticketFk
robert marked this conversation as resolved Outdated
guillermo commented 2024-03-08 11:22:17 +00:00
Outdated
Review
Copy Link

Identación

Identación
FROM ticketLog tl
JOIN (
SELECT MAX(tl.id)ids,tw.ticketFk
SELECT MAX(tl.id)ids, tw.ticketFk
robert marked this conversation as resolved Outdated
guillermo commented 2024-03-08 11:22:26 +00:00
Outdated
Review
Copy Link

Espacio despues de coma: MAX(tl.id)ids, tw.ticketFk

Espacio despues de coma: `MAX(tl.id)ids, tw.ticketFk`
guillermo commented 2024-03-11 11:10:32 +00:00
Outdated
Review
Copy Link

tw.ticketFk no se utiliza

tw.ticketFk no se utiliza
FROM ticket t
JOIN ticketLog tl ON tl.originFk = t.id
LEFT JOIN ticketWeekly tw ON tw.ticketFk =t.id
WHERE t.shipped BETWEEN '2000-01-01' AND '2000-12-31'
WHERE t.shipped BETWEEN '2000-01-01' AND '2000-12-31'
AND t.isDeleted
AND tw.ticketFk IS NULL
GROUP BY t.id
) sub ON sub.ids = tl.id
WHERE tl.creationDate <= util.VN_CURDATE() - INTERVAL 60 DAY;
) sub ON sub.ids = tl.id
robert marked this conversation as resolved Outdated
guillermo commented 2024-03-08 11:25:10 +00:00
Outdated
Review
Copy Link

Espacio al final de la linea

Espacio al final de la linea
WHERE tl.creationDate <= vDateShort;
robert marked this conversation as resolved Outdated
guillermo commented 2024-03-08 11:23:25 +00:00
Outdated
Review
Copy Link

WHERE tl.creationDate <= vDateShort

`WHERE tl.creationDate <= vDateShort`
DELETE t
FROM ticket t