verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#6964 _ itemOlder #2197

Merged
sergiodt merged 26 commits from 6964_itemOlder into dev 2024-04-04 14:18:20 +00:00
Conversation 0 Commits 26 Files Changed 5 +45
2 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 09923d2509 - Show all commits

44
modules/item/back/methods/item-shelving/hasItemOlder.js Normal file
View File

@ -0,0 +1,44 @@
module.exports = Self => {
Self.remoteMethod('hasItemOlder', {
description: 'Get boolean if any item of the shelving has older created in another shelving ',
accessType: 'WRITE',
accepts: [{
arg: 'shelvingFk',
type: 'string',
required: true,
description: 'Shelving code'
},
{
arg: 'parking',
type: 'string',
required: true,
description: 'Parking code'
}],
returns: {
type: 'boolean',
root: true
},
http: {
path: `/hasItemOlder`,
verb: 'GET'
}
});
sergiodt marked this conversation as resolved Outdated
alexm commented 2024-03-27 06:32:29 +00:00
Outdated
Review
Copy Link

He buscat y type int no ho hem gastat mai,
Seria type: 'integer',

He buscat y type int no ho hem gastat mai, Seria `type: 'integer',`
sergiodt commented 2024-03-27 06:50:36 +00:00
Outdated
Review
Copy Link

vaig mesclant llenguatges :-)

vaig mesclant llenguatges :-)
Self.hasItemOlder = async(shelvingFk, parking, options) => {
const result = await Self.rawSql(`
SELECT COUNT(ish.id)
FROM vn.itemShelving ish
JOIN (
SELECT ish.itemFk, created,shelvingFk, p.code
FROM vn.itemShelving ish
JOIN vn.shelving s ON ish.shelvingFk = s.code
JOIN vn.parking p ON p.id = s.parkingFk
WHERE ish.shelvingFk = ?
)sub ON sub.itemFK = ish.itemFk
sergiodt marked this conversation as resolved Outdated
alexm commented 2024-03-25 06:10:53 +00:00
Outdated
Review
Copy Link

Els 3(parking, shelvingFkOut, itemFk) poden ser null a la vega? O faria falta al menys uno?
Per si fera falta ficar un if(!parking && !shelvingFkOut && !itemFk) return throw new UserError(...)

Els 3(parking, shelvingFkOut, itemFk) poden ser null a la vega? O faria falta al menys uno? Per si fera falta ficar un if(!parking && !shelvingFkOut && !itemFk) return throw new UserError(...)
sergiodt commented 2024-03-25 06:55:40 +00:00
Outdated
Review
Copy Link

Posat

Posat
JOIN vn.shelving s ON s.code = ish.shelvingFk
sergiodt marked this conversation as resolved
alexm commented 2024-03-26 07:02:51 +00:00
Review
Copy Link
    const myOptions = {};

    if (typeof options == 'object')
        Object.assign(myOptions, options);
const myOptions = {}; if (typeof options == 'object') Object.assign(myOptions, options);
JOIN vn.parking p ON p.id = s.parkingFk
sergiodt marked this conversation as resolved Outdated
carlosap commented 2024-03-22 15:34:37 +00:00
Outdated
Review
Copy Link

Millor fiquem un alias al cam

Millor fiquem un alias al cam
alexm commented 2024-03-25 12:17:49 +00:00
Review
Copy Link

Faltaria la traduccion

Faltaria la traduccion
sergiodt commented 2024-03-25 15:10:48 +00:00
Review
Copy Link

Afegida

Afegida
WHERE ish.shelvingFk <> ? AND sub.created > ish.created AND p.code <> ?`,
sergiodt marked this conversation as resolved Outdated
carlosap commented 2024-03-22 15:35:10 +00:00
Outdated
Review
Copy Link

Tabulació

Tabulació
[shelvingFk, shelvingFk, parking]);
return result[0]['COUNT(ish.id)'] > 0;
};
};

1
modules/item/back/models/item-shelving.js
View File

@ -2,4 +2,5 @@ module.exports = Self => {
require('../methods/item-shelving/deleteItemShelvings')(Self);
require('../methods/item-shelving/upsertItem')(Self);
require('../methods/item-shelving/getInventory')(Self);
require('../methods/item-shelving/hasItemOlder')(Self);
};