verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 51 Releases Wiki Activity

#6964 _ itemOlder #2197

Merged
sergiodt merged 26 commits from 6964_itemOlder into dev 2024-04-04 14:18:20 +00:00
Conversation 0 Commits 26 Files Changed 5 +14 -12
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 22f78dbb91 - Show all commits

6
modules/item/back/methods/item-shelving/hasItemOlder.js
View File

@ -1,3 +1,4 @@
const UserError = require('vn-loopback/util/user-error');
module.exports = Self => { module.exports = Self => {
Self.remoteMethod('hasItemOlder', { Self.remoteMethod('hasItemOlder', {
description: description:
@ -35,8 +36,9 @@ module.exports = Self => {
}); });
sergiodt marked this conversation as resolved Outdated
alexm commented 2024-03-25 06:10:53 +00:00
Outdated
Review
Copy Link

Els 3(parking, shelvingFkOut, itemFk) poden ser null a la vega? O faria falta al menys uno?
Per si fera falta ficar un if(!parking && !shelvingFkOut && !itemFk) return throw new UserError(...)

Els 3(parking, shelvingFkOut, itemFk) poden ser null a la vega? O faria falta al menys uno? Per si fera falta ficar un if(!parking && !shelvingFkOut && !itemFk) return throw new UserError(...)
sergiodt commented 2024-03-25 06:55:40 +00:00
Outdated
Review
Copy Link

Posat

Posat
Self.hasItemOlder = async(shelvingFkIn, parking, shelvingFkOut, itemFk, options) => { Self.hasItemOlder = async(shelvingFkIn, parking, shelvingFkOut, itemFk, options) => {
sergiodt marked this conversation as resolved
alexm commented 2024-03-26 07:02:51 +00:00
Review
Copy Link
    const myOptions = {};

    if (typeof options == 'object')
        Object.assign(myOptions, options);
const myOptions = {}; if (typeof options == 'object') Object.assign(myOptions, options);
if (!parking && !shelvingFkOut) throw new UserError('Missing data: parking or shelving');
sergiodt marked this conversation as resolved Outdated
carlosap commented 2024-03-22 15:34:37 +00:00
Outdated
Review
Copy Link

Millor fiquem un alias al cam

Millor fiquem un alias al cam
alexm commented 2024-03-25 12:17:49 +00:00
Review
Copy Link

Faltaria la traduccion

Faltaria la traduccion
sergiodt commented 2024-03-25 15:10:48 +00:00
Review
Copy Link

Afegida

Afegida
const result = await Self.rawSql(` const result = await Self.rawSql(`
sergiodt marked this conversation as resolved Outdated
carlosap commented 2024-03-22 15:35:10 +00:00
Outdated
Review
Copy Link

Tabulació

Tabulació
SELECT COUNT(ish.id) SELECT COUNT(ish.id) countItemOlder
FROM vn.itemShelving ish FROM vn.itemShelving ish
JOIN ( JOIN (
SELECT ish.itemFk, created,shelvingFk, p.code SELECT ish.itemFk, created,shelvingFk, p.code
@ -52,6 +54,6 @@ module.exports = Self => {
AND (ish.shelvingFk <> ? OR ? IS NULL) AND (ish.shelvingFk <> ? OR ? IS NULL)
sergiodt marked this conversation as resolved Outdated
alexm commented 2024-03-25 06:11:25 +00:00
Outdated
Review
Copy Link

falta gastar la transaccio (...shelvingFkOut, itemFk, itemFk], options)

falta gastar la transaccio (...shelvingFkOut, itemFk, itemFk], options)
sergiodt commented 2024-03-25 06:55:48 +00:00
Outdated
Review
Copy Link

Llevat options

Llevat options
alexm commented 2024-03-25 07:07:00 +00:00
Outdated
Review
Copy Link

Es ficarlo sino no gastarà la transaccio

Es ficarlo sino no gastarà la transaccio
sergiodt commented 2024-03-25 07:23:38 +00:00
Outdated
Review
Copy Link

L'he posat però no veia que fera falta...

L'he posat però no veia que fera falta...
AND (ish.itemFk <> ? OR ? IS NULL)`, AND (ish.itemFk <> ? OR ? IS NULL)`,
sergiodt marked this conversation as resolved Outdated
alexm commented 2024-03-25 06:06:43 +00:00
Outdated
Review
Copy Link

Si li poses el alias aci hi ha que canviarlo

Si li poses el alias aci hi ha que canviarlo
[shelvingFkIn, parking, parking, shelvingFkOut, shelvingFkOut, itemFk, itemFk]); [shelvingFkIn, parking, parking, shelvingFkOut, shelvingFkOut, itemFk, itemFk]);
sergiodt marked this conversation as resolved Outdated
alexm commented 2024-03-25 07:07:09 +00:00
Outdated
Review
Copy Link

Aci

Aci
alexm commented 2024-03-26 07:03:01 +00:00
Outdated
Review
Copy Link

myOptions

myOptions
return result[0]['COUNT(ish.id)'] > 0; return result[0]['countItemOlder'] > 0;
}; };
}; };