db/.editorconfig

@@ -0,0 +1,13 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# http://editorconfig.org
+
+root = true
+
+[*]
+indent_style = tab
+indent_size = 4
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true

db/routines/hedera/procedures/order_requestRecalc.sql

@@ -10,6 +10,7 @@ proc: BEGIN
 		LEAVE proc;
 	END IF;
 
-	INSERT INTO orderRecalc SET orderFk = vSelf;
+	-- #4409 Deprecated by MyCDC
+	-- INSERT INTO orderRecalc SET orderFk = vSelf;
 END$$
 DELIMITER ;

db/routines/hedera/triggers/orderRow_afterDelete.sql

@@ -3,7 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `hedera`.`orderRow_afterDel
 	AFTER DELETE ON `orderRow`
 	FOR EACH ROW
 BEGIN
-	CALL stock.log_add('orderRow', NULL, OLD.id);
 	CALL order_requestRecalc(OLD.orderFk);
 END$$
 DELIMITER ;

db/routines/hedera/triggers/orderRow_afterInsert.sql

@@ -3,7 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `hedera`.`orderRow_afterIns
 	AFTER INSERT ON `orderRow`
 	FOR EACH ROW
 BEGIN
-	CALL stock.log_add('orderRow', NEW.id, NULL);
 	CALL order_requestRecalc(NEW.orderFk);
 END$$
 DELIMITER ;

db/routines/hedera/triggers/orderRow_afterUpdate.sql

@@ -3,7 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `hedera`.`orderRow_afterUpd
 	AFTER UPDATE ON `orderRow`
 	FOR EACH ROW
 BEGIN
-	CALL stock.log_add('orderRow', NEW.id, OLD.id);
 	CALL order_requestRecalc(OLD.orderFk);
 	CALL order_requestRecalc(NEW.orderFk);
 END$$

db/routines/hedera/triggers/order_afterUpdate.sql

@@ -3,8 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `hedera`.`order_afterUpdate
 	AFTER UPDATE ON `order`
 	FOR EACH ROW
 BEGIN
-	CALL stock.log_add('order', NEW.id, OLD.id);
-    
 	IF !(OLD.address_id <=> NEW.address_id)
 	OR !(OLD.company_id <=> NEW.company_id)
 	OR !(OLD.customer_id <=> NEW.customer_id) THEN

db/routines/stock/procedures/log_add.sql

@@ -1,21 +0,0 @@
-DELIMITER $$
-CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `stock`.`log_add`(IN `vTableName` VARCHAR(255), IN `vNewId` VARCHAR(255), IN `vOldId` VARCHAR(255))
-proc: BEGIN
-	-- XXX: Disabled while testing
-	LEAVE proc;
-
-	IF vOldId IS NOT NULL AND !(vOldId <=> vNewId) THEN
-		INSERT IGNORE INTO `log` SET
-			tableName = vTableName,
-			tableId = vOldId,
-			operation = 'delete';
-	END IF;
-
-	IF vNewId IS NOT NULL THEN
-		INSERT IGNORE INTO `log` SET
-			tableName = vTableName,
-			tableId = vNewId,
-			operation = 'insert';
-	END IF;
-END$$
-DELIMITER ;

db/routines/vn/procedures/ticket_requestRecalc.sql

@@ -10,6 +10,7 @@ proc: BEGIN
 		LEAVE proc;
 	END IF;
 
-	INSERT INTO ticketRecalc SET ticketFk = vSelf;
+	-- #4409 Deprecated by MyCDC
+	-- INSERT INTO ticketRecalc SET ticketFk = vSelf;
 END$$
 DELIMITER ;

db/routines/vn/triggers/buy_afterDelete.sql

@@ -3,19 +3,14 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`buy_afterDelete`
 	AFTER DELETE ON `buy`
 	FOR EACH ROW
 trig: BEGIN
-	DECLARE vValues VARCHAR(255);
-
 	IF @isModeInventory OR @isTriggerDisabled THEN
 		LEAVE trig;
 	END IF;
 
-	CALL stock.log_add('buy', NULL, OLD.id);
-
 	INSERT INTO entryLog
 		SET `action` = 'delete',
 			`changedModel` = 'Buy',
 			`changedModelId` = OLD.id,
 			`userFk` = account.myUser_getId();
-
 END$$
 DELIMITER ;

db/routines/vn/triggers/buy_afterInsert.sql

@@ -7,8 +7,6 @@ trig: BEGIN
 		LEAVE trig;
 	END IF;
 
-	CALL stock.log_add('buy', NEW.id, NULL);
-
 	CALL buy_afterUpsert(NEW.id);
 END$$
 DELIMITER ;

db/routines/vn/triggers/buy_afterUpdate.sql

@@ -12,14 +12,6 @@ trig: BEGIN
 		LEAVE trig;
 	END IF;
 
-	IF !(NEW.id <=> OLD.id)
-	OR !(NEW.entryFk <=> OLD.entryFk)
-	OR !(NEW.itemFk <=> OLD.itemFk)
-	OR !(NEW.quantity <=> OLD.quantity)
-	OR !(NEW.created <=> OLD.created) THEN
-		CALL stock.log_add('buy', NEW.id, OLD.id);
-	END IF;
-
 	CALL buy_afterUpsert(NEW.id);
 
 	SELECT w.isBuyerToBeEmailed, t.landed

db/routines/vn/triggers/entry_afterUpdate.sql

@@ -3,18 +3,11 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`entry_afterUpdate`
 	AFTER UPDATE ON `entry`
 	FOR EACH ROW
 BEGIN
-	IF NOT(NEW.id <=> OLD.id)
-	OR NOT(NEW.travelFk <=> OLD.travelFk)
-	OR NOT(NEW.isRaid <=> OLD.isRaid) THEN
-		CALL stock.log_add('entry', NEW.id, OLD.id);
-	END IF;
-
 	IF NOT (NEW.travelFk <=> OLD.travelFk) THEN
 		CALL travel_requestRecalc(OLD.travelFk);
 		CALL travel_requestRecalc(NEW.travelFk);
 	END IF;
 
-	
 	IF NOT (NEW.travelFk <=> OLD.travelFk) THEN
 		CREATE OR REPLACE TEMPORARY TABLE tmp.buysToCheck
 			SELECT b.id

db/routines/vn/triggers/sale_afterDelete.sql

@@ -12,7 +12,6 @@ BEGIN
 			`changedModelId` = OLD.id,
 			`userFk` = account.myUser_getId();
 
-	CALL stock.log_add('sale', NULL, OLD.id);
 	CALL ticket_requestRecalc(OLD.ticketFk);
 
 	SELECT account.myUser_getName() INTO vUserRole;

db/routines/vn/triggers/sale_afterInsert.sql

@@ -7,7 +7,6 @@ BEGIN
 		CALL util.throw('Cannot insert a service item into a ticket');
 	END IF;
 
-	CALL stock.log_add('sale', NEW.id, NULL);
 	CALL ticket_requestRecalc(NEW.ticketFk);
 
 	IF NEW.quantity > 0 THEN

db/routines/vn/triggers/sale_afterUpdate.sql

@@ -6,15 +6,6 @@ BEGIN
 	DECLARE vIsToSendMail BOOL;
 	DECLARE vUserRole VARCHAR(255);
 
-	IF !(NEW.id <=> OLD.id)
-	OR !(NEW.ticketFk <=> OLD.ticketFk)
-	OR !(NEW.itemFk <=> OLD.itemFk)
-	OR !(NEW.quantity <=> OLD.quantity)
-	OR !(NEW.created <=> OLD.created)
-	OR !(NEW.isPicked <=> OLD.isPicked) THEN
-		CALL stock.log_add('sale', NEW.id, OLD.id);
-	END IF;
-
 	IF !(NEW.price <=> OLD.price)
 	OR !(NEW.ticketFk <=> OLD.ticketFk)
 	OR !(NEW.itemFk <=> OLD.itemFk)

db/routines/vn/triggers/ticket_afterUpdate.sql

@@ -3,13 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`ticket_afterUpdate`
 	AFTER UPDATE ON `ticket`
 	FOR EACH ROW
 BEGIN
-
-	IF !(NEW.id <=> OLD.id)
-		OR !(NEW.warehouseFk <=> OLD.warehouseFk)
-		OR !(NEW.shipped <=> OLD.shipped) THEN
-			CALL stock.log_add('ticket', NEW.id, OLD.id);
-	END IF;
-
 	IF !(NEW.clientFk <=> OLD.clientFk)
 		OR !(NEW.addressFk <=> OLD.addressFk)
 		OR !(NEW.companyFk <=> OLD.companyFk) THEN

db/routines/vn/triggers/travel_afterUpdate.sql

@@ -3,8 +3,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` TRIGGER `vn`.`travel_afterUpdate`
 	AFTER UPDATE ON `travel`
 	FOR EACH ROW
 BEGIN
-	CALL stock.log_add('travel', NEW.id, OLD.id);
-
 	IF NOT(NEW.shipped <=> OLD.shipped) THEN
 		UPDATE entry
 			SET commission = entry_getCommission(travelFk, currencyFk,supplierFk)