7253-devToTest_2418 #2350
|
@ -29,6 +29,7 @@ module.exports = Self => {
|
||||||
});
|
});
|
||||||
|
|
||||||
Self.getSales = async(ctx, collectionOrTicketFk, print, source, options) => {
|
Self.getSales = async(ctx, collectionOrTicketFk, print, source, options) => {
|
||||||
|
const models = Self.app.models;
|
||||||
const userId = ctx.req.accessToken.userId;
|
const userId = ctx.req.accessToken.userId;
|
||||||
const myOptions = {userId};
|
const myOptions = {userId};
|
||||||
const $t = ctx.req.__;
|
const $t = ctx.req.__;
|
||||||
|
|
|
@ -19,12 +19,12 @@ module.exports = Self => {
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
Self.getUrl = async(appName = 'salix') => {
|
Self.getUrl = async(appName = 'salix') => {
|
||||||
const {url} = await Self.app.models.Url.findOne({
|
const url = await Self.app.models.Url.findOne({
|
||||||
where: {
|
where: {
|
||||||
appName,
|
appName,
|
||||||
environment: process.env.NODE_ENV || 'development'
|
environment: process.env.NODE_ENV || 'development'
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
return url;
|
return url?.url;
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|
|
@ -1880,7 +1880,7 @@ INSERT INTO `vn`.`claimRatio`(`clientFk`, `yearSale`, `claimAmount`, `claimingRa
|
||||||
|
|
||||||
INSERT INTO `vn`.`claimLog` (`originFk`, userFk, `action`, changedModel, oldInstance, newInstance, changedModelId, `description`)
|
INSERT INTO `vn`.`claimLog` (`originFk`, userFk, `action`, changedModel, oldInstance, newInstance, changedModelId, `description`)
|
||||||
VALUES
|
VALUES
|
||||||
(1, 18, 'update', 'Claim', '{"hasToPickUp":false}', '{"hasToPickUp":true}', 1, NULL),
|
(1, 18, 'update', 'Claim', '{"pickup":null}', '{"pickup":"agency"}', 1, NULL),
|
||||||
(1, 18, 'update', 'ClaimObservation', '{}', '{"claimFk":1,"text":"Waiting for customer"}', 1, NULL),
|
(1, 18, 'update', 'ClaimObservation', '{}', '{"claimFk":1,"text":"Waiting for customer"}', 1, NULL),
|
||||||
(1, 18, 'insert', 'ClaimBeginning', '{}', '{"claimFk":1,"saleFk":1,"quantity":10}', 1, NULL),
|
(1, 18, 'insert', 'ClaimBeginning', '{}', '{"claimFk":1,"saleFk":1,"quantity":10}', 1, NULL),
|
||||||
(1, 18, 'insert', 'ClaimDms', '{}', '{"claimFk":1,"dmsFk":1}', 1, NULL);
|
(1, 18, 'insert', 'ClaimDms', '{}', '{"claimFk":1,"dmsFk":1}', 1, NULL);
|
||||||
|
@ -2916,7 +2916,8 @@ INSERT INTO `salix`.`url` (`appName`, `environment`, `url`)
|
||||||
VALUES
|
VALUES
|
||||||
('lilium', 'development', 'http://localhost:9000/#/'),
|
('lilium', 'development', 'http://localhost:9000/#/'),
|
||||||
('hedera', 'development', 'http://localhost:9090/'),
|
('hedera', 'development', 'http://localhost:9090/'),
|
||||||
('salix', 'development', 'http://localhost:5000/#!/');
|
('salix', 'development', 'http://localhost:5000/#!/'),
|
||||||
|
('docuware', 'development', 'http://docuware');
|
||||||
|
|
||||||
INSERT INTO `vn`.`report` (`id`, `name`, `paperSizeFk`, `method`)
|
INSERT INTO `vn`.`report` (`id`, `name`, `paperSizeFk`, `method`)
|
||||||
VALUES
|
VALUES
|
||||||
|
|
|
@ -21,7 +21,6 @@ BEGIN
|
||||||
SELECT barcodeToItem(vBarcode) INTO vItemFk;
|
SELECT barcodeToItem(vBarcode) INTO vItemFk;
|
||||||
|
|
||||||
SET vPacking = COALESCE(vPacking, GREATEST(vn.itemPacking(vBarcode,vWarehouseFk), 1));
|
SET vPacking = COALESCE(vPacking, GREATEST(vn.itemPacking(vBarcode,vWarehouseFk), 1));
|
||||||
|
|
||||||
SET vQuantity = vQuantity * vPacking;
|
SET vQuantity = vQuantity * vPacking;
|
||||||
|
|
||||||
IF (SELECT COUNT(*) FROM shelving WHERE code = vShelvingFk COLLATE utf8_unicode_ci) = 0 THEN
|
IF (SELECT COUNT(*) FROM shelving WHERE code = vShelvingFk COLLATE utf8_unicode_ci) = 0 THEN
|
||||||
|
|
|
@ -0,0 +1,20 @@
|
||||||
|
CREATE OR REPLACE TEMPORARY TABLE tmp.claimsWithHasToPickUp
|
||||||
|
SELECT id
|
||||||
|
FROM vn.claim
|
||||||
|
WHERE hasToPickUp;
|
||||||
|
|
||||||
|
ALTER TABLE vn.claim CHANGE hasToPickUp pickup ENUM('agency', 'delivery') DEFAULT NULL;
|
||||||
|
|
||||||
|
UPDATE vn.claim c
|
||||||
|
JOIN tmp.claimsWithHasToPickUp tmp ON tmp.id = c.id
|
||||||
|
SET c.pickup = 'delivery';
|
||||||
|
|
||||||
|
-- Solved bug empty value
|
||||||
|
UPDATE vn.claim
|
||||||
|
SET pickup = NULL
|
||||||
|
WHERE pickup = '';
|
||||||
|
|
||||||
|
DROP TEMPORARY TABLE tmp.claimsWithHasToPickUp;
|
||||||
|
|
||||||
|
INSERT INTO salix.ACL (model,property,accessType,principalId)
|
||||||
|
VALUES ('Application','getEnumValues','*','employee');
|
|
@ -762,7 +762,6 @@ export default {
|
||||||
claimBasicData: {
|
claimBasicData: {
|
||||||
claimState: 'vn-claim-basic-data vn-autocomplete[ng-model="$ctrl.claim.claimStateFk"]',
|
claimState: 'vn-claim-basic-data vn-autocomplete[ng-model="$ctrl.claim.claimStateFk"]',
|
||||||
packages: 'vn-input-number[ng-model="$ctrl.claim.packages"]',
|
packages: 'vn-input-number[ng-model="$ctrl.claim.packages"]',
|
||||||
hasToPickUpCheckbox: 'vn-claim-basic-data vn-check[ng-model="$ctrl.claim.hasToPickUp"]',
|
|
||||||
saveButton: `button[type=submit]`
|
saveButton: `button[type=submit]`
|
||||||
},
|
},
|
||||||
claimDetail: {
|
claimDetail: {
|
||||||
|
|
|
@ -36,7 +36,6 @@ describe('Claim edit basic data path', () => {
|
||||||
|
|
||||||
it('should check the "Pick up" checkbox', async() => {
|
it('should check the "Pick up" checkbox', async() => {
|
||||||
await page.reloadSection('claim.card.basicData');
|
await page.reloadSection('claim.card.basicData');
|
||||||
await page.waitToClick(selectors.claimBasicData.hasToPickUpCheckbox);
|
|
||||||
await page.waitToClick(selectors.claimBasicData.saveButton);
|
await page.waitToClick(selectors.claimBasicData.saveButton);
|
||||||
const message = await page.waitForSnackbar();
|
const message = await page.waitForSnackbar();
|
||||||
|
|
||||||
|
@ -51,12 +50,6 @@ describe('Claim edit basic data path', () => {
|
||||||
expect(result).toEqual('Resuelto');
|
expect(result).toEqual('Resuelto');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should confirm the "is paid with mana" and "Pick up" checkbox are checked', async() => {
|
|
||||||
const hasToPickUpCheckbox = await page.checkboxState(selectors.claimBasicData.hasToPickUpCheckbox);
|
|
||||||
|
|
||||||
expect(hasToPickUpCheckbox).toBe('checked');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('should confirm the claim packages was edited', async() => {
|
it('should confirm the claim packages was edited', async() => {
|
||||||
const result = await page
|
const result = await page
|
||||||
.waitToGetProperty(selectors.claimBasicData.packages, 'value');
|
.waitToGetProperty(selectors.claimBasicData.packages, 'value');
|
||||||
|
|
|
@ -0,0 +1,56 @@
|
||||||
|
const ParameterizedSQL = require('loopback-connector').ParameterizedSQL;
|
||||||
|
const UserError = require('vn-loopback/util/user-error');
|
||||||
|
|
||||||
|
module.exports = Self => {
|
||||||
|
Self.remoteMethod('getEnumValues', {
|
||||||
|
description: 'Return enum values of column',
|
||||||
|
accessType: 'EXECUTE',
|
||||||
|
accepts: [
|
||||||
|
{
|
||||||
|
arg: 'schema',
|
||||||
|
type: 'string',
|
||||||
|
description: 'The schema of db',
|
||||||
|
required: true,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
arg: 'table',
|
||||||
|
type: 'string',
|
||||||
|
description: 'The table of schema',
|
||||||
|
required: true,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
arg: 'column',
|
||||||
|
type: 'string',
|
||||||
|
description: 'The column of table',
|
||||||
|
required: true,
|
||||||
|
},
|
||||||
|
],
|
||||||
|
returns: {
|
||||||
|
type: 'any',
|
||||||
|
root: true
|
||||||
|
},
|
||||||
|
http: {
|
||||||
|
path: `/get-enum-values`,
|
||||||
|
verb: 'GET'
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
Self.getEnumValues = async(schema, table, column) => {
|
||||||
|
const stmt = new ParameterizedSQL(`
|
||||||
|
SELECT COLUMN_TYPE
|
||||||
|
FROM information_schema.COLUMNS
|
||||||
|
WHERE TABLE_SCHEMA = ?
|
||||||
|
AND TABLE_NAME = ?
|
||||||
|
AND COLUMN_NAME = ?
|
||||||
|
AND DATA_TYPE = 'enum';`,
|
||||||
|
[schema, table, column]);
|
||||||
|
|
||||||
|
const conn = Self.dataSource.connector;
|
||||||
|
const [result] = await conn.executeStmt(stmt);
|
||||||
|
|
||||||
|
if (!result) throw new UserError(`No results found`);
|
||||||
|
|
||||||
|
const regex = /'([^']*)'/g;
|
||||||
|
return result.COLUMN_TYPE.match(regex).map(match => match.slice(1, -1));
|
||||||
|
};
|
||||||
|
};
|
|
@ -0,0 +1,35 @@
|
||||||
|
const models = require('vn-loopback/server/server').models;
|
||||||
|
|
||||||
|
describe('Application getEnumValues()', () => {
|
||||||
|
let tx;
|
||||||
|
|
||||||
|
beforeEach(async() => {
|
||||||
|
tx = await models.Application.beginTransaction({});
|
||||||
|
const options = {transaction: tx};
|
||||||
|
|
||||||
|
await models.Application.rawSql(`
|
||||||
|
CREATE TABLE tableWithEnum (
|
||||||
|
direction enum('in', 'out', 'middle'),
|
||||||
|
PRIMARY KEY (direction)
|
||||||
|
) ENGINE=InnoDB;
|
||||||
|
`, null, options);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('should return three if is ok', async() => {
|
||||||
|
try {
|
||||||
|
const options = {transaction: tx};
|
||||||
|
const response = await models.Application.getEnumValues(
|
||||||
|
'vn',
|
||||||
|
'tableWithEnum',
|
||||||
|
'direction',
|
||||||
|
options
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(response.length).toEqual(3);
|
||||||
|
await tx.rollback();
|
||||||
|
} catch (e) {
|
||||||
|
await tx.rollback();
|
||||||
|
throw e;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
|
@ -5,4 +5,5 @@ module.exports = function(Self) {
|
||||||
require('../methods/application/execute')(Self);
|
require('../methods/application/execute')(Self);
|
||||||
require('../methods/application/executeProc')(Self);
|
require('../methods/application/executeProc')(Self);
|
||||||
require('../methods/application/executeFunc')(Self);
|
require('../methods/application/executeFunc')(Self);
|
||||||
|
require('../methods/application/getEnumValues')(Self);
|
||||||
};
|
};
|
||||||
|
|
|
@ -68,7 +68,7 @@
|
||||||
"Changed client paymethod": "I have changed the pay method for client [{{clientName}} ({{clientId}})]({{{url}}})",
|
"Changed client paymethod": "I have changed the pay method for client [{{clientName}} ({{clientId}})]({{{url}}})",
|
||||||
"Sent units from ticket": "I sent *{{quantity}}* units of [{{concept}} ({{itemId}})]({{{itemUrl}}}) to *\"{{nickname}}\"* coming from ticket id [{{ticketId}}]({{{ticketUrl}}})",
|
"Sent units from ticket": "I sent *{{quantity}}* units of [{{concept}} ({{itemId}})]({{{itemUrl}}}) to *\"{{nickname}}\"* coming from ticket id [{{ticketId}}]({{{ticketUrl}}})",
|
||||||
"Change quantity": "{{concept}} change of {{oldQuantity}} to {{newQuantity}}",
|
"Change quantity": "{{concept}} change of {{oldQuantity}} to {{newQuantity}}",
|
||||||
"Claim will be picked": "The product from the claim [({{claimId}})]({{{claimUrl}}}) from the client *{{clientName}}* will be picked",
|
"Claim will be picked": "The product from the claim [({{claimId}})]({{{claimUrl}}}) from the client *{{clientName}}* will be picked, with the pickup type *{{claimPickup}}*",
|
||||||
"Claim state has changed to": "The state of the claim [({{claimId}})]({{{claimUrl}}}) from client *{{clientName}}* has changed to *{{newState}}*",
|
"Claim state has changed to": "The state of the claim [({{claimId}})]({{{claimUrl}}}) from client *{{clientName}}* has changed to *{{newState}}*",
|
||||||
"Customs agent is required for a non UEE member": "Customs agent is required for a non UEE member",
|
"Customs agent is required for a non UEE member": "Customs agent is required for a non UEE member",
|
||||||
"Incoterms is required for a non UEE member": "Incoterms is required for a non UEE member",
|
"Incoterms is required for a non UEE member": "Incoterms is required for a non UEE member",
|
||||||
|
@ -89,6 +89,8 @@
|
||||||
"landed": "Landed",
|
"landed": "Landed",
|
||||||
"addressFk": "Address",
|
"addressFk": "Address",
|
||||||
"companyFk": "Company",
|
"companyFk": "Company",
|
||||||
|
"agency": "Agency",
|
||||||
|
"delivery": "Delivery",
|
||||||
"You need to fill sage information before you check verified data": "You need to fill sage information before you check verified data",
|
"You need to fill sage information before you check verified data": "You need to fill sage information before you check verified data",
|
||||||
"The social name cannot be empty": "The social name cannot be empty",
|
"The social name cannot be empty": "The social name cannot be empty",
|
||||||
"The nif cannot be empty": "The nif cannot be empty",
|
"The nif cannot be empty": "The nif cannot be empty",
|
||||||
|
|
|
@ -135,7 +135,7 @@
|
||||||
"Changed client paymethod": "He cambiado la forma de pago del cliente [{{clientName}} ({{clientId}})]({{{url}}})",
|
"Changed client paymethod": "He cambiado la forma de pago del cliente [{{clientName}} ({{clientId}})]({{{url}}})",
|
||||||
"Sent units from ticket": "Envio *{{quantity}}* unidades de [{{concept}} ({{itemId}})]({{{itemUrl}}}) a *\"{{nickname}}\"* provenientes del ticket id [{{ticketId}}]({{{ticketUrl}}})",
|
"Sent units from ticket": "Envio *{{quantity}}* unidades de [{{concept}} ({{itemId}})]({{{itemUrl}}}) a *\"{{nickname}}\"* provenientes del ticket id [{{ticketId}}]({{{ticketUrl}}})",
|
||||||
"Change quantity": "{{concept}} cambia de {{oldQuantity}} a {{newQuantity}}",
|
"Change quantity": "{{concept}} cambia de {{oldQuantity}} a {{newQuantity}}",
|
||||||
"Claim will be picked": "Se recogerá el género de la reclamación [({{claimId}})]({{{claimUrl}}}) del cliente *{{clientName}}*",
|
"Claim will be picked": "Se recogerá el género de la reclamación [({{claimId}})]({{{claimUrl}}}) del cliente *{{clientName}}*, con el tipo de recogida *{{claimPickup}}*",
|
||||||
"Claim state has changed to": "Se ha cambiado el estado de la reclamación [({{claimId}})]({{{claimUrl}}}) del cliente *{{clientName}}* a *{{newState}}*",
|
"Claim state has changed to": "Se ha cambiado el estado de la reclamación [({{claimId}})]({{{claimUrl}}}) del cliente *{{clientName}}* a *{{newState}}*",
|
||||||
"Client checked as validated despite of duplication": "Cliente comprobado a pesar de que existe el cliente id {{clientId}}",
|
"Client checked as validated despite of duplication": "Cliente comprobado a pesar de que existe el cliente id {{clientId}}",
|
||||||
"ORDER_ROW_UNAVAILABLE": "No hay disponibilidad de este producto",
|
"ORDER_ROW_UNAVAILABLE": "No hay disponibilidad de este producto",
|
||||||
|
@ -168,6 +168,8 @@
|
||||||
"landed": "F. entrega",
|
"landed": "F. entrega",
|
||||||
"addressFk": "Consignatario",
|
"addressFk": "Consignatario",
|
||||||
"companyFk": "Empresa",
|
"companyFk": "Empresa",
|
||||||
|
"agency": "Agencia",
|
||||||
|
"delivery": "Reparto",
|
||||||
"The social name cannot be empty": "La razón social no puede quedar en blanco",
|
"The social name cannot be empty": "La razón social no puede quedar en blanco",
|
||||||
"The nif cannot be empty": "El NIF no puede quedar en blanco",
|
"The nif cannot be empty": "El NIF no puede quedar en blanco",
|
||||||
"You need to fill sage information before you check verified data": "Debes rellenar la información de sage antes de marcar datos comprobados",
|
"You need to fill sage information before you check verified data": "Debes rellenar la información de sage antes de marcar datos comprobados",
|
||||||
|
@ -349,5 +351,6 @@
|
||||||
"The address of the customer must have information about Incoterms and Customs Agent": "El consignatario del cliente debe tener informado Incoterms y Agente de aduanas",
|
"The address of the customer must have information about Incoterms and Customs Agent": "El consignatario del cliente debe tener informado Incoterms y Agente de aduanas",
|
||||||
"The line could not be marked": "La linea no puede ser marcada",
|
"The line could not be marked": "La linea no puede ser marcada",
|
||||||
"This password can only be changed by the user themselves": "Esta contraseña solo puede ser modificada por el propio usuario",
|
"This password can only be changed by the user themselves": "Esta contraseña solo puede ser modificada por el propio usuario",
|
||||||
"They're not your subordinate": "No es tu subordinado/a."
|
"They're not your subordinate": "No es tu subordinado/a.",
|
||||||
|
"No results found": "No se han encontrado resultados"
|
||||||
}
|
}
|
|
@ -6,7 +6,6 @@ columns:
|
||||||
isChargedToMana: charged to mana
|
isChargedToMana: charged to mana
|
||||||
created: created
|
created: created
|
||||||
responsibility: responsibility
|
responsibility: responsibility
|
||||||
hasToPickUp: has to pickUp
|
|
||||||
ticketFk: ticket
|
ticketFk: ticket
|
||||||
claimStateFk: claim state
|
claimStateFk: claim state
|
||||||
workerFk: worker
|
workerFk: worker
|
||||||
|
|
|
@ -6,7 +6,6 @@ columns:
|
||||||
isChargedToMana: cargado al maná
|
isChargedToMana: cargado al maná
|
||||||
created: creado
|
created: creado
|
||||||
responsibility: responsabilidad
|
responsibility: responsabilidad
|
||||||
hasToPickUp: es recogida
|
|
||||||
ticketFk: ticket
|
ticketFk: ticket
|
||||||
claimStateFk: estado reclamación
|
claimStateFk: estado reclamación
|
||||||
workerFk: trabajador
|
workerFk: trabajador
|
||||||
|
|
|
@ -11,7 +11,7 @@ describe('claim log()', () => {
|
||||||
model: 'Claim',
|
model: 'Claim',
|
||||||
action: 'update',
|
action: 'update',
|
||||||
changes: [
|
changes: [
|
||||||
{property: 'hasToPickUp', before: false, after: true}
|
{property: 'pickup', before: null, after: 'agency'}
|
||||||
]
|
]
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -86,7 +86,7 @@ describe('Update Claim', () => {
|
||||||
args: {
|
args: {
|
||||||
observation: 'valid observation',
|
observation: 'valid observation',
|
||||||
claimStateFk: pendingState,
|
claimStateFk: pendingState,
|
||||||
hasToPickUp: false
|
pickup: null
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
ctx.req.__ = i18n.__;
|
ctx.req.__ = i18n.__;
|
||||||
|
@ -124,7 +124,7 @@ describe('Update Claim', () => {
|
||||||
args: {
|
args: {
|
||||||
observation: 'valid observation',
|
observation: 'valid observation',
|
||||||
claimStateFk: canceledState,
|
claimStateFk: canceledState,
|
||||||
hasToPickUp: false
|
pickup: null
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
ctx.req.__ = i18n.__;
|
ctx.req.__ = i18n.__;
|
||||||
|
@ -163,7 +163,7 @@ describe('Update Claim', () => {
|
||||||
claimStateFk: 3,
|
claimStateFk: 3,
|
||||||
workerFk: 5,
|
workerFk: 5,
|
||||||
observation: 'another valid observation',
|
observation: 'another valid observation',
|
||||||
hasToPickUp: true
|
pickup: 'agency'
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
ctx.req.__ = i18n.__;
|
ctx.req.__ = i18n.__;
|
||||||
|
|
|
@ -27,8 +27,8 @@ module.exports = Self => {
|
||||||
type: 'string'
|
type: 'string'
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
arg: 'hasToPickUp',
|
arg: 'pickup',
|
||||||
type: 'boolean'
|
type: 'any'
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
arg: 'packages',
|
arg: 'packages',
|
||||||
|
@ -72,9 +72,7 @@ module.exports = Self => {
|
||||||
// Get sales person from claim client
|
// Get sales person from claim client
|
||||||
const salesPerson = claim.client().salesPersonUser();
|
const salesPerson = claim.client().salesPersonUser();
|
||||||
|
|
||||||
let changedHasToPickUp = false;
|
const changedPickup = args.pickup != claim.pickup;
|
||||||
if (args.hasToPickUp)
|
|
||||||
changedHasToPickUp = true;
|
|
||||||
|
|
||||||
// Validate when claimState has been changed
|
// Validate when claimState has been changed
|
||||||
if (args.claimStateFk) {
|
if (args.claimStateFk) {
|
||||||
|
@ -82,15 +80,15 @@ module.exports = Self => {
|
||||||
const canEditNewState = await models.ClaimState.isEditable(ctx, args.claimStateFk, myOptions);
|
const canEditNewState = await models.ClaimState.isEditable(ctx, args.claimStateFk, myOptions);
|
||||||
const canEditState = await models.ACL.checkAccessAcl(ctx, 'Claim', 'editState', 'WRITE');
|
const canEditState = await models.ACL.checkAccessAcl(ctx, 'Claim', 'editState', 'WRITE');
|
||||||
|
|
||||||
if (!canEditOldState || !canEditNewState || changedHasToPickUp && !canEditState)
|
if (!canEditOldState || !canEditNewState || changedPickup && !canEditState)
|
||||||
throw new UserError(`You don't have enough privileges to change that field`);
|
throw new UserError(`You don't have enough privileges to change that field`);
|
||||||
}
|
}
|
||||||
|
|
||||||
delete args.ctx;
|
delete args.ctx;
|
||||||
const updatedClaim = await claim.updateAttributes(args, myOptions);
|
const updatedClaim = await claim.updateAttributes(args, myOptions);
|
||||||
|
|
||||||
// When hasToPickUp has been changed
|
// When pickup has been changed
|
||||||
if (salesPerson && changedHasToPickUp && updatedClaim.hasToPickUp)
|
if (salesPerson && changedPickup && updatedClaim.pickup)
|
||||||
await notifyPickUp(ctx, salesPerson.id, claim);
|
await notifyPickUp(ctx, salesPerson.id, claim);
|
||||||
|
|
||||||
// When claimState has been changed
|
// When claimState has been changed
|
||||||
|
@ -132,7 +130,8 @@ module.exports = Self => {
|
||||||
const message = $t('Claim will be picked', {
|
const message = $t('Claim will be picked', {
|
||||||
claimId: claim.id,
|
claimId: claim.id,
|
||||||
clientName: claim.client().name,
|
clientName: claim.client().name,
|
||||||
claimUrl: `${url}claim/${claim.id}/summary`
|
claimUrl: `${url}claim/${claim.id}/summary`,
|
||||||
|
claimPickup: $t(claim.pickup)
|
||||||
});
|
});
|
||||||
await models.Chat.sendCheckingPresence(ctx, workerId, message);
|
await models.Chat.sendCheckingPresence(ctx, workerId, message);
|
||||||
}
|
}
|
||||||
|
|
|
@ -31,8 +31,8 @@
|
||||||
"responsibility": {
|
"responsibility": {
|
||||||
"type": "number"
|
"type": "number"
|
||||||
},
|
},
|
||||||
"hasToPickUp": {
|
"pickup": {
|
||||||
"type": "boolean"
|
"type": "string"
|
||||||
},
|
},
|
||||||
"ticketFk": {
|
"ticketFk": {
|
||||||
"type": "number"
|
"type": "number"
|
||||||
|
|
|
@ -85,7 +85,7 @@ describe('claim', () => {
|
||||||
it('should perform a patch query and show a success message', () => {
|
it('should perform a patch query and show a success message', () => {
|
||||||
jest.spyOn(controller.vnApp, 'showSuccess');
|
jest.spyOn(controller.vnApp, 'showSuccess');
|
||||||
|
|
||||||
const data = {hasToPickUp: true};
|
const data = {pickup: 'agency'};
|
||||||
$httpBackend.expect('PATCH', `Claims/1/updateClaimAction`, data).respond({});
|
$httpBackend.expect('PATCH', `Claims/1/updateClaimAction`, data).respond({});
|
||||||
controller.save(data);
|
controller.save(data);
|
||||||
$httpBackend.flush();
|
$httpBackend.flush();
|
||||||
|
|
|
@ -49,13 +49,6 @@
|
||||||
label="Packages received"
|
label="Packages received"
|
||||||
ng-model="$ctrl.claim.packages">
|
ng-model="$ctrl.claim.packages">
|
||||||
</vn-input-number>
|
</vn-input-number>
|
||||||
<vn-check
|
|
||||||
class="vn-mr-md"
|
|
||||||
label="Pick up"
|
|
||||||
ng-model="$ctrl.claim.hasToPickUp"
|
|
||||||
vn-acl="claimManager"
|
|
||||||
title="{{'When checked will notify to the salesPerson' | translate}}">
|
|
||||||
</vn-check>
|
|
||||||
</vn-horizontal>
|
</vn-horizontal>
|
||||||
</vn-card>
|
</vn-card>
|
||||||
<vn-button-bar>
|
<vn-button-bar>
|
||||||
|
|
|
@ -49,13 +49,6 @@
|
||||||
label="Attended by"
|
label="Attended by"
|
||||||
value="{{$ctrl.summary.claim.worker.user.nickname}}">
|
value="{{$ctrl.summary.claim.worker.user.nickname}}">
|
||||||
</vn-label-value>
|
</vn-label-value>
|
||||||
<vn-check
|
|
||||||
class="vn-mr-md"
|
|
||||||
label="Pick up"
|
|
||||||
ng-model="$ctrl.summary.claim.hasToPickUp"
|
|
||||||
title="{{'When checked will notify to the salesPerson' | translate}}"
|
|
||||||
disabled="true">
|
|
||||||
</vn-check>
|
|
||||||
</vn-auto>
|
</vn-auto>
|
||||||
<vn-auto>
|
<vn-auto>
|
||||||
<h4 ng-show="$ctrl.isSalesPerson && $ctrl.summary.observations.length">
|
<h4 ng-show="$ctrl.isSalesPerson && $ctrl.summary.observations.length">
|
||||||
|
|
|
@ -1,4 +1,4 @@
|
||||||
const {models} = require('vn-loopback/server/server');
|
const { models } = require('vn-loopback/server/server');
|
||||||
const LoopBackContext = require('loopback-context');
|
const LoopBackContext = require('loopback-context');
|
||||||
|
|
||||||
// #6276
|
// #6276
|
||||||
|
@ -8,11 +8,11 @@ describe('ItemShelving upsertItem()', () => {
|
||||||
let options;
|
let options;
|
||||||
let tx;
|
let tx;
|
||||||
|
|
||||||
beforeEach(async() => {
|
beforeEach(async () => {
|
||||||
ctx = {
|
ctx = {
|
||||||
req: {
|
req: {
|
||||||
accessToken: {userId: 9},
|
accessToken: { userId: 9 },
|
||||||
headers: {origin: 'http://localhost'}
|
headers: { origin: 'http://localhost' }
|
||||||
},
|
},
|
||||||
args: {}
|
args: {}
|
||||||
};
|
};
|
||||||
|
@ -21,36 +21,37 @@ describe('ItemShelving upsertItem()', () => {
|
||||||
active: ctx.req
|
active: ctx.req
|
||||||
});
|
});
|
||||||
|
|
||||||
options = {transaction: tx};
|
options = { transaction: tx };
|
||||||
tx = await models.ItemShelving.beginTransaction({});
|
tx = await models.ItemShelving.beginTransaction({});
|
||||||
options.transaction = tx;
|
options.transaction = tx;
|
||||||
});
|
});
|
||||||
|
|
||||||
afterEach(async() => {
|
afterEach(async () => {
|
||||||
await tx.rollback();
|
await tx.rollback();
|
||||||
});
|
});
|
||||||
|
|
||||||
xit('should add two new records', async() => {
|
it('should add two new records', async () => {
|
||||||
const shelvingFk = 'ZPP';
|
const shelvingFk = 'ZPP';
|
||||||
const items = [1, 1, 1, 2];
|
const items = [1, 1, 1, 2];
|
||||||
|
|
||||||
await models.ItemShelving.upsertItem(ctx, shelvingFk, items, warehouseFk, options);
|
await models.ItemShelving.upsertItem(ctx, shelvingFk, items, warehouseFk, options);
|
||||||
const itemShelvings = await models.ItemShelving.find({where: {shelvingFk}}, options);
|
const itemShelvings = await models.ItemShelving.find({ where: { shelvingFk } }, options);
|
||||||
|
|
||||||
expect(itemShelvings.length).toEqual(2);
|
expect(itemShelvings.length).toEqual(2);
|
||||||
});
|
});
|
||||||
|
|
||||||
xit('should update the visible items', async() => {
|
it('should update the visible items', async () => {
|
||||||
const shelvingFk = 'GVC';
|
const shelvingFk = 'GVC';
|
||||||
const items = [2, 2];
|
const items = [2, 2];
|
||||||
const {visible: itemsBefore} = await models.ItemShelving.findOne({
|
const { visible: visibleItemsBefore } = await models.ItemShelving.findOne({
|
||||||
where: {shelvingFk, itemFk: items[0]}
|
where: { shelvingFk, itemFk: items[0] }
|
||||||
}, options);
|
}, options);
|
||||||
await models.ItemShelving.upsertItem(ctx, shelvingFk, items, warehouseFk, options);
|
await models.ItemShelving.upsertItem(ctx, shelvingFk, items, warehouseFk, options);
|
||||||
const {visible: itemsAfter} = await models.ItemShelving.findOne({
|
|
||||||
where: {shelvingFk, itemFk: items[0]}
|
const { visible: visibleItemsAfter } = await models.ItemShelving.findOne({
|
||||||
|
where: { shelvingFk, itemFk: items[0] }
|
||||||
}, options);
|
}, options);
|
||||||
|
|
||||||
expect(itemsAfter).toEqual(itemsBefore + 2);
|
expect(visibleItemsAfter).toEqual(visibleItemsBefore + 2);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
|
@ -1,4 +1,5 @@
|
||||||
const ParameterizedSQL = require('loopback-connector').ParameterizedSQL;
|
const ParameterizedSQL = require('loopback-connector').ParameterizedSQL;
|
||||||
|
const {mergeFilters, mergeWhere} = require('vn-loopback/util/filter');
|
||||||
|
|
||||||
module.exports = Self => {
|
module.exports = Self => {
|
||||||
Self.remoteMethodCtx('filter', {
|
Self.remoteMethodCtx('filter', {
|
||||||
|
@ -33,28 +34,31 @@ module.exports = Self => {
|
||||||
const userId = ctx.req.accessToken.userId;
|
const userId = ctx.req.accessToken.userId;
|
||||||
const models = Self.app.models;
|
const models = Self.app.models;
|
||||||
|
|
||||||
|
// Get ids alloweds
|
||||||
const account = await models.VnUser.findById(userId);
|
const account = await models.VnUser.findById(userId);
|
||||||
const stmt = new ParameterizedSQL(
|
const stmt = new ParameterizedSQL(
|
||||||
`SELECT d.id dmsFk, d.reference, d.description, d.file, d.created, d.hardCopyNumber, d.hasFile
|
`SELECT d.id, d.id dmsFk
|
||||||
FROM workerDocument wd
|
FROM workerDocument wd
|
||||||
JOIN dms d ON d.id = wd.document
|
JOIN dms d ON d.id = wd.document
|
||||||
JOIN dmsType dt ON dt.id = d.dmsTypeFk
|
JOIN dmsType dt ON dt.id = d.dmsTypeFk
|
||||||
LEFT JOIN account.roleRole rr ON rr.inheritsFrom = dt.readRoleFk AND rr.role = ?
|
LEFT JOIN account.roleRole rr ON rr.inheritsFrom = dt.readRoleFk AND rr.role = ?
|
||||||
`, [account.roleFk]
|
`, [account.roleFk]
|
||||||
);
|
);
|
||||||
const oldWhere = filter.where;
|
|
||||||
const yourOwnDms = {and: [{isReadableByWorker: true}, {worker: userId}]};
|
const yourOwnDms = {and: [{isReadableByWorker: true}, {worker: userId}]};
|
||||||
|
const where = {
|
||||||
filter.where = {
|
|
||||||
and: [{
|
|
||||||
or: [yourOwnDms, {
|
or: [yourOwnDms, {
|
||||||
role: {
|
role: {
|
||||||
neq: null
|
neq: null
|
||||||
}
|
}
|
||||||
}]
|
}]
|
||||||
}, oldWhere]};
|
};
|
||||||
stmt.merge(conn.makeSuffix(filter));
|
stmt.merge(conn.makeSuffix(mergeWhere(filter.where, where)));
|
||||||
const workerDms = await conn.executeStmt(stmt);
|
|
||||||
|
// Get workerDms alloweds
|
||||||
|
const dmsIds = await conn.executeStmt(stmt);
|
||||||
|
const allowedIds = dmsIds.map(dms => dms.id);
|
||||||
|
const allowedFilter = mergeFilters(filter, {where: {dmsFk: {inq: allowedIds}, workerFk: id}});
|
||||||
|
let workerDms = await models.WorkerDms.find(allowedFilter);
|
||||||
|
|
||||||
// Get docuware info
|
// Get docuware info
|
||||||
const docuware = await models.Docuware.findOne({
|
const docuware = await models.Docuware.findOne({
|
||||||
|
@ -63,28 +67,43 @@ module.exports = Self => {
|
||||||
});
|
});
|
||||||
const docuwareDmsType = docuware.dmsTypeFk;
|
const docuwareDmsType = docuware.dmsTypeFk;
|
||||||
let workerDocuware = [];
|
let workerDocuware = [];
|
||||||
if (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType))) {
|
if (!filter.skip && (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType)))) {
|
||||||
const worker = await models.Worker.findById(id, {fields: ['fi', 'firstName', 'lastName']});
|
const worker = await models.Worker.findById(id, {fields: ['fi', 'firstName', 'lastName']});
|
||||||
const docuwareParse = {
|
const docuwareParse = {
|
||||||
'Filename': 'dmsFk',
|
'Filename': 'dmsFk',
|
||||||
'Tipo Documento': 'description',
|
'Tipo Documento': 'description',
|
||||||
'Stored on': 'created',
|
'Stored on': 'created',
|
||||||
'Document ID': 'id'
|
'Document ID': 'id',
|
||||||
|
'URL': 'download',
|
||||||
|
'Stored by': 'name',
|
||||||
|
'Estado': 'state'
|
||||||
};
|
};
|
||||||
|
|
||||||
workerDocuware =
|
workerDocuware =
|
||||||
await models.Docuware.getById('hr', worker.lastName + ' ' + worker.firstName, docuwareParse) ?? [];
|
await models.Docuware.getById('hr', worker.lastName + ' ' + worker.firstName, docuwareParse) ?? [];
|
||||||
|
const url = (await Self.app.models.Url.getUrl('docuware')) + 'WebClient';
|
||||||
for (document of workerDocuware) {
|
for (document of workerDocuware) {
|
||||||
|
const docuwareId = document.id;
|
||||||
const defaultData = {
|
const defaultData = {
|
||||||
file: 'dw' + document.id + '.png',
|
id: docuwareId,
|
||||||
|
workerFk: id,
|
||||||
|
dmsFk: docuwareId,
|
||||||
|
dms: {
|
||||||
|
id: docuwareId,
|
||||||
|
file: docuwareId + '.pdf',
|
||||||
isDocuware: true,
|
isDocuware: true,
|
||||||
hardCopyNumber: null,
|
|
||||||
hasFile: false,
|
hasFile: false,
|
||||||
reference: worker.fi,
|
reference: worker.fi,
|
||||||
dmsFk: 'DW' + document.id
|
dmsFk: docuwareId,
|
||||||
|
url,
|
||||||
|
description: document.description + ' - ' + document.state,
|
||||||
|
download: document.download,
|
||||||
|
created: document.created,
|
||||||
|
dmsType: {name: 'Docuware'},
|
||||||
|
worker: {id: null, user: {name: document.name}},
|
||||||
|
}
|
||||||
};
|
};
|
||||||
|
Object.assign(document, defaultData);
|
||||||
document = Object.assign(document, defaultData);
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return workerDms.concat(workerDocuware);
|
return workerDms.concat(workerDocuware);
|
||||||
|
|
|
@ -2,6 +2,7 @@
|
||||||
vn-id="model"
|
vn-id="model"
|
||||||
url="WorkerDms/{{$ctrl.$params.id}}/filter"
|
url="WorkerDms/{{$ctrl.$params.id}}/filter"
|
||||||
link="{worker: $ctrl.$params.id}"
|
link="{worker: $ctrl.$params.id}"
|
||||||
|
filter="$ctrl.filter"
|
||||||
limit="20"
|
limit="20"
|
||||||
data="$ctrl.workerDms"
|
data="$ctrl.workerDms"
|
||||||
order="dmsFk DESC"
|
order="dmsFk DESC"
|
||||||
|
@ -28,37 +29,37 @@
|
||||||
</vn-thead>
|
</vn-thead>
|
||||||
<vn-tbody>
|
<vn-tbody>
|
||||||
<vn-tr ng-repeat="document in $ctrl.workerDms">
|
<vn-tr ng-repeat="document in $ctrl.workerDms">
|
||||||
<vn-td number shrink>{{::document.dmsFk}}</vn-td>
|
<vn-td number shrink>{{::document.id}}</vn-td>
|
||||||
<vn-td shrink number>
|
<vn-td shrink number>
|
||||||
<span class="chip" title="{{::document.hardCopyNumber}}"
|
<span class="chip" title="{{::document.dms.hardCopyNumber}}"
|
||||||
ng-class="{'message': document.hardCopyNumber}">
|
ng-class="{'message': document.hardCopyNumber}">
|
||||||
{{::document.hardCopyNumber}}
|
{{::document.dms.hardCopyNumber}}
|
||||||
</span>
|
</span>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td expand>
|
<vn-td expand>
|
||||||
<span title="{{::document.reference}}">
|
<span title="{{::document.dms.reference}}">
|
||||||
{{::document.reference}}
|
{{::document.dms.reference}}
|
||||||
</span>
|
</span>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td expand>
|
<vn-td expand>
|
||||||
<span title="{{::document.description}}">
|
<span title="{{::document.dms.description}}">
|
||||||
{{::document.description}}
|
{{::document.dms.description}}
|
||||||
</span>
|
</span>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td shrink>
|
<vn-td shrink>
|
||||||
<vn-check
|
<vn-check
|
||||||
ng-model="document.hasFile"
|
ng-model="document.dms.hasFile"
|
||||||
disabled="true">
|
disabled="true">
|
||||||
</vn-check>
|
</vn-check>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td shrink>
|
<vn-td shrink>
|
||||||
<span title="{{'Download file' | translate}}" class="link"
|
<span title="{{'Download file' | translate}}" class="link"
|
||||||
ng-click="$ctrl.downloadFile(document.dmsFk, document.isDocuware)">
|
ng-click="$ctrl.downloadFile(document.dmsFk, document.dms.isDocuware)">
|
||||||
{{::document.file}}
|
{{::document.dms.file}}
|
||||||
</span>
|
</span>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td shrink-datetime>
|
<vn-td shrink-datetime>
|
||||||
{{::document.created | date:'dd/MM/yyyy HH:mm'}}
|
{{::document.dms.created | date:'dd/MM/yyyy HH:mm'}}
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td shrink>
|
<vn-td shrink>
|
||||||
<vn-icon-button title="{{'Download file' | translate}}"
|
<vn-icon-button title="{{'Download file' | translate}}"
|
||||||
|
@ -66,7 +67,7 @@
|
||||||
ng-click="$ctrl.downloadFile(document.dmsFk, document.isDocuware)">
|
ng-click="$ctrl.downloadFile(document.dmsFk, document.isDocuware)">
|
||||||
</vn-icon-button>
|
</vn-icon-button>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td expand ng-if="::!document.isDocuware">
|
<vn-td expand ng-if="::!document.dms.isDocuware">
|
||||||
<vn-icon-button ui-sref="worker.card.dms.edit({dmsId: {{::document.dmsFk}}})"
|
<vn-icon-button ui-sref="worker.card.dms.edit({dmsId: {{::document.dmsFk}}})"
|
||||||
icon="edit"
|
icon="edit"
|
||||||
title="{{'Edit file' | translate}}">
|
title="{{'Edit file' | translate}}">
|
||||||
|
@ -78,7 +79,7 @@
|
||||||
tabindex="-1">
|
tabindex="-1">
|
||||||
</vn-icon-button>
|
</vn-icon-button>
|
||||||
</vn-td>
|
</vn-td>
|
||||||
<vn-td expand ng-if="::document.isDocuware">
|
<vn-td expand ng-if="::document.dms.isDocuware">
|
||||||
<vn-icon-button
|
<vn-icon-button
|
||||||
icon="open_in_new"
|
icon="open_in_new"
|
||||||
ng-click="$ctrl.openDocuware()"
|
ng-click="$ctrl.openDocuware()"
|
||||||
|
|
|
@ -6,6 +6,45 @@ class Controller extends Component {
|
||||||
constructor($element, $, vnFile) {
|
constructor($element, $, vnFile) {
|
||||||
super($element, $);
|
super($element, $);
|
||||||
this.vnFile = vnFile;
|
this.vnFile = vnFile;
|
||||||
|
this.filter = {
|
||||||
|
include: {
|
||||||
|
relation: 'dms',
|
||||||
|
scope: {
|
||||||
|
fields: [
|
||||||
|
'dmsTypeFk',
|
||||||
|
'reference',
|
||||||
|
'hardCopyNumber',
|
||||||
|
'workerFk',
|
||||||
|
'description',
|
||||||
|
'hasFile',
|
||||||
|
'file',
|
||||||
|
'created',
|
||||||
|
'companyFk',
|
||||||
|
'warehouseFk',
|
||||||
|
],
|
||||||
|
include: [
|
||||||
|
{
|
||||||
|
relation: 'dmsType',
|
||||||
|
scope: {
|
||||||
|
fields: ['name'],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
relation: 'worker',
|
||||||
|
scope: {
|
||||||
|
fields: ['id'],
|
||||||
|
include: {
|
||||||
|
relation: 'user',
|
||||||
|
scope: {
|
||||||
|
fields: ['name'],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
deleteDms(index) {
|
deleteDms(index) {
|
||||||
|
|
Loading…
Reference in New Issue