CHANGELOG.md

@@ -22,6 +22,7 @@
 - feat: refs #7438 Added volume to item_valuateInventory  by:guillermo
 - feat: refs #7438 Requested changes and little changes  by:guillermo
 - refs #6281 feat:buyFk in itemShelving  by:sergiodt
+- feat: refs #6449 item ID is displayed in the sale line  by:jorgep
 
 ### Changed 📦
 

back/methods/collection/getSales.js

@@ -60,6 +60,7 @@ module.exports = Self => {
         if (print) await Self.rawSql('CALL vn.collection_printSticker(?,NULL)', [id], myOptions);
 
         for (let ticket of tickets) {
+            if (ticket.observaciones) {
                 let observations = ticket.observaciones.split(' ');
 
                 for (let observation of observations) {
@@ -72,6 +73,7 @@ module.exports = Self => {
                     }
                 }
             }
+        }
 
         return getCollection(id, tickets, sales, placements, myOptions);
     };

back/methods/collection/spec/getSales.spec.js

@@ -4,15 +4,7 @@ describe('collection getSales()', () => {
     const collectionOrTicketFk = 999999;
     const print = true;
     const source = 'CHECKER';
-
+    const ctx = beforeAll.getCtx();
-    beforeAll(() => {
-        ctx = {
-            req: {
-                accessToken: {userId: 9},
-                headers: {origin: 'http://localhost'},
-            }
-        };
-    });
 
     it('should return a collection with tickets, placements and barcodes settled correctly', async() => {
         const tx = await models.Collection.beginTransaction({});

back/methods/collection/spec/getTickets.spec.js

@@ -1,15 +1,7 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('collection getTickets()', () => {
-    let ctx;
+    const ctx = beforeAll.getCtx();
-    beforeAll(async() => {
-        ctx = {
-            req: {
-                accessToken: {userId: 9},
-                headers: {origin: 'http://localhost'}
-            }
-        };
-    });
 
     it('should get tickets, sales and barcodes from collection', async() => {
         const tx = await models.Collection.beginTransaction({});

back/methods/collection/spec/setSaleQuantity.spec.js

@@ -1,20 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('setSaleQuantity()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should change quantity sale', async() => {
         const tx = await models.Ticket.beginTransaction({});

back/methods/starred-module/specs/getStarredModules.spec.js

@@ -1,22 +1,7 @@
 const {models} = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('getStarredModules()', () => {
-    const activeCtx = {
+    const ctx = beforeAll.getCtx();
-        accessToken: {userId: 9},
-        http: {
-            req: {
-                headers: {origin: 'http://localhost'}
-            }
-        }
-    };
-    const ctx = {req: activeCtx};
-
-    beforeEach(() => {
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it(`should return the starred modules for a given user`, async() => {
         const newStarred = await models.StarredModule.create({workerFk: 9, moduleFk: 'customer', position: 1});

back/methods/starred-module/specs/setPosition.spec.js

@@ -1,24 +1,8 @@
 const {models} = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('setPosition()', () => {
-    const activeCtx = {
+    const ctx = beforeAll.getCtx();
-        accessToken: {userId: 9},
+    beforeAll.mockLoopBackContext();
-        http: {
-            req: {
-                headers: {origin: 'http://localhost'}
-            }
-        }
-    };
-    const ctx = {
-        req: activeCtx
-    };
-
-    beforeEach(() => {
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should increase the orders module position by replacing it with clients and vice versa', async() => {
         const tx = await models.StarredModule.beginTransaction({});

back/methods/starred-module/specs/toggleStarredModule.spec.js

@@ -1,24 +1,7 @@
 const {models} = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('toggleStarredModule()', () => {
-    const activeCtx = {
+    const ctx = beforeAll.getCtx();
-        accessToken: {userId: 9},
-        http: {
-            req: {
-                headers: {origin: 'http://localhost'}
-            }
-        }
-    };
-    const ctx = {
-        req: activeCtx
-    };
-
-    beforeEach(() => {
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should create a new starred module and then remove it by calling the method again with same args', async() => {
         const starredModule = await models.StarredModule.toggleStarredModule(ctx, 'order');
@@ -26,7 +9,7 @@ describe('toggleStarredModule()', () => {
 
         expect(starredModules.length).toEqual(1);
         expect(starredModule.moduleFk).toEqual('order');
-        expect(starredModule.workerFk).toEqual(activeCtx.accessToken.userId);
+        expect(starredModule.workerFk).toEqual(ctx.req.accessToken.userId);
         expect(starredModule.position).toEqual(starredModules.length);
 
         await models.StarredModule.toggleStarredModule(ctx, 'order');

back/methods/user-config/specs/getUserConfig.spec.js

@@ -1,12 +1,12 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('userConfig getUserConfig()', () => {
+    const ctx = beforeAll.getCtx();
     it(`should return the configuration data of a given user`, async() => {
         const tx = await models.Item.beginTransaction({});
         const options = {transaction: tx};
 
         try {
-            const ctx = {req: {accessToken: {userId: 9}}};
             const result = await models.UserConfig.getUserConfig(ctx, options);
 
             expect(result.warehouseFk).toEqual(1);

back/models/specs/mailAliasAccount.spec.js

@@ -1,12 +1,13 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('loopback model MailAliasAccount', () => {
+    const ctx = beforeAll.getCtx();
     it('should add a mail Alias', async() => {
         const tx = await models.MailAliasAccount.beginTransaction({});
         let error;
 
         try {
-            const options = {transaction: tx, accessToken: {userId: 9}};
+            const options = {transaction: tx, ctx};
             await models.MailAliasAccount.create({mailAlias: 2, account: 5}, options);
 
             await tx.rollback();
@@ -23,7 +24,7 @@ describe('loopback model MailAliasAccount', () => {
         let error;
 
         try {
-            const options = {transaction: tx, accessToken: {userId: 9}};
+            const options = {transaction: tx, ctx};
             await models.MailAliasAccount.create({mailAlias: 3, account: 5}, options);
 
             await tx.rollback();

back/models/warehouse.json

@@ -22,7 +22,7 @@
     "isInventory": {
       "type": "number"
     },
-    "isManaged":{
+    "isManaged": {
       "type": "boolean"
     },
     "countryFk": {
@@ -34,6 +34,11 @@
       "type": "belongsTo",
       "model": "Country",
       "foreignKey": "countryFk"
+    },
+    "address": {
+      "type": "belongsTo",
+      "model": "Address",
+      "foreignKey": "addressFk"
     }
   },
   "acls": [
@@ -44,5 +49,11 @@
       "permission": "ALLOW"
     }
   ],
-  "scope" : {"where": {"isForTicket": {"neq": 0}}}
+  "scope": {
+    "where": {
+      "isForTicket": {
+        "neq": 0
+      }
+    }
+  }
 }

back/tests-helper.js

@@ -10,7 +10,6 @@ async function init() {
         host: process.env.DB_HOST,
         port: process.env.DB_PORT
     });
-
     const bootOptions = {dataSources};
     await new Promise((resolve, reject) => {
         app.boot(bootOptions,
@@ -33,3 +32,4 @@ module.exports = {
 
 if (require.main === module)
     init();
+

back/tests.js

@@ -84,7 +84,7 @@ async function test() {
             'loopback/**/*[sS]pec.js',
             'modules/*/back/**/*.[sS]pec.js'
         ],
-        helpers: []
+        helpers: [`back/vn-jasmine.js`],
     };
 
     if (PARALLEL) {
@@ -114,7 +114,6 @@ async function test() {
     if (opts.ci)
         runner.jasmine.DEFAULT_TIMEOUT_INTERVAL = SPEC_TIMEOUT;
 
-    // runner.loadConfigFile('back/jasmine.json');
     runner.loadConfig(config);
     process.env.SPEC_IS_RUNNING = true;
     await runner.execute();

back/vn-jasmine.js

@@ -0,0 +1,48 @@
+
+const LoopBackContext = require('loopback-context');
+const getAccessToken = (userId = 9) => {
+    return {accessToken: {userId}};
+};
+const DEFAULT_HEADERS = {headers: {origin: 'http://localhost'}};
+const default_before_all = userId => {
+    return {
+        req: {
+            ...getAccessToken(userId),
+            ...DEFAULT_HEADERS,
+            ...{__: value => value}
+
+        },
+        args: {}
+    };
+};
+const default_loopback_ctx = userId => {
+    return {
+        ...getAccessToken(userId),
+        ...default_before_all(userId),
+        http: {
+            ...default_before_all(userId)
+        },
+        args: {}
+    };
+};
+
+function vnBeforeAll() {
+    Object.assign(beforeAll, {getCtx: default_before_all, mockLoopBackContext});
+}
+
+const mockLoopBackContext = userId => {
+    const activeCtx = default_loopback_ctx(userId);
+    beforeAll(() => {
+        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
+            active: activeCtx
+        });
+    });
+    return activeCtx;
+};
+module.exports = {
+    mockLoopBackContext
+};
+
+(function init() {
+    vnBeforeAll();
+})();

db/dump/.dump/structure.sql

@@ -51399,9 +51399,9 @@ BEGIN
 	SELECT (pc.maxNotReadyCollections - COUNT(*)) <= 0
 		INTO vHasTooMuchCollections
 		FROM productionConfig pc
-			LEFT JOIN tCollection ON TRUE;
+			LEFT JOIN tmp.collection ON TRUE;
 
-	DROP TEMPORARY TABLE tCollection;
+	DROP TEMPORARY TABLE tmp.collection;
 
 	IF vHasTooMuchCollections THEN
 		CALL util.throw('Hay colecciones pendientes');
@@ -51478,9 +51478,9 @@ BEGIN
  * @param vWorkerFk id del worker.
  * @table Devuelve tabla temporal con las colecciones pendientes
  */
-	DROP TEMPORARY TABLE IF EXISTS tCollection;
+	DROP TEMPORARY TABLE IF EXISTS tmp.collection;
 
-	CREATE TEMPORARY TABLE tCollection
+	CREATE TEMPORARY TABLE tmp.collection
 	SELECT 	c.id collectionFk,
 			date(c.created) created,
 			COUNT(DISTINCT tc.ticketFk) ticketTotalCount
@@ -51499,7 +51499,7 @@ BEGIN
 		GROUP BY c.id
 		HAVING COUNT(*) > COUNT(DISTINCT st.id);
 
-	SELECT * FROM tCollection;
+	SELECT * FROM tmp.collection;
 END ;;
 DELIMITER ;
 /*!50003 SET sql_mode              = @saved_sql_mode */ ;

db/dump/fixtures.before.sql

@@ -3232,7 +3232,6 @@ INSERT IGNORE INTO vn.itemType
 		workerFk = 103,
 		isInventory = TRUE,
 		life = 10,
-		density = 250,
 		itemPackingTypeFk = NULL,
 		temperatureFk = 'warm';
 
@@ -3913,3 +3912,18 @@ INSERT INTO dipole.expedition_PrintOut (expeditionFk, ticketFk, addressFk, stree
 truckName, clientFk, phone, province, agency, m3, workerCode, itemFk, quantity, longName, shelvingFk, comments)
 VALUES(1, 1, 0, ' ', ' ', ' ', ' ', 0, '2001-01-01 00:00:00', 1, 0, ' ', ' ', 0, NULL, '', NULL, 0.000, NULL, 10, NULL, NULL, 'NCC', NULL);
 
+INSERT INTO vn.accountDetail
+(id, value, accountDetailTypeFk, supplierAccountFk)
+VALUES
+	(21, 'ES12345B12345678', 3, 241),
+	(35, 'ES12346B12345679', 3, 241);
+
+INSERT INTO vn.accountDetailType
+(id, description)
+VALUES
+		(1, 'IBAN'),
+		(2, 'SWIFT'),
+		(3, 'Referencia Remesas'),
+		(4, 'Referencia Transferencias'),
+		(5, 'Referencia Nominas'),
+		(6, 'ABA');

db/routines/bi/procedures/rutasAnalyze.sql

@@ -59,7 +59,7 @@ BEGIN
 						JOIN vn.saleComponent sc ON sc.saleFk = s.id
 						JOIN vn.component c ON c.id = sc.componentFk
 						JOIN vn.componentType ct ON ct.id = c.typeFk
-					WHERE ct.code = 'FREIGHT'
+					WHERE ct.code = 'freight'
 						AND r.created BETWEEN vDatedFrom AND vDatedTo
 					GROUP BY r.id
 			 ) sub ON sub.routeFk = r.Id_Ruta

db/routines/bi/views/tarifa_componentes_series.sql

@@ -2,7 +2,7 @@ CREATE OR REPLACE DEFINER=`root`@`localhost`
 	SQL SECURITY DEFINER
 	VIEW `bi`.`tarifa_componentes_series`
 AS SELECT `ct`.`id` AS `tarifa_componentes_series_id`,
-	`ct`.`type` AS `Serie`,
+	`ct`.`name` AS `Serie`,
 	`ct`.`isBase` AS `base`,
 	`ct`.`isMargin` AS `margen`
 FROM `vn`.`componentType` `ct`

db/routines/edi/procedures/ekt_refresh.sql

@@ -7,7 +7,6 @@ BEGIN
  */
 	DECLARE vRewriteKop INT DEFAULT NULL;
 	DECLARE vTruncatePutOrder INT DEFAULT NULL;
-	DECLARE vBarcode CHAR(15) DEFAULT NULL;
 	DECLARE vKop INT;
 	DECLARE vPutOrderFk BIGINT;
 
@@ -16,17 +15,6 @@ BEGIN
 		FROM ekt
 		WHERE id = vSelf;
 
-	-- Generates the barcode
-
-	SELECT CONCAT(
-				LPAD(IFNULL(auction,0), 3, 0),
-				LPAD(IFNULL(klo, 99), 2, 0),
-				LPAD(DAYOFYEAR(fec), 3, 0),
-				COALESCE(agj, RIGHT(batchNumber,7), id))
-			INTO vBarcode
-		FROM ekt
-		WHERE id = vSelf;
-
 	-- Rewrites the kop parameter
 
 	IF vKop IS NULL THEN
@@ -46,10 +34,9 @@ BEGIN
 
 	-- Refresh EKT
 
-	UPDATE ekt SET
+	UPDATE ekt
-		 barcode = vBarcode
+		SET kop = vKop,
-		,kop = vKop
+			putOrderFk = vTruncatePutOrder
-		,putOrderFk = vTruncatePutOrder
 	WHERE id = vSelf;
 END$$
 DELIMITER ;

db/routines/edi/views/ektRecent.sql

@@ -2,7 +2,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost`
 	SQL SECURITY DEFINER
 	VIEW `edi`.`ektRecent`
 AS SELECT `e`.`id` AS `id`,
-	`e`.`barcode` AS `barcode`,
 	`e`.`entryYear` AS `entryYear`,
 	`e`.`batchNumber` AS `batchNumber`,
 	`e`.`deliveryNumber` AS `deliveryNumber`,

db/routines/vn/procedures/collection_assign.sql

@@ -47,9 +47,9 @@ BEGIN
 		INTO vHasTooMuchCollections,
 			vLockName
 		FROM productionConfig pc
-			LEFT JOIN tCollection ON TRUE;
+			LEFT JOIN tmp.collection ON TRUE;
 
-	DROP TEMPORARY TABLE tCollection;
+	DROP TEMPORARY TABLE tmp.collection;
 
 	IF vHasTooMuchCollections THEN
 		CALL util.throw('Hay colecciones pendientes');

db/routines/vn/procedures/collection_get.sql

@@ -7,11 +7,15 @@ BEGIN
  * @param vWorkerFk id del worker.
  * @table Devuelve tabla temporal con las colecciones pendientes
  */
-	DROP TEMPORARY TABLE IF EXISTS tCollection;
+	DECLARE EXIT HANDLER FOR SQLEXCEPTION
+	BEGIN
+		RESIGNAL;
+	END;
 
-	CREATE TEMPORARY TABLE tCollection
+	CREATE OR REPLACE TEMPORARY TABLE tmp.collection
+		ENGINE = MEMORY
 		SELECT c.id collectionFk,
-			date(c.created) created,
+				DATE(c.created) created,
 				COUNT(DISTINCT tc.ticketFk) ticketTotalCount
 			FROM collection c 
 					JOIN ticketCollection tc ON tc.collectionFk = c.id 
@@ -19,15 +23,16 @@ BEGIN
 					JOIN ticketState ts ON ts.ticketFk = tc.ticketFk
 					JOIN state s2 ON s2.id = ts.stateFk
 					JOIN productionConfig pc
-				JOIN vn.state ss on ss.code = 'PREPARED'
+					JOIN vn.state ss ON ss.code = 'PREPARED'
-				LEFT JOIN vn.saleTracking st on st.saleFk = s.id AND st.stateFk = ss.id
+					LEFT JOIN vn.saleTracking st ON st.saleFk = s.id
+						AND st.stateFk = ss.id
 			WHERE c.workerFk = vWorkerFk 
 					AND TIMESTAMPDIFF(HOUR, c.created , util.VN_NOW()) < pc.pendingCollectionsAge
-				AND s.quantity != 0
+					AND s.quantity
 					AND s2.order < pc.pendingCollectionsOrder 
 			GROUP BY c.id
 			HAVING COUNT(*) > COUNT(DISTINCT st.id);
 
-	SELECT * FROM tCollection;
+	SELECT * FROM tmp.collection;
 END$$
 DELIMITER ;

db/routines/vn/procedures/collection_getAssigned.sql

@@ -34,10 +34,10 @@ BEGIN
 			pc.collection_assign_lockname
 		INTO vHasTooMuchCollections,
 			vLockName
-		FROM tCollection tc
+		FROM tmp.collection c
 			JOIN productionConfig pc;
 
-	DROP TEMPORARY TABLE tCollection;
+	DROP TEMPORARY TABLE tmp.collection;
 
 	IF vHasTooMuchCollections THEN
 		CALL util.throw('There are pending collections');

db/routines/vn/procedures/entry_isEditable.sql

@@ -18,7 +18,7 @@ BEGIN
 			AND e.id = vSelf;
 
 	IF vIsEditable AND NOT IFNULL(@isModeInventory, FALSE) THEN
-		CALL util.throw('Entry is not editable');
+		CALL util.throw(CONCAT('Entry ', vSelf, ' is not editable'));
 	END IF;
 END$$
 DELIMITER ;

db/routines/vn/procedures/entry_splitByShelving.sql

@@ -17,34 +17,19 @@ BEGIN
 		SELECT 	bb.id buyFk,
 				FLOOR(ish.visible / ish.packing) ishStickers,
 				bb.stickers buyStickers
-				FROM vn.itemShelving ish
+			FROM itemShelving ish
 				JOIN (SELECT b.id, b.itemFk, b.stickers 
-						FROM vn.buy b 
+						FROM buy b
 						WHERE b.entryFk = vFromEntryFk
 						ORDER BY b.stickers DESC
 						LIMIT 10000000000000000000) bb ON bb.itemFk = ish.itemFk
 							AND bb.stickers >= FLOOR(ish.visible / ish.packing)
-			WHERE shelvingFk = vShelvingFk COLLATE utf8_general_ci
+			WHERE ish.shelvingFk = vShelvingFk COLLATE utf8_general_ci
+				AND NOT ish.isSplit
 			GROUP BY ish.id;
 			
 	DECLARE CONTINUE HANDLER FOR NOT FOUND SET vDone = TRUE;
 
-	-- Cantidades de la matrícula que exceden la de las entradas 
-	SELECT 	ish.itemFk, 
-			i.longName, 
-			FLOOR(ish.visible / ish.packing) AS etiEnMatricula,
-			bb.stickers etiEnEntrada
-				FROM vn.itemShelving ish
-					JOIN vn.item i ON i.id = ish.itemFk 
-				LEFT JOIN (SELECT b.id, b.itemFk, b.stickers 
-						FROM vn.buy b 
-						WHERE b.entryFk = vFromEntryFk
-						ORDER BY b.stickers DESC
-						LIMIT 10000000000000000000) bb ON bb.itemFk = ish.itemFk
-			WHERE shelvingFk = vShelvingFk COLLATE utf8_general_ci
-				AND  IFNULL(bb.stickers,0) < FLOOR(ish.visible / ish.packing)
-			GROUP BY ish.id;
-		
 	OPEN cur;
 
 	read_loop: LOOP
@@ -57,16 +42,16 @@ BEGIN
 		END IF;
 
 		IF vIshStickers =  vBuyStickers THEN
-			UPDATE vn.buy
+			UPDATE buy
 				SET entryFk = vToEntryFk
 				WHERE id = vBuyFk;
 		ELSE
-			UPDATE vn.buy
+			UPDATE buy
 				SET stickers = stickers - vIshStickers,
 					quantity = stickers * packing 
 				WHERE id = vBuyFk;
 
-			INSERT INTO	vn.buy(entryFk,
+			INSERT INTO	buy(entryFk,
 								itemFk,
 								quantity,
 								buyingValue,
@@ -117,13 +102,16 @@ BEGIN
 							weight,
 							deliveryFk,
 							itemOriginalFk
-						FROM vn.buy
+						FROM buy
 						WHERE id = vBuyFk;
 
 			UPDATE buy SET printedStickers = vIshStickers WHERE id = LAST_INSERT_ID();
 		END IF;
-	END LOOP;
 
+		UPDATE itemShelving
+			SET isSplit = TRUE
+				WHERE shelvingFk = vShelvingFk;
+	END LOOP;
 	CLOSE cur;
 END$$
 DELIMITER ;

db/routines/vn/procedures/invoiceIn_booking.sql

@@ -13,20 +13,32 @@ BEGIN
  * @param vBookEntry Id de asiento, si es NULL se genera uno nuevo
  */
 	DECLARE vFiscalYear INT;
-	DECLARE vHasDistinctTransactions INT;
+	DECLARE vDistinctTransactions INT;
+	DECLARE vHasRepeatedTransactions BOOL;
 
-	SELECT COUNT(DISTINCT transactionTypeSageFk) INTO vHasDistinctTransactions
+	SELECT COUNT(DISTINCT iit.transactionTypeSageFk) INTO vDistinctTransactions
 		FROM invoiceIn ii
 			JOIN invoiceInTax iit ON iit.invoiceInFk = ii.id
 			JOIN invoiceInSerial iis ON iis.code = ii.serial 
-		WHERE ii.id = vSelf
+		WHERE iit.invoiceInFk = vSelf
 			AND iis.taxAreaFk = 'CEE'
-			AND transactionTypeSageFk;
+			AND iit.transactionTypeSageFk;
 
-	IF vHasDistinctTransactions > 1 THEN 
+	IF vDistinctTransactions > 1 THEN 
 		CALL util.throw ('This invoice does not allow different types of transactions');
 	END IF;
 
+	SELECT TRUE INTO vHasRepeatedTransactions
+		FROM invoiceInTax
+		WHERE invoiceInFk = vSelf
+		GROUP BY transactionTypeSageFk
+		HAVING COUNT(transactionTypeSageFk) > 1
+		LIMIT 1;
+
+	IF vHasRepeatedTransactions THEN 
+		CALL util.throw ('This invoice contains repeated types of transactions');
+	END IF;
+
 	CREATE OR REPLACE TEMPORARY TABLE tInvoiceIn
 		ENGINE = MEMORY
 		SELECT ii.bookEntried,

db/routines/vn/procedures/multipleInventory.sql

@@ -40,8 +40,7 @@ proc: BEGIN
 		(PRIMARY KEY (itemFk))
 		ENGINE = MEMORY
 		SELECT itemFk,
-				SUM(quantity) quantity,
+				SUM(quantity) quantity
-				SUM(quantity) visible
 			FROM (
 				SELECT s.itemFk, - s.quantity quantity
 					FROM sale s
@@ -75,9 +74,17 @@ proc: BEGIN
 			) sub
 			GROUP BY itemFk;
 
+	UPDATE tmp.itemInventory ai
+			JOIN tItemInventoryCalc iic ON iic.itemFk = ai.id
+		SET ai.inventory = iic.quantity,
+			ai.visible = iic.quantity,
+			ai.avalaible = iic.quantity,
+			ai.sd = iic.quantity;
+
 	-- Cálculo del visible
-	UPDATE tItemInventoryCalc iic
+	CREATE OR REPLACE TEMPORARY TABLE tItemVisibleCalc
-		JOIN (
+		(PRIMARY KEY (itemFk))
+		ENGINE = MEMORY		
 		SELECT itemFk, SUM(quantity) visible
 			FROM (
 				SELECT s.itemFk, s.quantity
@@ -114,16 +121,11 @@ proc: BEGIN
 						AND IFNULL(vWarehouseFk, t.warehouseOutFk) = t.warehouseOutFk
 						AND w.isComparative
 			) sub2
-				GROUP BY itemFk
+			GROUP BY itemFk;
-		) sub ON sub.itemFk = iic.itemFk
-		SET iic.visible = iic.visible + sub.visible;
 
 	UPDATE tmp.itemInventory ai
-			JOIN tItemInventoryCalc iic ON iic.itemFk = ai.id
+			JOIN tItemVisibleCalc ivc ON ivc.itemFk = ai.id
-		SET ai.inventory = iic.quantity,
+		SET ai.visible = ai.visible + ivc.visible;
-			ai.visible = iic.visible,
-			ai.avalaible = iic.quantity,
-			ai.sd = iic.quantity;
 
 	-- Calculo del disponible
 	CREATE OR REPLACE TEMPORARY TABLE tmp.itemCalc
@@ -195,6 +197,7 @@ proc: BEGIN
 		tmp.itemTravel,
 		tmp.itemCalc,
 		tItemInventoryCalc,
+		tItemVisibleCalc,
 		tmp.itemAtp;
 END$$
 DELIMITER ;

db/routines/vn/procedures/productionControl.sql

@@ -15,6 +15,11 @@ proc: BEGIN
 	DECLARE vEndingDate DATETIME;
 	DECLARE vIsTodayRelative BOOLEAN;
 
+	DECLARE EXIT HANDLER FOR SQLEXCEPTION
+	BEGIN
+		RESIGNAL;
+	END;
+
 	SELECT util.dayEnd(util.VN_CURDATE()) + INTERVAL LEAST(vScopeDays, maxProductionScopeDays) DAY
 		INTO vEndingDate
 		FROM productionConfig;
@@ -31,7 +36,8 @@ proc: BEGIN
 	CALL prepareClientList();
 
 	CREATE OR REPLACE TEMPORARY TABLE tmp.sale_getProblems
-		(INDEX (ticketFk)) ENGINE = MEMORY
+		(INDEX (ticketFk))
+		ENGINE = MEMORY
 		SELECT tt.ticketFk, tt.clientFk, t.warehouseFk, t.shipped
 			FROM tmp.productionTicket tt
 				JOIN ticket t ON t.id = tt.ticketFk;

db/routines/vn/procedures/sale_PriceFix.sql

@@ -8,7 +8,7 @@ BEGIN
 			JOIN vn.component c ON c.id = sc.componentFk
 			JOIN vn.componentType ct ON ct.id = c.typeFk
 		WHERE s.ticketFk = vTicketFk
-			AND ct.`type` = 'otros';
+			AND ct.code = 'other';
 
 	UPDATE vn.sale s
 		JOIN (

db/routines/vn/procedures/sale_getProblems.sql

@@ -278,12 +278,11 @@ BEGIN
 		-- Redondeo: Cantidad pedida incorrecta en al grouping de la última compra
 		CALL buyUltimate(vWarehouseFk, vDate);
 		INSERT INTO tmp.sale_problems(ticketFk, hasRounding, saleFk)
-			SELECT ticketFk, problem, saleFk
+			SELECT ticketFk, problem ,saleFk
 				FROM (
 					SELECT tl.ticketFk, 
-							s.id saleFk ,
+							s.id saleFk,
-							LEFT(GROUP_CONCAT('RE: ',i.id, ' ',  IFNULL(i.longName,''), ' '), 250) problem, 
+							LEFT(GROUP_CONCAT('RE: ',i.id, ' ',  IFNULL(i.longName,'') SEPARATOR ', '), 250) problem
-							MOD(s.quantity, b.`grouping`) hasRounding
 						FROM tmp.ticket_list tl
 							JOIN ticket t ON t.id = tl.ticketFk 
 								AND t.warehouseFk = vWarehouseFk
@@ -291,9 +290,9 @@ BEGIN
 							JOIN item i ON i.id = s.itemFk
 							JOIN tmp.buyUltimate bu ON bu.itemFk = s.itemFk
 							JOIN buy b ON b.id = bu.buyFk
+						WHERE MOD(s.quantity, b.`grouping`)	
 						GROUP BY tl.ticketFk
-						HAVING hasRounding
+				)sub 
-				) sub 
 			ON DUPLICATE KEY UPDATE hasRounding = sub.problem, saleFk = sub.saleFk;
 	END LOOP;
 	CLOSE vCursor;

db/routines/vn/procedures/ticket_Clone.sql

@@ -9,6 +9,11 @@ BEGIN
  */
 	DECLARE vStateFk INT;
 
+	DECLARE EXIT HANDLER FOR SQLEXCEPTION
+	BEGIN
+		RESIGNAL;
+	END;
+
 	INSERT INTO ticket (
 		clientFk,
 		shipped,

db/routines/vn/procedures/ticket_checkNoComponents.sql

@@ -20,7 +20,8 @@ BEGIN
 			JOIN itemCategory ic ON ic.id = tp.categoryFk
 			JOIN saleComponent sc ON sc.saleFk = s.id
 			JOIN component c ON c.id = sc.componentFk
-			JOIN componentType ct ON ct.id = c.typeFk AND ct.id = 1
+			JOIN componentType ct ON ct.id = c.typeFk
+				AND ct.code = 'cost'
 		WHERE t.shipped BETWEEN vShippedFrom AND vShippedTo
 			AND ic.merchandise;
 

db/routines/vn/procedures/ticket_getFromFloramondo.sql

@@ -66,7 +66,7 @@ BEGIN
 					JOIN vn.componentType ct ON ct.id = c.typeFk
 					JOIN vn.sale s ON s.id = sc.saleFk
 					JOIN tmp.ticket t ON t.ticketFk = s.ticketFk
-				WHERE ct.code = 'FREIGHT'
+				WHERE ct.code = 'freight'
 				GROUP BY t.ticketFk) sb ON sb.ticketFk = tf.ticketFk
 		SET tf.freight = sb.freight;
 
@@ -88,7 +88,7 @@ BEGIN
 
 	-- Margin
 	UPDATE tmp.ticketFloramondo tf
-		JOIN (SELECT SUM(IF(ct.code = 'COST',sc.value, 0)) cost,
+		JOIN (SELECT SUM(IF(ct.code = 'cost',sc.value, 0)) cost,
 					SUM(IF(ct.isMargin, sc.value, 0)) margin,
 					t.ticketFk
 				FROM vn.saleComponent sc

db/routines/vn/procedures/workerTimeControl_direction.sql

@@ -9,6 +9,8 @@ BEGIN
  */
 	DECLARE vLastIn DATETIME ;
 	DECLARE vIsMiddleOdd BOOLEAN ;
+	DECLARE vMailTo VARCHAR(50) DEFAULT NULL;
+	DECLARE vUserName VARCHAR(50) DEFAULT NULL;
 
 	IF (vTimed IS NULL) THEN 
 		SET vTimed = util.VN_NOW();
@@ -57,5 +59,18 @@ BEGIN
 			VALUES('in', NULL);
 	END IF;
 
+	IF (SELECT option1 IS NULL AND option2 IS NULL FROM  tmp.workerTimeControlDirection) THEN
+		SELECT CONCAT(u.name, '@verdnatura.es'), CONCAT(w.firstName, ' ', w.lastName)
+				INTO vMailTo, vUserName
+			FROM account.user u
+				JOIN worker w ON w.bossFk = u.id
+			WHERE w.id = vWorkerFk;
+
+		CALL mail_insert( 
+			vMailTo, 
+			vMailTo, 
+			'Error al fichar', 
+			CONCAT(vUserName, ' tiene problemas para fichar'));
+	END IF;
 END$$
 DELIMITER ;

db/routines/vn/triggers/entry_beforeUpdate.sql

@@ -11,11 +11,9 @@ BEGIN
 	IF NEW.isBooked = OLD.isBooked AND (
 			NOT (NEW.supplierFk <=> OLD.supplierFk) OR
 			NOT (NEW.dated <=> OLD.dated) OR
-			NOT (NEW.invoiceNumber <=> OLD.invoiceNumber) OR
 			NOT (NEW.travelFk <=> OLD.travelFk) OR
 			NOT (NEW.companyFk <=> OLD.companyFk) OR
 			NOT (NEW.invoiceInFk <=> OLD.invoiceInFk) OR
-			NOT (NEW.invoiceAmount <=> OLD.invoiceAmount) OR
 			NOT (NEW.typeFk <=> OLD.typeFk)
 		) THEN
 

db/routines/vn/views/saleCost.sql

@@ -19,4 +19,4 @@ FROM (
 		)
 		JOIN `vn`.`componentType` `ct` ON(`ct`.`id` = `c`.`typeFk`)
 	)
-WHERE `ct`.`type` = 'coste'
+WHERE `ct`.`code` = 'cost'

db/routines/vn/views/sale_freightComponent.sql

@@ -16,6 +16,6 @@ FROM (
 		)
 		JOIN `vn`.`componentType` `ct` ON(
 			`ct`.`id` = `c`.`typeFk`
-			AND `ct`.`type` = 'agencia'
+			AND `ct`.`code` = 'freight'
 		)
 	)

db/routines/vn2008/views/Tipos.sql

@@ -9,14 +9,9 @@ AS SELECT `it`.`id` AS `tipo_id`,
 	`it`.`workerFk` AS `Id_Trabajador`,
 	`it`.`life` AS `life`,
 	`it`.`isPackaging` AS `isPackaging`,
-	`it`.`density` AS `density`,
 	`it`.`isInventory` AS `inventory`,
 	`it`.`created` AS `odbc_date`,
 	`it`.`making` AS `confeccion`,
 	`it`.`temperatureFk` AS `Temperatura`,
-	`it`.`promo` AS `promo`,
+	`it`.`promo` AS `promo`
-	`it`.`maneuver` AS `maneuver`,
-	`it`.`target` AS `target`,
-	`it`.`topMargin` AS `top_margin`,
-	`it`.`profit` AS `profit`
 FROM `vn`.`itemType` `it`

db/routines/vn2008/views/buy_edi.sql

@@ -2,7 +2,6 @@ CREATE OR REPLACE DEFINER=`root`@`localhost`
 	SQL SECURITY DEFINER
 	VIEW `vn2008`.`buy_edi`
 AS SELECT `t`.`id` AS `id`,
-	`t`.`barcode` AS `barcode`,
 	`t`.`entryYear` AS `entry_year`,
 	`t`.`deliveryNumber` AS `delivery_number`,
 	`t`.`fec` AS `fec`,

db/versions/10986-pinkChrysanthemum/00-addSummaryId.sql

@@ -0,0 +1,22 @@
+ALTER TABLE vn.claimLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.clientLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.deviceProductionLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.entryLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.invoiceInLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.itemLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.packingSiteDeviceLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.parkingLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.rateLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.routeLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.shelvingLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.supplierLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.ticketLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.travelLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.userLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.workerLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE vn.zoneLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+
+ALTER TABLE account.userLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE account.signInLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE account.roleLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);
+ALTER TABLE account.accountLog ADD COLUMN IF NOT EXISTS summaryId varchar(30);

db/versions/11081-wheatRaphis/00-firstScript.sql

@@ -0,0 +1,8 @@
+-- Place your SQL code here
+
+USE vn;
+
+ALTER TABLE vn.roadmap ADD kmStart mediumint(9) DEFAULT NULL NULL;
+ALTER TABLE vn.roadmap ADD kmEnd mediumint(9) DEFAULT NULL NULL;
+ALTER TABLE vn.roadmap ADD started DATETIME NULL;
+ALTER TABLE vn.roadmap ADD finished DATETIME NULL;

db/versions/11118-limeCymbidium/00-firstScript.sql

@@ -0,0 +1,21 @@
+
+INSERT IGNORE INTO salix.ACL (`model`,`property`,`accessType`,`permission`,`principalType`,`principalId`)
+	VALUES ('Entry','filter','READ','ALLOW','ROLE','supplier');
+
+INSERT IGNORE INTO salix.ACL (`model`,`property`,`accessType`,`permission`,`principalType`,`principalId`)
+	VALUES ('Entry','getBuys','READ','ALLOW','ROLE','supplier');
+
+INSERT IGNORE INTO salix.ACL (`model`,`property`,`accessType`,`permission`,`principalType`,`principalId`)
+	VALUES ('Entry','buyLabel','READ','ALLOW','ROLE','supplier');
+
+INSERT IGNORE INTO `account`.`role` (`name`,`description`,`hasLogin`,`created`,`modified`)
+	VALUES ('supplier','Proveedores',1,'2017-10-10 14:58:58.000','2017-10-10 14:59:20.000');
+SET @supplierFk =LAST_INSERT_ID();
+INSERT IGNORE INTO account.roleInherit (`role`,`inheritsFrom`)
+	VALUES (@supplierFk,2);
+
+UPDATE salix.ACL
+	SET principalId='$authenticated'
+	WHERE id=264;
+
+

db/versions/11119-tealGerbera/00-firstScript.sql

@@ -0,0 +1,9 @@
+ALTER TABLE vn.componentType
+    CHANGE code code varchar(20) CHARACTER SET utf8mb3 COLLATE utf8mb3_unicode_ci DEFAULT NULL NULL AFTER id;
+ALTER TABLE vn.componentType
+    CHANGE `type` name varchar(45) CHARACTER SET utf8mb3 COLLATE utf8mb3_unicode_ci NOT NULL;
+UPDATE IGNORE vn.componentType
+	SET code = LOWER(code);
+UPDATE IGNORE vn.componentType
+	SET code = 'other'
+	WHERE id = 12;

db/versions/11120-brownTulip/00-firstScript.sql

@@ -0,0 +1,6 @@
+ALTER TABLE vn.itemType
+    CHANGE maneuver maneuver__ double DEFAULT 0.21 NOT NULL COMMENT '@deprecated 2024-07-01 refs #7418',
+    CHANGE target target__ double DEFAULT 0.15 NOT NULL COMMENT '@deprecated 2024-07-01 refs #7418',
+    CHANGE topMargin topMargin__ double DEFAULT 0.3 NOT NULL COMMENT '@deprecated 2024-07-01 refs #7418',
+    CHANGE profit profit__ double DEFAULT 0.02 NOT NULL COMMENT '@deprecated 2024-07-01 refs #7418',
+    CHANGE density density__ double DEFAULT 167 NOT NULL COMMENT '@deprecated 2024-07-01 refs #7418 Almacena el valor por defecto de la densidad en kg/m3 para el calculo de los portes aereos, en articulos se guarda la correcta';

db/versions/11128-turquoiseCymbidium/00-firstScript.sql

@@ -0,0 +1 @@
+ALTER TABLE vn.calendar ADD created timestamp DEFAULT current_timestamp() NOT NULL AFTER dated;

db/versions/11129-limeHydrangea/00-firstScript.sql

@@ -0,0 +1 @@
+ALTER TABLE vn.greuge CHANGE Id id int(10) unsigned auto_increment NOT NULL;

db/versions/11131-brownPhormium/00-firstScript.sql

@@ -0,0 +1 @@
+ALTER TABLE vn.itemShelving ADD isSplit tinyint(1) NULL COMMENT 'Este valor cambia al splitar un carro que se ha quedado en holanda';

db/versions/11134-silverRaphis/00-firstScript.sql

@@ -0,0 +1,42 @@
+USE `vn`;
+
+CREATE TABLE IF NOT EXISTS vn.`tillSerial` (
+  `code` varchar(2) COLLATE utf8mb3_unicode_ci NOT NULL,
+  `description` varchar(30) COLLATE utf8mb3_unicode_ci DEFAULT NULL,
+  `account` varchar(10) COLLATE utf8mb3_unicode_ci DEFAULT NULL,
+  PRIMARY KEY (`code`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci;
+
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES(' S', 'Saldos final / inicial', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('A', 'Factura cliente', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('B', 'Factura cliente', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('C', 'Facturas Contado', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('CC', 'Cuadre caja', '6780000000');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('CD', 'Cuenta Director Comercial', '5510000002');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('CH', 'Cheques', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('CM', 'Cambio', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('CR', 'Ingreso/Reintegro Caja Rural', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('CT', 'Correos y telégrafos', '6290000005');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('DC', 'Dietas conductores', '6290000010');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('DH', 'Deudas Holland', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('DT', 'Dietas', '6290000011');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('E', 'Entrada mercancia', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('EN', 'Enric Martinez', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('GC', 'Cuenta con dto. Comercial', '5510000003');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('GP', 'Gastos de personal', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('GR', 'Gastos RRPP dpto comercial', '6290001002');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('GS', 'Gasoil', '6280000002');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('GV', 'Gastos viaje', '6290001000');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('JV', 'Juanvi', '6290000553');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('MB', 'Movimiento bancario', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('MP', 'Materias Primas', '6000000000');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('OG', 'Otros gastos', '6290000000');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('PM', 'Pequeño material', '6290000007');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('R', 'Factura proveedor', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('RC', 'Ingreso/Reintegro Ruralcaja', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('RN', 'Reparación nave', '6220000004');
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('SS', 'Gastos Silla', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('T', 'Ticket', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('TA', 'Factura rapida', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('TC', 'Ticket contado', NULL);
+INSERT IGNORE vn.tillSerial (code, `description`, account) VALUES('TR', 'Traspaso', NULL);

db/versions/11137-salmonRoebelini/00-firstScript.sql

@@ -0,0 +1,4 @@
+ALTER TABLE vn.expeditionState
+    MODIFY COLUMN userFk INT(10) UNSIGNED,
+	ADD CONSTRAINT expeditionState_userFk FOREIGN KEY (userFk)
+		REFERENCES account.`user`(id);

db/versions/11138-aquaGalax/00-firstScript.sql

@@ -0,0 +1,8 @@
+ALTER TABLE `vn`.`claimDestination`
+ADD COLUMN `code` varchar(45) DEFAULT NULL;
+
+UPDATE IGNORE vn.claimDestination SET code='Good' WHERE description= 'Bueno';
+UPDATE IGNORE vn.claimDestination SET code='Garbage/Loss' WHERE description = 'Basura/Perd.';
+UPDATE IGNORE vn.claimDestination SET code='Manufacturing' WHERE description = 'Confeccion';
+UPDATE IGNORE vn.claimDestination SET code='Claim' WHERE description = 'Reclam.PRAG';
+UPDATE IGNORE vn.claimDestination SET code='Corrected' WHERE description = 'Corregido';

loopback/common/methods/application/spec/execute.spec.js

@@ -2,18 +2,9 @@ const models = require('vn-loopback/server/server').models;
 
 describe('Application execute()/executeProc()/executeFunc()', () => {
     const userWithoutPrivileges = 1;
-    const userWithPrivileges = 9;
     const userWithInheritedPrivileges = 120;
     let tx;
-
+    const ctx = beforeAll.getCtx();
-    function getCtx(userId) {
-        return {
-            req: {
-                accessToken: {userId},
-                headers: {origin: 'http://localhost'}
-            }
-        };
-    }
 
     beforeEach(async() => {
         tx = await models.Application.beginTransaction({});
@@ -42,7 +33,7 @@ describe('Application execute()/executeProc()/executeFunc()', () => {
     });
 
     it('should throw error when execute procedure and not have privileges', async() => {
-        const ctx = getCtx(userWithoutPrivileges);
+        const ctx = {req: {accessToken: {userId: userWithoutPrivileges}}};
 
         let error;
         try {
@@ -66,7 +57,6 @@ describe('Application execute()/executeProc()/executeFunc()', () => {
     });
 
     it('should execute procedure and get data', async() => {
-        const ctx = getCtx(userWithPrivileges);
         try {
             const options = {transaction: tx};
 
@@ -90,7 +80,6 @@ describe('Application execute()/executeProc()/executeFunc()', () => {
 
     describe('Application executeProc()', () => {
         it('should execute procedure and get data (executeProc)', async() => {
-            const ctx = getCtx(userWithPrivileges);
             try {
                 const options = {transaction: tx};
 
@@ -115,7 +104,6 @@ describe('Application execute()/executeProc()/executeFunc()', () => {
 
     describe('Application executeFunc()', () => {
         it('should execute function and get data', async() => {
-            const ctx = getCtx(userWithPrivileges);
             try {
                 const options = {transaction: tx};
 
@@ -137,7 +125,7 @@ describe('Application execute()/executeProc()/executeFunc()', () => {
         });
 
         it('should execute function and get data with user with inherited privileges', async() => {
-            const ctx = getCtx(userWithInheritedPrivileges);
+            const ctx = {req: {accessToken: {userId: userWithInheritedPrivileges}}};
             try {
                 const options = {transaction: tx};
 

loopback/common/methods/schema/model-info.js

@@ -92,6 +92,7 @@ module.exports = Self => {
             const locale = modelLocale && modelLocale.get(lang);
 
             json[modelName] = {
+                http: model.sharedClass.http.path,
                 properties: model.definition.rawProperties,
                 validations: jsonValidations,
                 locale

loopback/common/methods/vn-model/specs/crud.spec.js

@@ -1,20 +1,7 @@
 const app = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('Model crud()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
     let insertId;
     const barcodeModel = app.models.ItemBarcode;
 

loopback/common/methods/vn-model/specs/rewriteDbError.spec.js

@@ -1,20 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('Model rewriteDbError()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should extend rewriteDbError properties to any model passed', () => {
         const exampleModel = models.ItemTag;

modules/claim/back/methods/claim/specs/filter.spec.js

@@ -2,15 +2,7 @@ const app = require('vn-loopback/server/server');
 const models = require('vn-loopback/server/server').models;
 
 describe('claim filter()', () => {
-    let ctx;
+    const ctx = beforeAll.getCtx();
-    beforeEach(() => {
-        ctx = {
-            req: {
-                accessToken: {userId: 9},
-                headers: {origin: 'http://localhost'}
-            }
-        };
-    });
 
     it('should return 1 result filtering by id', async() => {
         const tx = await app.models.Claim.beginTransaction({});

modules/claim/back/methods/claim/specs/regularizeClaim.spec.js

@@ -1,18 +1,11 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('claim regularizeClaim()', () => {
     const userId = 18;
-    const ctx = {
+    const ctx = beforeAll.mockLoopBackContext(userId);
-        req: {
-            accessToken: {userId: userId},
-            headers: {origin: 'http://localhost'}
-        }
-    };
     ctx.req.__ = (value, params) => {
         return params.nickname;
     };
-
     const chatModel = models.Chat;
     const claimId = 1;
     const ticketId = 1;
@@ -40,20 +33,6 @@ describe('claim regularizeClaim()', () => {
         return await models.ClaimEnd.create(claimEnds, options);
     }
 
-    beforeAll(async() => {
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
-
     it('should send a chat message with value "Trash" and then change claim state to resolved', async() => {
         const tx = await models.Claim.beginTransaction({});
 

modules/claim/back/methods/claim/specs/updateClaim.spec.js

@@ -1,22 +1,10 @@
 const app = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 const i18n = require('i18n');
 describe('Update Claim', () => {
     let url;
     let claimStatesMap = {};
+    beforeAll.mockLoopBackContext();
     beforeAll(async() => {
-        url = await app.models.Url.getUrl();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
         const claimStates = await app.models.ClaimState.find();
         claimStatesMap = claimStates.reduce((acc, state) => ({...acc, [state.code]: state.id}), {});
     });

modules/claim/back/methods/claim/specs/updateClaimAction.spec.js

@@ -1,20 +1,7 @@
 const app = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('Update Claim', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
     const newDate = Date.vnNew();
     const original = {
         ticketFk: 3,

modules/client/back/methods/client/specs/addressesPropagateRe.spec.js

@@ -1,23 +1,10 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('Client addressesPropagateRe', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
 
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
+    it('should propagate the isEqualizated on both addresses of Mr Wayne' +
-            active: activeCtx
+        ' and set hasToInvoiceByAddress to false', async() => {
-        });
-    });
-
-    it('should propagate the isEqualizated on both addresses of Mr Wayne and set hasToInvoiceByAddress to false', async() => {
         const tx = await models.Client.beginTransaction({});
 
         try {

modules/client/back/methods/client/specs/createAddress.spec.js

@@ -1,5 +1,4 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('Address createAddress', () => {
     const clientFk = 1101;
@@ -7,20 +6,7 @@ describe('Address createAddress', () => {
     const incotermsFk = 'FAS';
     const customAgentOneId = 1;
 
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should throw a non uee member error if no incoterms is defined', async() => {
         const tx = await models.Client.beginTransaction({});

modules/client/back/methods/client/specs/createWithUser.spec.js

@@ -1,6 +1,4 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
-
 describe('Client Create', () => {
     const newAccount = {
         userName: 'deadpool',
@@ -16,20 +14,7 @@ describe('Client Create', () => {
     const newAccountWithoutEmail = JSON.parse(JSON.stringify(newAccount));
     delete newAccountWithoutEmail.email;
 
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it(`should not find deadpool as he's not created yet`, async() => {
         const tx = await models.Client.beginTransaction({});

modules/client/back/methods/client/specs/getCard.spec.js

@@ -1,11 +1,11 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('Client getCard()', () => {
+    const ctx = beforeAll.getCtx();
     it('should receive a formated card of Bruce Wayne', async() => {
         const tx = await models.Client.beginTransaction({});
 
         try {
-            const ctx = {req: {accessToken: {userId: 9}}};
             const options = {transaction: tx};
 
             const id = 1101;

modules/client/back/methods/client/specs/getDebt.spec.js

@@ -1,9 +1,9 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('client getDebt()', () => {
+    const ctx = beforeAll.getCtx();
     it('should return the client debt', async() => {
         const tx = await models.Client.beginTransaction({});
-        const ctx = {req: {accessToken: {userId: 9}}};
 
         try {
             const options = {transaction: tx};

modules/client/back/methods/client/specs/sendSms.spec.js

@@ -1,12 +1,12 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('client sendSms()', () => {
+    const ctx = beforeAll.getCtx();
     it('should now send a message and log it', async() => {
         const tx = await models.Client.beginTransaction({});
 
         try {
             const options = {transaction: tx};
-            const ctx = {req: {accessToken: {userId: 9}}};
             const id = 1101;
             const destination = 222222222;
             const message = 'this is the message created in a test';

modules/client/back/methods/client/specs/summary.spec.js

@@ -1,7 +1,7 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('client summary()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
     it('should return a summary object containing data', async() => {
         const clientId = 1101;
         const tx = await models.Client.beginTransaction({});

modules/client/back/methods/client/specs/updateAddress.spec.js

@@ -1,6 +1,4 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
-
 describe('Address updateAddress', () => {
     const clientId = 1101;
     const addressId = 1;
@@ -14,20 +12,7 @@ describe('Address updateAddress', () => {
         }
     };
 
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should throw the non uee member error if no incoterms is defined', async() => {
         const tx = await models.Client.beginTransaction({});

modules/client/back/models/specs/address.spec.js

@@ -1,24 +1,10 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('loopback model address', () => {
     let createdAddressId;
     const clientId = 1101;
 
-    const activeCtx = {
+    beforeAll.mockLoopBackContext();
-        accessToken: {userId: 9},
-        http: {
-            req: {
-                headers: {origin: 'http://localhost'}
-            }
-        }
-    };
-
-    beforeAll(() => {
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     afterAll(async() => {
         const client = await models.Client.findById(clientId);

modules/entry/back/methods/entry/buyLabel.js

@@ -29,7 +29,8 @@ module.exports = Self => {
         http: {
             path: '/:id/buy-label',
             verb: 'GET'
-        }
+        },
+        accessScopes: ['DEFAULT', 'read:multimedia']
     });
 
     Self.buyLabel = (ctx, id) => Self.printReport(ctx, id, 'buy-label');

modules/entry/back/methods/entry/filter.js

@@ -112,7 +112,6 @@ module.exports = Self => {
 
         if (typeof options == 'object')
             Object.assign(myOptions, options);
-
         const conn = Self.dataSource.connector;
         const where = buildFilter(ctx.args, (param, value) => {
             switch (param) {
@@ -146,7 +145,13 @@ module.exports = Self => {
             }
         });
         filter = mergeFilters(ctx.args.filter, {where});
-
+        const userId = ctx.req.accessToken.userId;
+        const client = await Self.app.models.Client.findById(userId, myOptions);
+        const supplier = await Self.app.models.Supplier.findOne({where: {nif: client.fi}}, myOptions);
+        if (supplier) {
+            if (!filter.where) filter.where = {};
+            filter.where[`e.supplierFk`] = supplier.id;
+        }
         const stmts = [];
         let stmt;
         stmt = new ParameterizedSQL(
@@ -158,7 +163,7 @@ module.exports = Self => {
                     e.invoiceNumber,
                     e.isBooked,
                     e.isExcludedFromAvailable,
-                    e.evaNotes AS observation,
+                    e.evaNotes observation,
                     e.isConfirmed,
                     e.isOrdered,
                     e.isRaid,
@@ -170,13 +175,19 @@ module.exports = Self => {
                     e.gestDocFk,
                     e.invoiceInFk,
                     t.landed,
-                    s.name AS supplierName,
+                    s.name supplierName,
-                    s.nickname AS supplierAlias,
+                    s.nickname supplierAlias,
-                    co.code AS companyCode,
+                    co.code companyCode,
-                    cu.code AS currencyCode
+                    cu.code currencyCode,
+                    t.shipped,
+                    t.landed,
+                    t.ref AS travelRef,
+                    t.warehouseInFk,
+                    w.name warehouseInName
                 FROM vn.entry e
                     JOIN vn.supplier s ON s.id = e.supplierFk
                     JOIN vn.travel t ON t.id = e.travelFk
+                    JOIN vn.warehouse w ON w.id = t.warehouseInFk
                     JOIN vn.company co ON co.id = e.companyFk
                     JOIN vn.currency cu ON cu.id = e.currencyFk`
         );

modules/entry/back/methods/entry/getBuys.js

@@ -1,7 +1,9 @@
+const UserError = require('vn-loopback/util/user-error');
+
 const mergeFilters = require('vn-loopback/util/filter').mergeFilters;
 
 module.exports = Self => {
-    Self.remoteMethod('getBuys', {
+    Self.remoteMethodCtx('getBuys', {
         description: 'Returns buys for one entry',
         accessType: 'READ',
         accepts: [{
@@ -27,13 +29,20 @@ module.exports = Self => {
         }
     });
 
-    Self.getBuys = async(id, filter, options) => {
+    Self.getBuys = async(ctx, id, filter, options) => {
+        const userId = ctx.req.accessToken.userId;
         const models = Self.app.models;
         const myOptions = {};
 
         if (typeof options == 'object')
             Object.assign(myOptions, options);
+        const client = await Self.app.models.Client.findById(userId, myOptions);
+        const supplier = await Self.app.models.Supplier.findOne({where: {nif: client.fi}}, myOptions);
+        if (supplier) {
+            const isEntryOwner = (await Self.findById(id)).supplierFk === supplier.id;
 
+            if (!isEntryOwner) throw new UserError('Access Denied');
+        }
         let defaultFilter = {
             where: {entryFk: id},
             fields: [
@@ -49,9 +58,23 @@ module.exports = Self => {
                 'buyingValue',
                 'price2',
                 'price3',
-                'printedStickers'
+                'printedStickers',
+                'entryFk'
+            ],
+            include: [{
+                relation: 'entry',
+                scope: {
+                    fields: [
+                        'id', 'supplierFk'
                     ],
                     include: {
+                        relation: 'supplier', scope: {
+                            fields: ['id']
+                        }
+                    }
+                }
+            },
+            {
                 relation: 'item',
                 scope: {
                     fields: [
@@ -82,9 +105,8 @@ module.exports = Self => {
                         }
                     }
                 }
-            }
+            }]
         };
-
         defaultFilter = mergeFilters(defaultFilter, filter);
 
         return models.Buy.find(defaultFilter, myOptions);

modules/entry/back/methods/entry/specs/addFromPackaging.spec.js

@@ -1,5 +1,4 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('entry addFromPackaging()', () => {
     const supplier = 442;
@@ -7,22 +6,10 @@ describe('entry addFromPackaging()', () => {
     const yesterday = new Date(today);
     yesterday.setDate(today.getDate() - 1);
 
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 49},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'},
-                },
-            },
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx,
-        });
-    });
 
     it('should create an incoming travel', async() => {
-        const ctx = {args: {isTravelReception: true, supplier}};
+        const ctx = {accessToken: {userId: 49}, args: {isTravelReception: true, supplier}};
         const tx = await models.Entry.beginTransaction({});
         const options = {transaction: tx};
 

modules/entry/back/methods/entry/specs/editLatestBuys.spec.js

@@ -1,21 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('Buy editLatestsBuys()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should change the value of a given column for the selected buys', async() => {
         const tx = await models.Buy.beginTransaction({});

modules/entry/back/methods/entry/specs/filter.spec.js

@@ -9,7 +9,8 @@ describe('Entry filter()', () => {
             const ctx = {
                 args: {
                     search: 1
-                }
+                },
+                req: {accessToken: {userId: 9}}
             };
 
             const result = await models.Entry.filter(ctx, options);
@@ -32,7 +33,8 @@ describe('Entry filter()', () => {
             const ctx = {
                 args: {
                     currencyFk: 1
-                }
+                },
+                req: {accessToken: {userId: 9}}
             };
 
             const result = await models.Entry.filter(ctx, options);
@@ -46,15 +48,15 @@ describe('Entry filter()', () => {
         }
     });
 
-    it('should return the entry matching the supplier', async() => {
+    describe('should return the entry matching the supplier', () => {
+        it('when userId is supplier ', async() => {
             const tx = await models.Entry.beginTransaction({});
             const options = {transaction: tx};
 
             try {
                 const ctx = {
-                args: {
+                    args: {},
-                    supplierFk: 2
+                    req: {accessToken: {userId: 1102}}
-                }
                 };
 
                 const result = await models.Entry.filter(ctx, options);
@@ -68,6 +70,53 @@ describe('Entry filter()', () => {
             }
         });
 
+        it('when userId is supplier fetching other supplier', async() => {
+            const tx = await models.Entry.beginTransaction({});
+            const options = {transaction: tx};
+
+            try {
+                const ctx = {
+                    args: {
+                        supplierFk: 1
+                    },
+                    req: {accessToken: {userId: 1102}}
+                };
+
+                const result = await models.Entry.filter(ctx, options);
+
+                expect(result.length).toEqual(6);
+
+                await tx.rollback();
+            } catch (e) {
+                await tx.rollback();
+                throw e;
+            }
+        });
+
+        it('when userId is not supplier', async() => {
+            const tx = await models.Entry.beginTransaction({});
+            const options = {transaction: tx};
+
+            try {
+                const ctx = {
+                    args: {
+                        supplierFk: 2
+                    },
+                    req: {accessToken: {userId: 9}}
+                };
+
+                const result = await models.Entry.filter(ctx, options);
+
+                expect(result.length).toEqual(6);
+
+                await tx.rollback();
+            } catch (e) {
+                await tx.rollback();
+                throw e;
+            }
+        });
+    });
+
     it('should return the entry matching the company', async() => {
         const tx = await models.Entry.beginTransaction({});
         const options = {transaction: tx};
@@ -76,7 +125,8 @@ describe('Entry filter()', () => {
             const ctx = {
                 args: {
                     companyFk: 442
-                }
+                },
+                req: {accessToken: {userId: 9}}
             };
 
             const result = await models.Entry.filter(ctx, options);
@@ -98,7 +148,8 @@ describe('Entry filter()', () => {
             const ctx = {
                 args: {
                     isBooked: true,
-                }
+                },
+                req: {accessToken: {userId: 9}}
             };
 
             const result = await models.Entry.filter(ctx, options);
@@ -121,7 +172,8 @@ describe('Entry filter()', () => {
                 args: {
                     reference: 'movement',
                     travelFk: '2'
-                }
+                },
+                req: {accessToken: {userId: 9}}
             };
 
             const result = await models.Entry.filter(ctx, options);

modules/entry/back/methods/entry/specs/getBuys.spec.js

@@ -1,13 +1,22 @@
+const UserError = require('vn-loopback/util/user-error');
 const models = require('vn-loopback/server/server').models;
 
 describe('entry getBuys()', () => {
     const entryId = 4;
-    it('should get the buys and items of an entry', async() => {
+    describe('should get the buys and items of an entry ', () => {
+        it('when is supplier and entry owner', async() => {
             const tx = await models.Entry.beginTransaction({});
             const options = {transaction: tx};
 
             try {
-            const result = await models.Entry.getBuys(entryId, options);
+                const ctx = {
+                    args: {
+                        search: 1
+                    },
+                    req: {accessToken: {userId: 2}}
+                };
+
+                const result = await models.Entry.getBuys(ctx, entryId, options);
 
                 const length = result.length;
                 const anyResult = result[Math.floor(Math.random() * Math.floor(length))];
@@ -21,4 +30,53 @@ describe('entry getBuys()', () => {
                 throw e;
             }
         });
+
+        it('when is supplier but not entry owner', async() => {
+            const tx = await models.Entry.beginTransaction({});
+            const options = {transaction: tx};
+            const entryId = 1;
+            try {
+                const ctx = {
+                    args: {
+                        search: 1
+                    },
+                    req: {accessToken: {userId: 1102}}
+                };
+
+                const result = await models.Entry.getBuys(ctx, entryId, options);
+
+                expect(result).toBeUndefined();
+            } catch (error) {
+                expect(error).toBeInstanceOf(UserError);
+                expect(error.message).toBe('Access Denied');
+            }
+        });
+
+        it('when is not supplier', async() => {
+            const tx = await models.Entry.beginTransaction({});
+            const options = {transaction: tx};
+
+            try {
+                const ctx = {
+                    args: {
+                        search: 1
+                    },
+                    req: {accessToken: {userId: 9}}
+                };
+
+                const result = await models.Entry.getBuys(ctx, entryId, options);
+
+                const length = result.length;
+                const anyResult = result[Math.floor(Math.random() * Math.floor(length))];
+
+                expect(result.length).toEqual(4);
+                expect(anyResult.item).toBeDefined();
+
+                await tx.rollback();
+            } catch (e) {
+                await tx.rollback();
+                throw e;
+            }
+        });
+    });
 });

modules/entry/back/methods/entry/specs/importBuysPreview.spec.js

@@ -1,14 +1,8 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
-const activeCtx = {accessToken: {userId: 9}};
 
 describe('entry importBuysPreview()', () => {
     const entryId = 1;
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should return the buys with the calculated packagingFk', async() => {
         const tx = await models.Entry.beginTransaction({});

modules/invoiceIn/back/methods/invoice-in-due-day/specs/new.spec.js

@@ -1,15 +1,7 @@
-const LoopBackContext = require('loopback-context');
 const models = require('vn-loopback/server/server').models;
 
 describe('invoiceInDueDay new()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should correctly create a new due day', async() => {
         const userId = 9;

modules/invoiceIn/back/methods/invoice-in/specs/clone.spec.js

@@ -1,24 +1,11 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('invoiceIn clone()', () => {
-    let ctx;
+    const ctx = beforeAll.getCtx();
     let options;
     let tx;
 
     beforeEach(async() => {
-        ctx = {
-            req: {
-                accessToken: {userId: 1},
-                headers: {origin: 'http://localhost'}
-            },
-            args: {}
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: ctx.req
-        });
-
         options = {transaction: tx};
         tx = await models.Sale.beginTransaction({});
         options.transaction = tx;
@@ -28,7 +15,8 @@ describe('invoiceIn clone()', () => {
         await tx.rollback();
     });
 
-    it('should return the cloned invoiceIn and also clone invoiceInDueDays and invoiceInTaxes if there are any referencing the invoiceIn', async() => {
+    it('should return the cloned invoiceIn and also clone invoiceInDueDays ' +
+        'and invoiceInTaxes if there are any referencing the invoiceIn', async() => {
         const clone = await models.InvoiceIn.clone(ctx, 1, false, options);
 
         expect(clone.supplierRef).toEqual('1234(2)');
@@ -51,7 +39,8 @@ describe('invoiceIn clone()', () => {
         expect(invoiceInDueDay.length).toEqual(2);
     });
 
-    it('should return the cloned invoiceIn and also clone invoiceInIntrastat and invoiceInTaxes if it is rectificative', async() => {
+    it('should return the cloned invoiceIn and also clone invoiceInIntrastat ' +
+        'and invoiceInTaxes if it is rectificative', async() => {
         const clone = await models.InvoiceIn.clone(ctx, 1, true, options);
 
         expect(clone.supplierRef).toEqual('1234(2)');

modules/invoiceIn/back/methods/invoice-in/specs/corrective.spec.js

@@ -1,24 +1,11 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('invoiceIn corrective()', () => {
-    let ctx;
+    const ctx = beforeAll.getCtx();
     let options;
     let tx;
 
     beforeEach(async() => {
-        ctx = {
-            req: {
-                accessToken: {userId: 9},
-                headers: {origin: 'http://localhost'}
-            },
-            args: {}
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: ctx.req
-        });
-
         options = {transaction: tx};
         tx = await models.Sale.beginTransaction({});
         options.transaction = tx;

modules/invoiceOut/back/methods/invoiceOut/specs/book.spec.js

@@ -1,7 +1,7 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('invoiceOut book()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
     const invoiceOutId = 5;
 
     it('should update the booked property', async() => {

modules/item/back/methods/fixed-price/specs/upsertFixedPrice.spec.js

@@ -1,24 +1,13 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('upsertFixedPrice()', () => {
     const now = Date.vnNew();
     const fixedPriceId = 1;
     let originalFixedPrice;
 
+    beforeAll.mockLoopBackContext();
     beforeAll(async() => {
         originalFixedPrice = await models.FixedPrice.findById(fixedPriceId);
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
     });
 
     it(`should toggle the hasMinPrice boolean if there's a minPrice and update the rest of the data`, async() => {

modules/item/back/methods/item-shelving/getListItemNewer.js

@@ -63,7 +63,7 @@ module.exports = Self => {
                     FROM tItemShelving ti
                         JOIN tItemInSector tis ON tis.itemFk = ti.itemFk
                         JOIN vn.productionConfig pc
-                    WHERE ti.created > tis.created + INTERVAL pc.itemOlderReviewHours HOUR;`,
+                    WHERE ti.created + INTERVAL pc.itemOlderReviewHours HOUR < tis.created ;`,
         [shelvingFk, shelvingFk], myOptions);
         return result;
     };

modules/item/back/methods/item-shelving/specs/getAlternative.spec.js

@@ -1,13 +1,7 @@
 const {models} = require('vn-loopback/server/server');
 
 describe('itemShelving getAlternative()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        ctx = {
-            req: {
-                headers: {origin: 'http://localhost'},
-            }
-        };
-    });
 
     it('should return a list of items without alternatives', async() => {
         const shelvingFk = 'HEJ';

modules/item/back/methods/item-shelving/specs/getListItemNewer.spec.js

@@ -3,29 +3,16 @@ const {models} = require('vn-loopback/server/server');
 
 describe('itemShelving getListItemNewer()', () => {
     it('should return true because there is an older item', async() => {
-        const shelving = 'NCC';
+        const shelving = 'NBB';
-        const parking = 'A-47-1';
+        const parking = '700-01';
 
-        const sectorCamHighCode = 'CAMARA SECTOR D';
+        const sectorCamHighCode = 'FIRST';
-        const sectorCamCode = 'NAVE ALGEMESI';
+        const sectorCamCode = 'NS';
-
-        const sectorCamCodeHighId = 1;
-        const sectorCamCodeId = 9991;
 
         const tx = await models.Sector.beginTransaction({});
         const myOptions = {transaction: tx};
 
         try {
-            const sectorHighCam = await models.Sector.findById(sectorCamCodeHighId, null, myOptions);
-            await sectorHighCam.updateAttributes({
-                code: sectorCamHighCode
-            });
-
-            const sectorCam = await models.Sector.findById(sectorCamCodeId, null, myOptions);
-            await sectorCam.updateAttributes({
-                code: sectorCamCode
-            });
-
             const config = await models.ProductionConfig.findOne();
 
             await config.updateAttributes({
@@ -35,7 +22,7 @@ describe('itemShelving getListItemNewer()', () => {
 
             const result = await models.ItemShelving.getListItemNewer(shelving, parking, myOptions);
 
-            expect(result.length).toEqual(2);
+            expect(result.length).toEqual(3);
             await tx.rollback();
         } catch (e) {
             await tx.rollback();

modules/item/back/methods/item-shelving/specs/upsertItem.spec.js

@@ -1,25 +1,13 @@
 const {models} = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('ItemShelving upsertItem()', () => {
     const warehouseFk = 1;
-    let ctx;
+
+    const ctx = beforeAll.getCtx();
     let options;
     let tx;
 
     beforeEach(async() => {
-        ctx = {
-            req: {
-                accessToken: {userId: 9},
-                headers: {origin: 'http://localhost'}
-            },
-            args: {}
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: ctx.req
-        });
-
         options = {transaction: tx};
         tx = await models.ItemShelving.beginTransaction({});
         options.transaction = tx;

modules/item/back/methods/item/specs/clone.spec.js

@@ -1,21 +1,8 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('item clone()', () => {
     let nextItemId;
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     beforeEach(async() => {
         let query = `SELECT i1.id + 1 as id FROM vn.item i1

modules/item/back/methods/item/specs/getBalance.spec.js

@@ -2,17 +2,14 @@ const models = require('vn-loopback/server/server').models;
 const LoopBackContext = require('loopback-context');
 
 describe('item getBalance()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
     it('should return the balance lines of a client type loses in which one has highlighted true', async() => {
         const tx = await models.Item.beginTransaction({});
         const options = {transaction: tx};
 
         try {
-            const activeCtx = {
-                accessToken: {userId: 9},
-            };
             spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-                active: activeCtx
+                active: ctx
             });
             const losesClientId = 1111;
             const ticket = await models.Ticket.findById(7, null, options);

modules/item/back/methods/item/specs/new.spec.js

@@ -1,21 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('item new()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
-    beforeAll(async() => {
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should create a new item, adding the name as a tag', async() => {
         const tx = await models.Item.beginTransaction({});

modules/item/back/methods/item/specs/regularize.spec.js

@@ -1,27 +1,13 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('regularize()', () => {
-    beforeAll(async() => {
+    const ctx = beforeAll.mockLoopBackContext(18);
-        const activeCtx = {
-            accessToken: {userId: 18},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should create a new ticket and add a line', async() => {
         const tx = await models.Item.beginTransaction({});
         const options = {transaction: tx};
 
         try {
-            const ctx = {req: {accessToken: {userId: 18}}};
             const itemId = 1;
             const warehouseId = 1;
             const quantity = 11;

modules/item/back/methods/item/specs/updateTaxes.spec.js

@@ -1,20 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('item updateTaxes()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should throw an error if the taxClassFk is blank', async() => {
         const tx = await models.Item.beginTransaction({});

modules/item/back/methods/tag/specs/onSubmit.spec.js

@@ -1,20 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('tag onSubmit()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     it('should delete a tag', async() => {
         const tx = await models.Item.beginTransaction({});

modules/order/back/methods/order-row/specs/addToOrder.spec.js

@@ -1,7 +1,7 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('order addToOrder()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
     const orderId = 8;
     it('should add a row to a given order', async() => {
         const tx = await models.Order.beginTransaction({});

modules/order/back/methods/order/specs/filter.spec.js

@@ -1,11 +1,7 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('order filter()', () => {
-    const ctx = {
+    const ctx = beforeAll.getCtx();
-        req: {accessToken: {userId: 9}},
-        args: {},
-        params: {}
-    };
 
     it('should call the filter method with a basic search', async() => {
         const myCtx = Object.assign({}, ctx);

modules/order/back/methods/order/specs/new.spec.js

@@ -2,7 +2,7 @@ const models = require('vn-loopback/server/server').models;
 const UserError = require('vn-loopback/util/user-error');
 
 describe('order new()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
     it('should throw an error if the client isnt active', async() => {
         const tx = await models.Order.beginTransaction({});
 

modules/order/back/methods/order/specs/newFromTicket.spec.js

@@ -1,7 +1,7 @@
 const models = require('vn-loopback/server/server').models;
 
 describe('order newFromTicket()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
     it('should create a new order from an existing ticket', async() => {
         const tx = await models.Order.beginTransaction({});
 

modules/route/back/methods/agency-term/specs/createInvoiceIn.spec.js

@@ -1,21 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('AgencyTerm createInvoiceIn()', () => {
-    const ctx = {req: {accessToken: {userId: 9}}};
+    const ctx = beforeAll.getCtx();
-    beforeAll(async() => {
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
     const rows = [
         {
             routeFk: 2,

modules/route/back/methods/roadmapStop/getPalletMatchState.js

@@ -0,0 +1,62 @@
+module.exports = Self => {
+    Self.remoteMethod('getPalletMatchState', {
+        description: 'Get list of pallet from truckFk with true or false if state is matched',
+        accessType: 'WRITE',
+        accepts: [{
+            arg: 'truckFk',
+            type: 'number',
+            required: true,
+            description: 'The truckFk id'
+        },
+        {
+            arg: 'state',
+            type: 'string',
+            required: true,
+            description: 'State code'
+        }],
+        returns: {
+            type: 'object',
+            root: true
+        },
+        http: {
+            path: `/getPalletMatchState`,
+            verb: 'GET'
+        }
+    });
+
+    Self.getPalletMatchState = async(truckFk, state, options) => {
+        const myOptions = {};
+
+        if (typeof options == 'object')
+            Object.assign(myOptions, options);
+
+        const result = await Self.rawSql(`
+                        WITH tPallet AS(
+                            SELECT ep.id pallet, e.id expedition, e.stateTypeFk
+                                FROM vn.expeditionPallet ep
+                                    JOIN vn.expeditionScan es ON es.palletFk = ep.id
+                                    JOIN expedition e ON e.id = es.expeditionFk
+                                WHERE ep.truckFk = ?
+                        ),totalPalletExpedition AS(
+                                SELECT t.*, COUNT(expedition) totalPalletExpedition
+                                    FROM tPallet t
+                                    GROUP BY expedition
+                        ),totalPalletExpeditionCode AS(
+                                SELECT t.*, COUNT(expedition) totalPalletExpeditionCode
+                                    FROM tPallet t
+                                        JOIN vn.expeditionStateType est ON est.id = t.stateTypeFk
+                                    WHERE code = ?
+                                    GROUP BY expedition
+                            )
+                        SELECT  t.pallet,
+                                tpe.totalPalletExpedition = tpec.totalPalletExpeditionCode hasMatchStateCode
+                            FROM tPallet t
+                                LEFT JOIN totalPalletExpedition tpe ON tpe.expedition = t.expedition
+                                LEFT JOIN totalPalletExpeditionCode tpec ON tpec.expedition = t.expedition
+                            GROUP BY t.pallet;`,
+        [truckFk, state],
+        myOptions);
+
+        return result;
+    };
+};

modules/route/back/methods/roadmapStop/specs/getPalletMatchState.spec.js

@@ -0,0 +1,11 @@
+const {models} = require('vn-loopback/server/server');
+
+describe('roadMapStop getPalletMatchState()', () => {
+    it('should return list of pallet with true or false if state is matched', async() => {
+        const truckFk = 1;
+        const state = 'ON DELIVERY';
+        const result = await models.RoadmapStop.getPalletMatchState(truckFk, state);
+
+        expect(result[0].hasMatchStateCode).toBe(1);
+    });
+});

modules/route/back/methods/route/specs/clone.spec.js

@@ -1,21 +1,7 @@
 const app = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('route clone()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     const createdDate = Date.vnNew();
     it('should throw an error if the amount of ids pased to the clone function do no match the database', async() => {

modules/route/back/methods/route/specs/guessPriority.spec.js

@@ -1,20 +1,9 @@
 const app = require('vn-loopback/server/server');
-const LoopBackContext = require('loopback-context');
 
 describe('route guessPriority()', () => {
     const targetRouteId = 7;
     let routeTicketsToRestore;
-
+    const ctx = beforeAll.getCtx();
-    const activeCtx = {
-        accessToken: {userId: 9},
-        __: () => {}
-    };
-
-    beforeAll(() => {
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
 
     afterAll(async() => {
         let restoreFixtures = [];
@@ -25,9 +14,6 @@ describe('route guessPriority()', () => {
     });
 
     it('should call guessPriority() then check all tickets in that route have their priorities defined', async() => {
-        const ctx = {
-            req: activeCtx
-        };
         routeTicketsToRestore = await app.models.Ticket.find({where: {routeFk: targetRouteId}});
 
         await app.models.Route.guessPriority(ctx, targetRouteId);

modules/route/back/methods/route/specs/updateWorkCenter.spec.js

@@ -1,20 +1,7 @@
 const models = require('vn-loopback/server/server').models;
-const LoopBackContext = require('loopback-context');
 
 describe('route updateWorkCenter()', () => {
-    beforeAll(async() => {
+    beforeAll.mockLoopBackContext();
-        const activeCtx = {
-            accessToken: {userId: 9},
-            http: {
-                req: {
-                    headers: {origin: 'http://localhost'}
-                }
-            }
-        };
-        spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
-            active: activeCtx
-        });
-    });
     const routeId = 1;
 
     it('should set the commission work center if the worker has workCenter', async() => {