verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #7531 Modify zone_getAddresses #2675

Merged
guillermo merged 5 commits from 7531-Modify-zone_getAddresses into dev 2024-07-30 10:02:12 +00:00
Conversation 0 Commits 5 Files Changed 1 +41 -26
1 changed files with 41 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4bef3e9107 - Show all commits

21
db/routines/vn/procedures/zone_getAddresses.sql
View File

@ -1,7 +1,8 @@
DELIMITER $$ DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`zone_getAddresses`( CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`zone_getAddresses`(
vSelf INT, vSelf INT,
vLanded DATE vDated DATE,
vDepartment INT
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-07-04 05:09:05 +00:00
Outdated
Review
Copy Link

vDepartmentFk

vDepartmentFk
) )
BEGIN BEGIN
/** /**
@ -12,6 +13,7 @@ BEGIN
* *
* @param vSelf Id de zona * @param vSelf Id de zona
* @param vDated Fecha de entrega * @param vDated Fecha de entrega
* @param vDepartment Departamento del trabajador
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-07-04 05:09:11 +00:00
Outdated
Review
Copy Link

vDepartmentFk Id de departamento

vDepartmentFk Id de departamento
* @return Un select * @return Un select
*/ */
CALL zone_getPostalCode(vSelf); CALL zone_getPostalCode(vSelf);
@ -22,8 +24,15 @@ BEGIN
WHERE id NOT IN ( WHERE id NOT IN (
ivanm marked this conversation as resolved
guillermo commented 2024-07-04 05:17:05 +00:00
Review
Copy Link

notHasTicket crec que te sobra

notHasTicket crec que te sobra
SELECT clientFk SELECT clientFk
FROM vn.ticket FROM vn.ticket
WHERE landed BETWEEN vLanded AND util.dayEnd(vLanded) WHERE landed BETWEEN vDated AND util.dayEnd(vDated)
) )
),
hasTicketShippedToday AS (
ivanm marked this conversation as resolved
guillermo commented 2024-07-04 05:10:07 +00:00
Review
Copy Link

hasTickets (today no es correcte perque li pots pasar una altra fetxa que no siga hui)

hasTickets (today no es correcte perque li pots pasar una altra fetxa que no siga hui)
SELECT clientFk,
ivanm marked this conversation as resolved
guillermo commented 2024-07-04 05:14:43 +00:00
Review
Copy Link

Aço queda mes net aixina:

		SELECT DISTINCT clientFk
			FROM vn.ticket
			WHERE shipped BETWEEN vDated AND util.dayEnd(vDated)
Aço queda mes net aixina: ``` SELECT DISTINCT clientFk FROM vn.ticket WHERE shipped BETWEEN vDated AND util.dayEnd(vDated) ```
IF (COUNT(*) > 0, TRUE, FALSE) hasTicketShipped
FROM vn.ticket
WHERE shipped BETWEEN vDated AND util.dayEnd(vDated)
ivanm marked this conversation as resolved
guillermo commented 2024-07-04 05:17:57 +00:00
Review
Copy Link

Si li preguntares i volia per shipped ok

Si li preguntares i volia per shipped ok
GROUP BY clientFk
) )
SELECT c.id clientFk, SELECT c.id clientFk,
c.name, c.name,
@ -32,8 +41,12 @@ BEGIN
c.salesPersonFk, c.salesPersonFk,
u.name username, u.name username,
aai.invoiced, aai.invoiced,
cnb.lastShipped cnb.lastShipped,
ht.hasTicketShipped
ivanm marked this conversation as resolved
guillermo commented 2024-07-04 05:15:40 +00:00
Review
Copy Link

IF(ht.clientFk, TRUE, FALSE) hasTicket

IF(ht.clientFk, TRUE, FALSE) hasTicket
FROM vn.client c FROM vn.client c
JOIN vn.worker w ON w.id = c.salesPersonFk
JOIN vn.workerDepartment wd ON wd.workerFk = w.id
JOIN vn.department d ON d.id = wd.departmentFk
JOIN notHasTicket ON notHasTicket.id = c.id JOIN notHasTicket ON notHasTicket.id = c.id
LEFT JOIN account.`user` u ON u.id = c.salesPersonFk LEFT JOIN account.`user` u ON u.id = c.salesPersonFk
JOIN vn.`address` a ON a.clientFk = c.id JOIN vn.`address` a ON a.clientFk = c.id
@ -45,10 +58,12 @@ BEGIN
LEFT JOIN vn.annualAverageInvoiced aai ON aai.clientFk = c.id LEFT JOIN vn.annualAverageInvoiced aai ON aai.clientFk = c.id
JOIN vn.clientType ct ON ct.code = c.typeFk JOIN vn.clientType ct ON ct.code = c.typeFk
JOIN vn.businessType bt ON bt.code = c.businessTypeFk JOIN vn.businessType bt ON bt.code = c.businessTypeFk
LEFT JOIN hasTicketShippedToday ht ON ht.clientFk = c.id
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-07-04 05:11:10 +00:00
Outdated
Review
Copy Link

hasTickets

hasTickets
WHERE a.isActive WHERE a.isActive
AND c.isActive AND c.isActive
AND ct.code = 'normal' AND ct.code = 'normal'
AND bt.code <> 'worker' AND bt.code <> 'worker'
AND d.id = vDepartment
ivanm marked this conversation as resolved Outdated
guillermo commented 2024-07-04 05:11:20 +00:00
Outdated
Review
Copy Link

vDepartmentFk

vDepartmentFk
GROUP BY c.id; GROUP BY c.id;
DROP TEMPORARY TABLE tmp.zoneNodes; DROP TEMPORARY TABLE tmp.zoneNodes;