verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

#7648 - Filter entries by days #2722

Merged
jsegarra merged 12 commits from 7648_myEntries_filter into dev 2024-07-15 09:22:35 +00:00
Conversation 1 Commits 12 Files Changed 6 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 47cff3f894 - Show all commits

6
modules/entry/back/methods/entry/filter.js
View File

@ -189,8 +189,7 @@ module.exports = Self => {
t.landed, t.landed,
t.ref AS travelRef, t.ref AS travelRef,
t.warehouseInFk, t.warehouseInFk,
w.name warehouseInName, w.name warehouseInName
util.VN_CURDATE()
FROM vn.entry e FROM vn.entry e
jgallego marked this conversation as resolved Outdated
jgallego commented 2024-07-12 05:49:03 +00:00
Outdated
Review
Copy Link

Para qué necesitas esta línea?

Para qué necesitas esta línea?
jsegarra commented 2024-07-12 12:27:39 +00:00
Outdated
Review
Copy Link

Está eliminada

Está eliminada
JOIN vn.supplier s ON s.id = e.supplierFk JOIN vn.supplier s ON s.id = e.supplierFk
JOIN vn.travel t ON t.id = e.travelFk JOIN vn.travel t ON t.id = e.travelFk
@ -201,12 +200,13 @@ module.exports = Self => {
); );
if (supplier) { if (supplier) {
jsegarra marked this conversation as resolved Outdated
jgallego commented 2024-07-14 07:44:36 +00:00
Outdated
Review
Copy Link

si pones <= no te puedes ahorar el interval + 1?

si pones <= no te puedes ahorar el interval + 1?
👀 1
const days = ctx.args.days ?? DEFAULT_INTERVAL_DAYS;
stmt.merge({ stmt.merge({
sql: ` sql: `
AND t.shipped < util.VN_CURDATE() + INTERVAL ? + 1 DAY AND t.shipped < util.VN_CURDATE() + INTERVAL ? + 1 DAY
jsegarra marked this conversation as resolved Outdated
jgallego commented 2024-07-12 05:53:00 +00:00
Outdated
Review
Copy Link

mira en otras secciones que tengamos parametros por defecto en los filter a ver como lo hemos gestionado los valores, para guardarlos, nose si @alexm tendra algun ejemplo de memoria

mira en otras secciones que tengamos parametros por defecto en los filter a ver como lo hemos gestionado los valores, para guardarlos, nose si @alexm tendra algun ejemplo de memoria
jsegarra commented 2024-07-12 06:52:39 +00:00
Outdated
Review
Copy Link

Okey, he hecho un cambio que a lo mejor era lo que hacia falta

Okey, he hecho un cambio que a lo mejor era lo que hacia falta
jsegarra commented 2024-07-12 12:27:55 +00:00
Outdated
Review
Copy Link

@jgallego es travel.shipped o landed?

@jgallego es travel.shipped o landed?
jgallego commented 2024-07-12 12:31:23 +00:00
Outdated
Review
Copy Link

shipped ellos quieren saber cuando sale

shipped ellos quieren saber cuando sale
AND t.shipped >= util.VN_CURDATE() AND t.shipped >= util.VN_CURDATE()
`, `,
params: Array(1).fill(ctx.args.days ?? DEFAULT_INTERVAL_DAYS) params: [days]
}); });
} }
stmt.merge(conn.makeSuffix(filter)); stmt.merge(conn.makeSuffix(filter));