From 05202e0b76d54881a56510d0c46ed1de2da48560 Mon Sep 17 00:00:00 2001
From: guillermo <guillermo@verdnatura.es>
Date: Fri, 12 Jul 2024 08:15:09 +0200
Subject: [PATCH] refactor: refs #7680 Added cursors

---
 db/routines/vn/procedures/sale_setProblem.sql | 30 +++++++++++++++----
 .../vn/procedures/ticket_setProblem.sql       | 29 ++++++++++++++----
 2 files changed, 47 insertions(+), 12 deletions(-)

diff --git a/db/routines/vn/procedures/sale_setProblem.sql b/db/routines/vn/procedures/sale_setProblem.sql
index 20319cc3f..689090051 100644
--- a/db/routines/vn/procedures/sale_setProblem.sql
+++ b/db/routines/vn/procedures/sale_setProblem.sql
@@ -5,14 +5,32 @@ CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `vn`.`sale_setProblem`(
 BEGIN
 /**
  * Update column sale.problem with a problem code
+ *
  * @param vProblemCode Code to set or unset
  * @table tmp.sale(saleFk, hasProblem)
  */
-	UPDATE sale s
-			JOIN tmp.sale ts ON ts.saleFk = s.id 
-		SET s.problem = CONCAT(
-			IF(ts.hasProblem,
-				CONCAT(s.problem, ',', vProblemCode),
-				REPLACE(s.problem, vProblemCode , '')));
+ 	DECLARE vSaleFk INT;
+	DECLARE vHasProblem INT;
+	DECLARE vDone BOOL;
+	DECLARE vSaleList CURSOR FOR SELECT saleFk, hasProblem FROM tmp.sale;
+	DECLARE CONTINUE HANDLER FOR NOT FOUND SET vDone = TRUE;
+
+	OPEN vSaleList;
+	l: LOOP
+		SET vDone = FALSE;
+		FETCH vSaleList INTO vSaleFk, vHasProblem;
+
+		IF vDone THEN
+			LEAVE l;
+		END IF;
+
+	UPDATE sale
+		SET problem = CONCAT(
+			IF(vHasProblem,
+				CONCAT(problem, ',', vProblemCode),
+				REPLACE(problem, vProblemCode , '')))
+		WHERE id = vSaleFk;
+	END LOOP;
+	CLOSE vSaleList;
 END$$
 DELIMITER ;
\ No newline at end of file
diff --git a/db/routines/vn/procedures/ticket_setProblem.sql b/db/routines/vn/procedures/ticket_setProblem.sql
index bab8f1f52..3d6e14516 100644
--- a/db/routines/vn/procedures/ticket_setProblem.sql
+++ b/db/routines/vn/procedures/ticket_setProblem.sql
@@ -9,11 +9,28 @@ BEGIN
  * @param vProblemCode Code to set or unset
  * @table tmp.ticket(ticketFk, hasProblem)
  */
-	UPDATE ticket t
-			JOIN tmp.ticket tt ON tt.ticketFk = t.id 
-		SET t.problem = CONCAT(
-			IF(tt.hasProblem,
-				CONCAT(problem, ',', vProblemCode),
-				REPLACE(problem, vProblemCode , '')));
+ 	DECLARE vTicketFk INT;
+	DECLARE vHasProblem INT;
+	DECLARE vDone BOOL;
+	DECLARE vTicketList CURSOR FOR SELECT ticketFk, hasProblem FROM tmp.ticket;
+	DECLARE CONTINUE HANDLER FOR NOT FOUND SET vDone = TRUE;
+
+	OPEN vTicketList;
+	l: LOOP
+		SET vDone = FALSE;
+		FETCH vTicketList INTO vTicketFk, vHasProblem;
+
+		IF vDone THEN
+			LEAVE l;
+		END IF;
+
+		UPDATE ticket
+			SET problem = CONCAT(
+				IF(vHasProblem,
+					CONCAT(problem, ',', vProblemCode),
+					REPLACE(problem, vProblemCode , '')))
+			WHERE id = vTicketFk;
+	END LOOP;
+	CLOSE vTicketList;
 END$$
 DELIMITER ;
\ No newline at end of file
-- 
2.40.1