verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#7867 - avoid deactivate user when is supplier #2860

Merged
jsegarra merged 2 commits from hotfix_nightTask_supplierDisable into master 2024-08-14 05:52:14 +00:00
Conversation 0 Commits 2 Files Changed 1 +3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a178c285c0 - Show all commits

3
db/routines/vn/procedures/client_userDisable.sql
View File

@ -21,6 +21,9 @@ BEGIN
AND a.id IS NULL
AND u.active
AND c.created < util.VN_CURDATE() - INTERVAL vMonths MONTH
AND u.role NOT IN (
SELECT id FROM `role` r WHERE r.name = 'supplier'
guillermo commented 2024-08-13 10:55:33 +00:00
Outdated
Review
Copy Link

Como es una sola tabla no hay que especificar el alias.
Además. como siempre va a retornar 1 registro, en vez de poner un IN yo pondría un =

AND NOT u.role = (SELECT id FROM `role` WHERE name = 'supplier')
Como es una sola tabla no hay que especificar el alias. Además. como siempre va a retornar 1 registro, en vez de poner un IN yo pondría un = ``` AND NOT u.role = (SELECT id FROM `role` WHERE name = 'supplier') ```
jsegarra commented 2024-08-13 11:17:28 +00:00
Outdated
Review
Copy Link

"Como es una sola tabla no hay que especificar el alias."...fallo mío por no refrescar la "Convención SQL"

"Como es una sola tabla no hay que especificar el alias."...fallo mío por no refrescar la "Convención SQL"
)
AND u.id NOT IN (
SELECT DISTINCT c.id
FROM client c