verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 69 Releases Wiki Activity

feat: refs #7524 no apply limit #2921

Merged
jorgep merged 8 commits from 7524-hotfix-addNoLimit into master 2024-09-10 14:48:21 +00:00
Conversation 0 Commits 8 Files Changed 2 +6 -4
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e3b51c81f9 - Show all commits

10
loopback/common/models/vn-model.js
View File

@ -28,7 +28,7 @@ module.exports = function(Self) {
});
this.beforeRemote('**', async ctx => {
if (ctx.method.noLimit || !this.hasFilter(ctx)) return;
if (!this.hasFilter(ctx)) return;
juan marked this conversation as resolved Outdated
juan commented 2024-09-10 14:16:35 +00:00
Outdated
Review
Copy Link

Comprobar ctx.method.noLimit en la función hasFilter para no repetir lógica

Comprobar `ctx.method.noLimit` en la función `hasFilter` para no repetir lógica
const defaultLimit = this.app.orm.selectLimit;
const filter = ctx.args.filter || {limit: defaultLimit};
@ -40,7 +40,7 @@ module.exports = function(Self) {
});
this.afterRemote('**', async ctx => {
if (ctx.method.noLimit || !this.hasFilter(ctx)) return;
if (!this.hasFilter(ctx)) return;
jorgep marked this conversation as resolved Outdated
juan commented 2024-09-10 14:16:40 +00:00
Outdated
Review
Copy Link

Comprobar ctx.method.noLimit en la función hasFilter para no repetir lógica

Comprobar `ctx.method.noLimit` en la función `hasFilter` para no repetir lógica
const {result} = ctx;
const length = Array.isArray(result) ? result.length : result ? 1 : 0;
@ -349,8 +349,10 @@ module.exports = function(Self) {
},
hasFilter(ctx) {
return ctx.req.method.toUpperCase() === 'GET' &&
ctx.method.accepts.some(x => x.arg === 'filter' && x.type.toLowerCase() === 'object');
const {method, req} = ctx;
if (method.noLimit) return false;
return req.method.toUpperCase() === 'GET' &&
method.accepts.some(x => x.arg === 'filter' && x.type.toLowerCase() === 'object');
},
});
};