modules/worker/back/methods/worker-dms/filter.js

@@ -8,19 +8,19 @@ module.exports = Self => {
         accepts: [
             {
                 arg: 'id',
-                type: 'Number',
+                type: 'number',
                 description: 'The worker id',
                 http: {source: 'path'}
             },
             {
                 arg: 'filter',
-                type: 'Object',
+                type: 'object',
                 description: 'Filter defining where, order, offset, and limit - must be a JSON-encoded string',
                 http: {source: 'query'}
             }
         ],
         returns: {
-            type: ['Object'],
+            type: ['object'],
             root: true
         },
         http: {
@@ -36,6 +36,7 @@ module.exports = Self => {
 
         // Get ids alloweds
         const account = await models.VnUser.findById(userId);
+
         const stmt = new ParameterizedSQL(
             `SELECT d.id, d.id dmsFk
                 FROM workerDocument wd
@@ -44,30 +45,40 @@ module.exports = Self => {
                     LEFT JOIN account.roleRole rr ON rr.inheritsFrom = dt.readRoleFk AND rr.role = ?
                 `, [account.roleFk]
         );
-        const yourOwnDms = {and: [{isReadableByWorker: true}, {worker: userId}]};
-        const where = {
-            or: [yourOwnDms, {
+        const yourOwnDms = {
+            or: [
+                {and: [
+                    {isReadableByWorker: true},
+                    {worker: userId}
+                ]},
+                {
                     role: {
                         neq: null
                     }
                 }]
         };
-        stmt.merge(conn.makeSuffix(mergeWhere(filter.where, where)));
 
-        // Get workerDms alloweds
+        const where = mergeWhere(filter.where, yourOwnDms);
+        stmt.merge(conn.makeSuffix({where}));
         const dmsIds = await conn.executeStmt(stmt);
+
         const allowedIds = dmsIds.map(dms => dms.id);
         const allowedFilter = mergeFilters(filter, {where: {dmsFk: {inq: allowedIds}, workerFk: id}});
-        let workerDms = await models.WorkerDms.find(allowedFilter);
 
-        // Get docuware info
-        const docuware = await models.Docuware.findOne({
+        const workerDms = await models.WorkerDms.find(allowedFilter);
+
+        const workerDocuware = filter.skip ? [] : await getDocuware(ctx, id);
+        return workerDms.concat(workerDocuware);
+
+        async function getDocuware(ctx, id) {
+            const {dmsTypeFk} = await models.Docuware.findOne({
                 fields: ['dmsTypeFk'],
                 where: {code: 'hr', action: 'find'}
             });
-        const docuwareDmsType = docuware.dmsTypeFk;
+
+            if (!await models.DmsType.hasReadRole(ctx, dmsTypeFk)) return [];
+
             let workerDocuware = [];
-        if (!filter.skip && (!docuwareDmsType || (docuwareDmsType && await models.DmsType.hasReadRole(ctx, docuwareDmsType)))) {
             const worker = await models.Worker.findById(id, {fields: ['fi', 'firstName', 'lastName']});
             const docuwareParse = {
                 'Filename': 'dmsFk',
@@ -105,7 +116,7 @@ module.exports = Self => {
                 };
                 Object.assign(document, defaultData);
             }
+            return workerDocuware;
         }
-        return workerDms.concat(workerDocuware);
     };
 };