fix: refs #7028 fix confirm deny #3290

Merged
carlossa merged 23 commits from 7028-itemRequestConfDeny into dev 2024-12-16 10:59:56 +00:00
2 changed files with 6 additions and 3 deletions
Showing only changes of commit cd214b3526 - Show all commits

View File

@ -394,5 +394,7 @@
"Price cannot be blank": "Price cannot be blank",
"An item type with the same code already exists": "Un tipo con el mismo código ya existe",
"Holidays to past days not available": "Las vacaciones a días pasados no están disponibles",
"Worker not found": "Trabajador no encontrado"
"Worker not found": "Trabajador no encontrado",
"Invalid request or related ticket/client data": "Solicitud no válida o datos de ticket/cliente relacionados"
}

View File

@ -1,3 +1,4 @@
const UserError = require('vn-loopback/util/user-error');
module.exports = Self => {
Self.remoteMethodCtx('deny', {
description: 'Sets a ticket request to denied and returns the changes',
@ -43,7 +44,7 @@ module.exports = Self => {
try {
const userId = ctx.req.accessToken.userId;
carlossa marked this conversation as resolved Outdated
Outdated
Review

findById

findById
const worker = await models.Worker.findById(userId, myOptions);
carlossa marked this conversation as resolved Outdated
Outdated
Review

Traducir

Traducir
Outdated
Review

(userId, {fields: ...}, myOptions);

`(userId, {fields: ...}, myOptions);`
if (!worker) throw new Error('Worker not found');
if (!worker) throw new UserError('Worker not found');
const params = {
isOk: false,
@ -66,7 +67,7 @@ module.exports = Self => {
}, myOptions);
Outdated
Review

const salesPerson

const salesPerson
if (!request || !request.ticket() || !request.ticket().client())
throw new Error('Invalid request or related ticket/client data');
throw new UserError('Invalid request or related ticket/client data');
const url = await models.Url.getUrl();
const requesterId = request.ticket().client().salesPersonFk;