verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

2510-client-address-create-test #418

Merged
jgallego merged 11 commits from 2510-client-address-create-test into dev 2020-11-02 07:53:55 +00:00
Conversation 0 Commits 11 Files Changed 18 +668 -352
jgallego commented 2020-10-20 15:37:01 +00:00
Owner
Copy Link
No description provided.
carlosjr requested changes 2020-10-30 10:19:09 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
modules/ticket/back/methods/ticket/specs/componentUpdate.spec.js
@ -100,0 +129,4 @@
ticketFk: ticketID,
observationTypeFk: observationTypeDelivery.id}
});
carlosjr commented 2020-10-30 10:16:36 +00:00
Contributor
Copy Link

expect ticketObservation toBeDefined

expect ticketObservation toBeDefined
carlosjr marked this conversation as resolved
modules/ticket/back/methods/ticket/specs/componentUpdate.spec.js
@ -100,0 +151,4 @@
observationTypeFk: observationTypeDelivery.id}
});
expect(restoredTicketObservation.description).toEqual(ticketObservation.description);
carlosjr commented 2020-10-30 10:18:16 +00:00
Contributor
Copy Link

originalTicketObervation

originalTicketObervation
carlosjr marked this conversation as resolved
carlosjr approved these changes 2020-10-30 16:30:50 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
jgallego merged commit e81aef74a9 into dev 2020-11-02 07:53:55 +00:00
jgallego deleted branch 2510-client-address-create-test 2020-11-02 07:54:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#418
No description provided.
Delete Branch "2510-client-address-create-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?