verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

2575-image_download #448

Merged
joan merged 14 commits from 2575-image_download into dev 2020-11-18 10:36:17 +00:00
Conversation 0 Commits 14 Files Changed 20 +8 -5
4 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a060ac5c70 - Show all commits

7
back/methods/image/specs/download.spec.js
View File

@ -1,17 +1,18 @@
const app = require('vn-loopback/server/server'); const app = require('vn-loopback/server/server');
fdescribe('image download()', () => { describe('image download()', () => {
const collection = 'user'; const collection = 'user';
const size = '160x160'; const size = '160x160';
it('should return the image content-type of the user', async() => { it('should return the image content-type of the user', async() => {
const userId = 9; const userId = 9;
const image = await app.models.Image.download(collection, size, userId); const image = await app.models.Image.download(collection, size, userId);
const contentType = image[1];
bernat marked this conversation as resolved
carlosjr commented 2020-11-10 11:37:38 +00:00
Review
Copy Link

expect(contentType).toEqual....

expect(contentType).toEqual....
expect(image[1]).toEqual('image/png'); expect(contentType).toEqual('image/png');
}); });
bernat marked this conversation as resolved Outdated
carlosjr commented 2020-11-10 11:39:45 +00:00
Outdated
Review
Copy Link

doesn't

doesn't
it(`should return false if the user don't have image`, async() => { it(`should return false if the user doesn't have image`, async() => {
const userId = 110; const userId = 110;
const image = await app.models.Image.download(collection, size, userId); const image = await app.models.Image.download(collection, size, userId);

2
e2e/helpers/selectors.js
View File

@ -2,7 +2,7 @@
export default { export default {
globalItems: { globalItems: {
applicationsMenuButton: '#apps', applicationsMenuButton: '#apps',
userMenuButton: 'div.side.end img', userMenuButton: '#user',
bernat marked this conversation as resolved Outdated
carlosjr commented 2020-11-10 12:35:05 +00:00
Outdated
Review
Copy Link

please add the id to the element.

please add the id to the element.
logoutButton: '#logout', logoutButton: '#logout',
applicationsMenuVisible: '.modules-menu', applicationsMenuVisible: '.modules-menu',
clientsButton: '.modules-menu [ui-sref="client.index"]', clientsButton: '.modules-menu [ui-sref="client.index"]',

3
e2e/paths/07-order/04_catalog.spec.js
View File

@ -1,7 +1,7 @@
import selectors from '../../helpers/selectors.js'; import selectors from '../../helpers/selectors.js';
import getBrowser from '../../helpers/puppeteer'; import getBrowser from '../../helpers/puppeteer';
describe('Order catalog', () => { fdescribe('Order catalog', () => {
let browser; let browser;
let page; let page;
@ -40,6 +40,7 @@ describe('Order catalog', () => {
it('should perfom an "OR" search for the item tag colors silver and brown', async() => { it('should perfom an "OR" search for the item tag colors silver and brown', async() => {
await page.waitToClick(selectors.orderCatalog.openTagSearch); await page.waitToClick(selectors.orderCatalog.openTagSearch);
await page.autocompleteSearch(selectors.orderCatalog.tag, 'Color'); await page.autocompleteSearch(selectors.orderCatalog.tag, 'Color');
await page.wait(2999);
await page.autocompleteSearch(selectors.orderCatalog.firstTagAutocomplete, 'silver'); await page.autocompleteSearch(selectors.orderCatalog.firstTagAutocomplete, 'silver');
await page.waitToClick(selectors.orderCatalog.addTagButton); await page.waitToClick(selectors.orderCatalog.addTagButton);
await page.autocompleteSearch(selectors.orderCatalog.secondTagAutocomplete, 'brown'); await page.autocompleteSearch(selectors.orderCatalog.secondTagAutocomplete, 'brown');

1
front/salix/components/layout/index.html
View File

@ -33,6 +33,7 @@
</vn-icon-button> </vn-icon-button>
<button class="buttonAccount"> <button class="buttonAccount">
<img <img
bernat marked this conversation as resolved
carlosjr commented 2020-11-10 12:36:02 +00:00
Review
Copy Link

please add the id to the element.

please add the id to the element.
id="user"
ng-src="{{$ctrl.getImageUrl()}}" ng-src="{{$ctrl.getImageUrl()}}"
ng-click="userPopover.show($event)" ng-click="userPopover.show($event)"
translate-attr="{title: 'Account'}" translate-attr="{title: 'Account'}"