verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 56 Releases Wiki Activity

2940-invoiceInTax-section #680

Merged
joan merged 36 commits from 2940-invoiceInTax-section into dev 2021-08-13 06:11:07 +00:00
Conversation 0 Commits 36 Files Changed 29 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 92c3a24b1b - Show all commits

6
modules/invoiceIn/front/summary/index.html
View File

@ -46,14 +46,14 @@
</vn-vertical>
</vn-one>
<vn-one tbody class="taxes">
<span td class="chip"><vn-label translate>Taxable base</vn-label> {{$ctrl.summary.totals.totalTaxableBase | currency: 'EUR':2}}</span>
<p><vn-label translate>Total</vn-label> {{$ctrl.summary.totals.totalVat | currency: 'EUR':2}}</p>
<span td class="chip"><vn-label translate>Taxable base</vn-label> {{$ctrl.summary.totals.totalTaxableBase | currency: 'EUR':2 | dashIfEmpty}}</span>
<p><vn-label translate>Total</vn-label> {{$ctrl.summary.totals.totalVat | currency: 'EUR':2 | dashIfEmpty}}</p>
<vn-label translate>Due day</vn-label>
<vn-chip
class="transparent"
ng-class="{'alert': $ctrl.amountsNotMatch}"
joan marked this conversation as resolved Outdated
carlosjr commented 2021-06-29 11:07:20 +00:00
Outdated
Review
Copy Link

extraction to a getter would be nice, making it more readable.

Also using translate-attr with spanish tittle is inconsistent.

extraction to a getter would be nice, making it more readable. Also using translate-attr with spanish tittle is inconsistent.
translate-attr="{title: $ctrl.amountsNotMatch ? 'Do not match' : 'Due day'}"
>{{$ctrl.summary.totals.totalDueDay | currency: 'EUR':2}}
>{{$ctrl.summary.totals.totalDueDay | currency: 'EUR':2 | dashIfEmpty}}
</vn-chip>
</vn-one>
</vn-horizontal>