verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

3338-worker_calendar #787

Merged
carlosjr merged 8 commits from 3338-worker_calendar into dev 2021-11-22 13:30:27 +00:00
Conversation 0 Commits 8 Files Changed 4 +47
vicent commented 2021-11-18 07:22:02 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2021-11-18 07:22:02 +00:00
vicent added 4 commits 2021-11-18 07:22:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
180fb95a00 feat(createAbsence): add backTest
gitea/salix/pipeline/head This commit looks good Details
00a33fabb3 update backTest
carlosjr added 1 commit 2021-11-18 14:01:43 +00:00
gitea/salix/pipeline/head This commit looks good Details
c1adba3249 Merge branch 'dev' into 3338-worker_calendar
carlosjr requested changes 2021-11-18 14:08:47 +00:00
modules/worker/back/methods/worker/specs/createAbsence.spec.js Outdated
@ -75,2 +75,4 @@
}
});
it('should return an error trying to create a "Half holiday" absence', async() => {
carlosjr commented 2021-11-18 14:04:26 +00:00
Contributor
Copy Link

it('should return an error trying to create a "Half holiday" twice', async() => {

it('should return an error trying to create a "Half holiday" twice', async() => {
carlosjr marked this conversation as resolved
modules/worker/back/methods/worker/specs/createAbsence.spec.js
@ -77,0 +98,4 @@
expect(error.message).toEqual(`Cannot add more than one '1/2 day vacation'`);
});
expect(error).toBeDefined();
carlosjr commented 2021-11-18 14:08:43 +00:00
Contributor
Copy Link

this line of code is not needed if the error definition is at the level of the test error handler

this line of code is not needed if the error definition is at the level of the test error handler
carlosjr marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2021-11-18 14:09:43 +00:00
vicent added 2 commits 2021-11-22 12:34:56 +00:00
vicent added the
CR / Tests passed
 label 2021-11-22 12:39:47 +00:00
carlosjr approved these changes 2021-11-22 13:17:42 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2021-11-22 13:19:03 +00:00
gitea/salix/pipeline/head This commit looks good Details
dd19ac975d Merge branch 'dev' into 3338-worker_calendar
carlosjr merged commit 79181c633a into dev 2021-11-22 13:30:27 +00:00
carlosjr deleted branch 3338-worker_calendar 2021-11-22 13:30:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#787
No description provided.
Delete Branch "3338-worker_calendar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?