verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

3430-ticket_step-two ticket without negatives #823

Merged
joan merged 31 commits from 3430-ticket_step-two into dev 2022-02-01 08:34:41 +00:00
Conversation 0 Commits 31 Files Changed 13 +399 -22
alexm commented 2021-12-16 07:33:55 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
 label 2021-12-16 07:33:55 +00:00
alexm added 4 commits 2021-12-16 07:33:55 +00:00
gitea/salix/pipeline/head This commit looks good Details
3e91929d0d half test
gitea/salix/pipeline/head This commit looks good Details
87f994aa77 test(ticket_basci-data_step-two): back and front
alexm added 1 commit 2021-12-17 11:39:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
850ea2ef39 getVisible sql
alexm added 1 commit 2021-12-20 08:35:29 +00:00
alexm added 1 commit 2021-12-20 12:50:46 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b0019d09ad feat(ticket_basic-data_step-two): adapted for available and transfer sales in back
alexm added 1 commit 2021-12-20 12:51:09 +00:00
alexm removed the
CR / Tests passed
 label 2021-12-20 12:51:24 +00:00
alexm added 2 commits 2021-12-21 19:59:22 +00:00
gitea/salix/pipeline/head This commit looks good Details
18b6efe8f1 test(ticket_basic-data): test and fixtures
alexm added 1 commit 2021-12-21 20:01:29 +00:00
alexm added 1 commit 2021-12-22 07:11:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
67dc5c2cbc refactor(ticket_basic-data): test e2e
alexm added 1 commit 2021-12-22 07:38:01 +00:00
gitea/salix/pipeline/head This commit looks good Details
1e6355cdde fixtures
alexm added 1 commit 2022-01-13 06:20:38 +00:00
alexm added 1 commit 2022-01-13 06:24:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
c90a2b6e5c update folder changes
alexm added 9 commits 2022-01-14 09:08:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
b27cfef267 .text-secundary is now $color-font-light
gitea/salix/pipeline/head This commit looks good Details
25e17ee340 Merge pull request '.text-secundary is now $color-font-light' (#848) from 3512-autocomplete_style into dev 
Reviewed-on: #848
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
a4d16a60e0 Removed salix icons color
gitea/salix/pipeline/head There was a failure building this commit Details
74d9b3f774 Removed package lock
gitea/salix/pipeline/head This commit looks good Details
220cb55e0f Upgraded nodejs to v14
gitea/salix/pipeline/head This commit looks good Details
dd122f7420 Downgraded node version for docker container
gitea/salix/pipeline/head This commit looks good Details
b86c32c97b fix(importBuy): prevent action
gitea/salix/pipeline/head This commit looks good Details
4aa6b2b6c0 fix(salixfont): removed font color
alexm added 1 commit 2022-01-17 06:14:49 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
61859a23c9 feat(ticket): getAdvanceable
alexm added 1 commit 2022-01-17 09:12:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
5824acf3bc change tests to advanceable
alexm added 1 commit 2022-01-17 12:37:41 +00:00
alexm added 1 commit 2022-01-17 13:50:45 +00:00
alexm added 1 commit 2022-01-18 11:48:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
8e1c3e107c refactor(ticket): advanceable code
alexm added 1 commit 2022-01-18 11:49:27 +00:00
gitea/salix/pipeline/head This commit looks good Details
9ddf11c6bc test(ticket): update to advanceable
alexm added 2 commits 2022-01-26 06:13:07 +00:00
alexm added 1 commit 2022-01-26 07:54:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
f8a0094321 word movible
alexm added 2 commits 2022-01-27 06:22:56 +00:00
alexm added 2 commits 2022-01-28 08:15:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
b25ffa8feb feat(ticket_step-two): redirect to new ticket
alexm added the
CR / Tests passed
 label 2022-01-28 08:26:22 +00:00
alexm changed title from WIP: 3430-ticket_step-two to 3430-ticket_step-two ticket without negatives 2022-01-28 08:26:46 +00:00
joan requested changes 2022-01-31 16:08:08 +00:00
loopback/locale/en.json
@ -120,5 +120,6 @@
"This item is not available": "This item is not available",
"Deny buy request": "Purchase request for ticket id [{{ticketId}}]({{{url}}}) has been rejected. Reason: {{observation}}",
"The type of business must be filled in basic data": "The type of business must be filled in basic data",
"isWithoutNegatives": "isWithoutNegatives",
joan commented 2022-01-31 15:57:21 +00:00
Contributor
Copy Link

this should be translated or removed?

this should be translated or removed?
alexm marked this conversation as resolved
loopback/locale/es.json Outdated
@ -220,2 +220,3 @@
"Can't transfer claimed sales": "No puedes transferir lineas reclamadas",
"You don't have privileges to create pay back": "No tienes permisos para crear un abono"
"You don't have privileges to create pay back": "No tienes permisos para crear un abono",
"isWithoutNegatives": "isWithoutNegatives"
joan commented 2022-01-31 15:57:26 +00:00
Contributor
Copy Link

this should be translated or removed?

this should be translated or removed?
alexm marked this conversation as resolved
modules/ticket/back/methods/ticket/componentUpdate.js Outdated
@ -158,3 +176,3 @@
const hasToBeUnrouted = true;
const query = 'CALL vn.ticket_componentMakeUpdate(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)';
const res = await Self.rawSql(query, [
let res = await Self.rawSql(query, [
joan commented 2022-01-31 15:56:36 +00:00
Contributor
Copy Link

Adding properties to an object doesn't change the object.

Adding properties to an object doesn't change the object.
alexm marked this conversation as resolved
joan requested changes 2022-01-31 16:09:12 +00:00
modules/ticket/front/basic-data/step-two/locale/es.yml Outdated
@ -7,2 +7,3 @@
Price difference: Diferencia de precio
No newline at end of file
Price difference: Diferencia de precio
Without create negatives: Sin crear negativos
joan commented 2022-01-31 16:09:01 +00:00
Contributor
Copy Link

Create without negatives

Create without negatives
alexm marked this conversation as resolved
alexm added 2 commits 2022-02-01 06:21:51 +00:00
gitea/salix/pipeline/head This commit looks good Details
60adb6f37c translations
alexm requested review from joan 2022-02-01 06:34:35 +00:00
carlosjr approved these changes 2022-02-01 08:27:23 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
joan approved these changes 2022-02-01 08:34:32 +00:00
joan merged commit 3725d5451c into dev 2022-02-01 08:34:41 +00:00
joan deleted branch 3430-ticket_step-two 2022-02-01 08:34:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#823
No description provided.
Delete Branch "3430-ticket_step-two"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?