verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 56 Releases Wiki Activity

3676-zone_delivery-days #891

Merged
carlosjr merged 8 commits from 3676-zone_delivery-days into dev 2022-03-07 10:26:08 +00:00
Conversation 0 Commits 8 Files Changed 10 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b421038bbe - Show all commits

3
modules/zone/back/methods/zone/getZoneClosing.js
View File

@ -58,8 +58,7 @@ module.exports = Self => {
) )
AND z.id IN (${paramsString}) AND z.id IN (${paramsString})
alexm marked this conversation as resolved Outdated
carlosjr commented 2022-03-07 08:40:33 +00:00
Outdated
Review
Copy Link

try not to use variables instead of "?" to prevent posible sql injections

try not to use variables instead of "?" to prevent posible sql injections
ORDER BY type='day' DESC, type='range' DESC, type='indefinitely' DESC) z ORDER BY type='day' DESC, type='range' DESC, type='indefinitely' DESC) z
GROUP BY z.id GROUP BY z.id`;
`;
return await Self.rawSql(query, paramsSql, myOptions); return await Self.rawSql(query, paramsSql, myOptions);
alexm marked this conversation as resolved Outdated
carlosjr commented 2022-03-07 08:36:58 +00:00
Outdated
Review
Copy Link

is the await needed or can return the promise?

is the await needed or can return the promise?
}; };