verdnatura/salix
verdnatura
/
salix
3
5
Fork 2
Code Issues Pull Requests 71 Releases Wiki Activity

3795-client_administraive #938

Merged
joan merged 9 commits from 3795-client_administraive into dev 2022-05-10 08:26:42 +00:00
Conversation 0 Commits 9 Files Changed 13 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 36addcdb6c - Show all commits

4
e2e/paths/02-client/12_lock_of_verified_data.spec.js
View File

@ -123,13 +123,13 @@ describe('Client lock verified data path', () => {
await page.accessToSection('client.card.fiscalData'); await page.accessToSection('client.card.fiscalData');
}, 20000); }, 20000);
it('should confirm verified data button is enabled for salesAssistant', async() => { it('should confirm verified data button is disabled for salesAssistant', async() => {
alexm marked this conversation as resolved Outdated
carlosjr commented 2022-04-13 09:22:02 +00:00
Outdated
Review
Copy Link

button doens't seem to be enabled.

button doens't seem to be enabled.
const isDisabled = await page.isDisabled(selectors.clientFiscalData.verifiedDataCheckbox); const isDisabled = await page.isDisabled(selectors.clientFiscalData.verifiedDataCheckbox);
expect(isDisabled).toBeTruthy(); expect(isDisabled).toBeTruthy();
alexm marked this conversation as resolved Outdated
carlosjr commented 2022-05-09 12:47:53 +00:00
Outdated
Review
Copy Link

when evaluating booleans use boolean matchers ie: toBeTrue or toEqual(true)

any defined variable would pass as truthy, therefore may be a false negative.

when evaluating booleans use boolean matchers ie: toBeTrue or toEqual(true) any defined variable would pass as truthy, therefore may be a false negative.
}); });
it('should now edit the social name', async() => { it('should return error when edit the social name', async() => {
alexm marked this conversation as resolved Outdated
carlosjr commented 2022-04-13 09:22:26 +00:00
Outdated
Review
Copy Link

doesn't seem to be changing data

doesn't seem to be changing data
await page.clearInput(selectors.clientFiscalData.socialName); await page.clearInput(selectors.clientFiscalData.socialName);
await page.write(selectors.clientFiscalData.socialName, 'new social name edition'); await page.write(selectors.clientFiscalData.socialName, 'new social name edition');
await page.waitToClick(selectors.clientFiscalData.saveButton); await page.waitToClick(selectors.clientFiscalData.saveButton);