verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

3870-models #975

Merged
carlosjr merged 9 commits from 3870-models into dev 2022-05-23 12:42:31 +00:00
Conversation 0 Commits 9 Files Changed 10 -3
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit db7638f153 - Show all commits

3
modules/worker/back/models/worker.json
View File

@ -47,9 +47,6 @@
"SSN": {
"type" : "string"
},
"sectorFk": {
"type" : "number"
},
"labelerFk": {
vicent marked this conversation as resolved
carlosjr commented 2022-05-20 09:21:22 +00:00
Review
Copy Link

it is of good practice to create the relations for foreign keys and their respective models if not created yet.

also the worker model doens't seem to be the best place to allocate such properties.

it is of good practice to create the relations for foreign keys and their respective models if not created yet. also the worker model doens't seem to be the best place to allocate such properties.
carlosjr commented 2022-05-23 09:48:42 +00:00
Review
Copy Link

remove this

remove this
"type" : "number"
vicent marked this conversation as resolved
carlosjr commented 2022-05-23 09:49:23 +00:00
Review
Copy Link

remove this prop

remove this prop
}