From 48fed98183ea9ffdbad269524eafd2561e5ccc53 Mon Sep 17 00:00:00 2001
From: Juan Ferrer Toribio <juan@verdnatura.es>
Date: Mon, 21 Mar 2022 13:06:23 +0100
Subject: [PATCH] certbot: removed cron config file, already created by certbot

---
 README.md             | 21 ++++++++++++++++-----
 certbot/Dockerfile    |  3 ---
 certbot/certbot-renew |  2 --
 3 files changed, 16 insertions(+), 10 deletions(-)
 delete mode 100644 certbot/certbot-renew

diff --git a/README.md b/README.md
index bd47280..fc9cefb 100644
--- a/README.md
+++ b/README.md
@@ -4,19 +4,30 @@ Dockerfile and compose files used as basis for service deployment.
 
 ## Build and push an image
 
-Build the image.
+Full image name is made up of registry URL and image name.
 ```
-$ docker build -t [registryUrl]/[imageName]:[tag] [folder]
+fullImageName = [registryUrl]/[baseImageName]
 ```
 
-Login into docker registry.
+Build the image with *latest* tag.
+```
+$ docker build -t [fullImageName] [folder]
+```
+
+Tag the image with version.
+```
+$ docker build -t [fullImageName] [fullImageName]:[tag]
+```
+
+Login into docker registry (If it's the first time or you are not saving credentials).
 ```
 $ docker login [registryUrl]
 ```
 
-Push the image.
+Push the *latest* image and version tag.
 ```
-$ docker push [registryUrl]/[imageName]:[tag]
+$ docker push [fullImageName]
+$ docker push [fullImageName]:[tag]
 ```
 
 Logout from docker registry (If you don't logout, credentials will remain saved
diff --git a/certbot/Dockerfile b/certbot/Dockerfile
index b7f8667..68e3679 100644
--- a/certbot/Dockerfile
+++ b/certbot/Dockerfile
@@ -9,8 +9,5 @@ RUN apt-get update \
         openssh-client \
     && rm -rf /var/lib/apt/lists/*
 
-COPY certbot-renew /etc/cron.d/
-
 VOLUME ["/etc/letsencrypt"]
-
 CMD ["cron", "-f"]
diff --git a/certbot/certbot-renew b/certbot/certbot-renew
deleted file mode 100644
index 9293dbd..0000000
--- a/certbot/certbot-renew
+++ /dev/null
@@ -1,2 +0,0 @@
-MAILTO=hostmaster
-0 */12 * * * root certbot -q renew