verdnatura
/
vn-rfid
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

5130-arc_counter #2

Merged
alexm merged 5 commits from 5130-arc_counter into dev 2023-02-06 08:59:03 +00:00
Conversation 0 Commits 5 Files Changed 9 +86 -49
alexm commented 2023-01-27 13:15:13 +00:00
Member
Copy Link
No description provided.
alexm added 2 commits 2023-01-27 13:15:13 +00:00
gitea/vn-rfid/pipeline/head This commit looks good Details
8142dfb430 feat: add counter 
refs #5130
gitea/vn-rfid/pipeline/head This commit looks good Details
ebbc27b56d feat: set null when stop
alexm added 1 commit 2023-01-31 13:59:14 +00:00
gitea/vn-rfid/pipeline/head This commit looks good Details
99d6f81671 fix bugs
alexm added 1 commit 2023-02-02 13:51:31 +00:00
gitea/vn-rfid/pipeline/head This commit looks good Details
94296c23b9 fix: update counter
juan requested changes 2023-02-03 08:24:01 +00:00
src/newPallet.js Outdated
@ -8,1 +5,4 @@
console.logger.info('PRINTING...');
console.log([Array.from(rfids), arcId, null]);
await con.query(`CALL vn.expeditionPallet_build(JSON_ARRAY(?), ?, ?, @palletId);`, [Array.from(rfids), arcId, null]);
const [[{palletId}]] = await con.query(`SELECT @palletId as palletId;`);
juan commented 2023-02-03 08:20:49 +00:00
Owner
Copy Link

No fa falta seleccionar el id pallet per saber si ha donat error, deuría de ficarse un try { } catch ... en la crida a vn.expeditionPallet_build

No fa falta seleccionar el id pallet per saber si ha donat error, deuría de ficarse un `try { } catch ...` en la crida a `vn.expeditionPallet_build`
alexm marked this conversation as resolved
src/newPallet.js Outdated
@ -11,2 +10,3 @@
await counter(null, arcId);
if (!palletId)
console.logger.info({error: 'ERROR_CREATING_PALLET', expeditions: rfids});
console.logger.error({error: 'ERROR_CREATING_PALLET', expeditions: rfids});
juan commented 2023-02-03 08:21:12 +00:00
Owner
Copy Link

Ficar dins del catch anterior

Ficar dins del catch anterior
alexm marked this conversation as resolved
src/stream.js Outdated
@ -13,3 +16,4 @@
stream
.on('data', async value => {
const parsed = await rfidParser(value);
console.log(parsed.codes);
juan commented 2023-02-03 08:22:13 +00:00
Owner
Copy Link

Has oblidat llevar este console.log? Plenara el log del servidor de ruido

Has oblidat llevar este console.log? Plenara el log del servidor de ruido
alexm marked this conversation as resolved
alexm reviewed 2023-02-03 08:50:31 +00:00
src/newPallet.js Outdated
@ -9,2 +7,3 @@
await con.query(`CALL vn.expeditionPallet_build(JSON_ARRAY(?), ?, ?, @palletId);`, [Array.from(rfids), arcId, null]);
const [[{palletId}]] = await con.query(`SELECT @palletId as palletId;`);
const palletId = await con.query(`CALL vn.expeditionPallet_build(JSON_ARRAY(?), ?, ?, @palletId);`, [Array.from(codes), arcId, null]);
alexm commented 2023-02-03 08:50:31 +00:00
Author
Member
Copy Link

Que traduzca el error tambien

Que traduzca el error tambien
alexm marked this conversation as resolved
alexm added 1 commit 2023-02-03 12:20:06 +00:00
gitea/vn-rfid/pipeline/head This commit looks good Details
00262e5dd0 refactor newPallet and use translator
alexm requested review from juan 2023-02-03 12:20:51 +00:00
juan approved these changes 2023-02-03 13:49:42 +00:00
alexm merged commit 17b8ee9194 into dev 2023-02-06 08:59:03 +00:00
alexm deleted branch 5130-arc_counter 2023-02-06 08:59:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/vn-rfid#2
No description provided.
Delete Branch "5130-arc_counter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?